ES.30: Don’t use macros for program text manipulation - example warnings

[jonnygrant]

There is a warning about the unused x,y params in the example - Can those x,y there be removed?

<source>: In function 'void f(int, int)':
<source>:17:12: warning: unused parameter 'x' [-Wunused-parameter]
   17 | void f(int x, int y)
      |        ~~~~^
<source>:17:19: warning: unused parameter 'y' [-Wunused-parameter]
   17 | void f(int x, int y)
      |               ~~~~^

https://godbolt.org/z/hb41sfnsb

[jwakely]

They're presumably "used" in the "// ..." part of the function that isn't shown.

Why does it matter if you get those warnings for the example? It's not a meaningful example that you can reuse in your own code.

[jwakely]

Examples should be valid C++, so fixing the earlier error was useful. I don't see why an example that says void foo(int, int) is better than one that says void foo(int x, int y) though. If they're not named, why are they even there? Just do void foo() ... but then it becomes a less realistic and therefore less useful example.

[jonnygrant]

Those unused parameters don't appear relevant to the example that converts enums to strings to make them useful for the reader. We can close it if you think differently.