-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page template allows long titles to bleed down into content area #189
Comments
Eesh yeah that's not wonderful. I will work on making this more (correctly) responsive |
I just pushed some updates and deployed a new version to GitHub Pages. Please take a look and let me know if you see any areas for improvement :) |
@ncalteen Things look a lot better now, definitely. But if I can make a couple of suggestions... Center-justified textI see the And the thing is, Personally I find the heading in the second one easier to read. (And as the "What is IssueOps?" heading shows, the centering of non-wrapped headings isn't affected.) Document structureI didn't look at the page source originally, but now that I do... it appears that every "paragraph" in the document is inside a It also has accessibility implications. It's no accident I put "paragraph" in quotes above. Much like faking headings with styled WebAIM's "Designing for Screen Reader Compatibility" explains how various structural elements are used by assistive technologies. For headings, it explains:
The situation is similar for paragraphs:
If a document doesn't have paragraphs, and only "fakes" the separation of various pieces of content into paragraph-like blocks using text spans, a screen reader has no way of detecting those separations, and the entire page text (or at least, the text under each heading) looks like one long, run-together paragraph. Paragraphs should use |
Thank you for the deep-dive @ferdnyc! This really helps :) As I'm sure you can imagine, frontend development is not something I spend a ton of time on, so this is very educational. I've gone ahead and implemented the changes you suggested. If you see any other areas of improvement, please keep me posted! |
Screenshot pretty much says it all.
The text was updated successfully, but these errors were encountered: