chore: Workflows for validations #83
Conversation
| - | ||
| uses: actions/checkout@v4 | ||
| - |
There was a problem hiding this comment.
nit: any reason the dashes are on their own lines?
There was a problem hiding this comment.
Yeah, I've been seeing this in some newer actions code. I like this style because it makes moving lines around easier since the dash is its own line
| # added some padding chars and now need to replace the padding + quotes. | ||
| # This is preferable to writing an entire huge Java project for a `trim` | ||
| # function in the template. I hate this. 🫣 | ||
| sed -i.bak -E 's/@@@@"([^"]+)"@@@@/\1/g' ./${API}/*.go |
There was a problem hiding this comment.
my sed-foo is terrible. Did you find a work around to the differences between sed in mac and linux?
There was a problem hiding this comment.
Yeah! Turns out if we just set it and cleanup after, that param just configures extensions to use for local backups.
There was a problem hiding this comment.
Did we ever resolve the SDK ordering issue where some schemas are named with numerical suffixes and would sometimes generate in a different order? I don't have an example off-hand but if you run the generator a handful of times you may run into it. Any automation we build around generating the SDK will probably have to address that issue before we can rely on it, otherwise if we rename these types due to random ordering the clients will break.
We have not addressed it yet. In the meantime, I added this workflow so we can easily re-run generation if something is not looking right to us. |
Workflow for semantic release, as well as PR unit tests