Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrontEnd][Tech Debt] Structure improvements #740

Open
popovycholeg opened this issue Aug 24, 2024 · 0 comments · Fixed by #746
Open

[FrontEnd][Tech Debt] Structure improvements #740

popovycholeg opened this issue Aug 24, 2024 · 0 comments · Fixed by #746
Assignees

Comments

@popovycholeg
Copy link
Collaborator

  1. All folders in the components folder should follow the same naming pattern. Start with an uppercase letter and use a camel case.
    CompanyCard - correct
    terms-and-conditions-app - to improve.
  2. Move component tests from src/tests to component folders.
    src/tests/CompanyCard.test.js => FrontEnd/src/components/CompanyCard.test.js
    We can use the src/tests folder for the integration tests.
  3. Define entry points of React pages in the pages folder. so
  4. Define navigation logic for the client and admin app in the routes folder.
@mehalyna mehalyna changed the title Tech Debt: Structure improvements [FrontEnd][Tech Debt] Structure improvements Aug 28, 2024
@AlexanderSychev2005 AlexanderSychev2005 self-assigned this Aug 28, 2024
@AlexanderSychev2005 AlexanderSychev2005 linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants