Eliminate styling conflicts #1003 #1008
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1008 +/- ##
========================================
Coverage 91.82% 91.82%
========================================
Files 74 74
Lines 1052 1052
========================================
Hits 966 966
Misses 86 86 ☔ View full report in Codecov by Sentry. |
NVMakarenko
requested review from
loqimean,
DanielVajnagi,
olexandervanzuriak,
SleekMutt and
KseniaGovorun
NVMakarenko
commented
Dec 14, 2024
| @@ -5,7 +5,8 @@ module.exports = { | |||
| './public/*.html', | |||
| './app/helpers/**/*.rb', | |||
| './app/javascript/**/*.js', | |||
| './app/views/**/*.erb' | |||
| './app/views/**/*.erb', | |||
| '!./app/views/account/**/*.erb' | |||
| ], | |||
There was a problem hiding this comment.
For unsigned user it is styled with tailwindcss.
for admin it is styled with global Tailwindcss styles and Bootstrap.
loqimean
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
Project
Code reviewers
Second Level Review
Summary of issue
Bootstrap and Tailwindcss were used in the project, I need to analyze where conflict are possible
Summary of change
Configurate Tailwindcss to scan all pages except account directory.
CHECK LIST