-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enforce pagination to avoid resource consumption #145
Comments
We built a rule for exactly this purpose: |
Thanks! I'll check it. OT: how are you going to manage the switch to Spectral 6? Some rules stopped working... |
Moreover w are now supporting versioned rulesets. we are renaming rules because Spectral 6 doesn't allow custom properties in rules: we had then to replace tags with some other mechanism. All security rules will start with sec- We have to identify a prefix for Mandatory Italian rules which are stricter than best practices, eg ita- Otherwise specific keywords can be in the description... We've to think about it. To use versioned ruleset, see https://github.com/italia/api-oas-checker/blob/master/README.en.md#ci-mode-versioned-rulesets @codedust If you need a specific untagged version from the past, just let me know the date and I'll create the missing tag. |
We did not look into switching to Spectral 6 yet, tbh. For now, we're stuck with Spectral 5.
|
Consider extending fitko pagination rules to support configurable parameters |
@AlessioMarinelli I updated the description. See the example schema for pagination fields. https://italia.github.io/api-oas-checker/?url=https://teamdigitale.github.io/openapi/master/definitions.yaml |
Feel free to post your example OAS3 and I'll provide some comments on it. |
I expect
A rule enforcing pagination on GET requests
The rule should comply with:
Note
How to detect if a request requires pagination?
Can we just check if it has parameters?
Whether the response has an array field?
The text was updated successfully, but these errors were encountered: