Use Google Cloud KMS for code signing #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x2b3bfa0
commented
Apr 1, 2024
|
@0x2b3bfa0, do you mind adding an I don't have a Windows machine to test with me, but we should try installing the binary on Windows and see if we get any issues. |
skshetry
approved these changes
Apr 3, 2024
|
|
|
Thank you @0x2b3bfa0. Let's merge it. 🙂 |
0x2b3bfa0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum changes required to comply with the new DigiCert's FIPS 140-2 Level 2 or Common Criteria EAL 4+ requirements.
Closes #175 for a year. 🙃