Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data dictionary repo URL from ITER internal git to github #7

Closed
wants to merge 1 commit into from
Closed

Update data dictionary repo URL from ITER internal git to github #7

wants to merge 1 commit into from

Conversation

maarten-ic
Copy link
Collaborator

No description provided.

@maarten-ic maarten-ic requested a review from olivhoenen January 16, 2025 08:13
@maarten-ic maarten-ic mentioned this pull request Jan 16, 2025
Closed
2 tasks
SimonPinches
SimonPinches approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@SimonPinches SimonPinches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

olivhoenen
olivhoenen reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@olivhoenen olivhoenen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already in #6 together with the package rename. Rather than having an hybrid version with imaspy package and linked to github for the imas-data-dictionary, we will push for a quick release after #6 is merged.

@maarten-ic maarten-ic closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivhoenen olivhoenen olivhoenen left review comments

@SimonPinches SimonPinches SimonPinches approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maarten-ic @SimonPinches @olivhoenen