Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focusing on a heading nested under a link doesn't render a blue outline in Chrome #485

Open
NazimHAli opened this issue Jan 27, 2023 · 4 comments
Labels
accessibility bug note/environment-specific This issue is specific to a device, operating system, or browser

Comments

@NazimHAli
Copy link
Contributor

NazimHAli commented Jan 27, 2023

Expected behavior
A blue outline on focus. Works correctly in Firefox:

Screen Shot 2023-01-27 at 5 52 00 PM

Actual behavior
There's no blue outline on focus

Steps to reproduce the issue

Reproducible in Chrome, but not on Firefox:

  1. In Chrome, visit https://pharos.jstor.org/storybooks/wc/iframe.html?id=components-link--visited-link-heading&viewMode=story
  2. Press tab until it focuses on the link
  3. There's no blue outline on focus

Pharos version
12.17.0

Your environment

  • Browser: Chrome
  • Version: 109.0.5414.119
  • Browser: Safari
  • Version: 15.6.1 (17613.3.9.1.16)
@chrisjbrown
Copy link
Contributor

did some digging and came up empty 😅
same issue it seems in Safari.

I do see the correct styles being added to the #link-element when programmatically selecting it. but for whatever reason it's not shown 😕

@NazimHAli
Copy link
Contributor Author

NazimHAli commented Feb 2, 2023

did some digging and came up empty 😅 same issue it seems in Safari.

I do see the correct styles being added to the #link-element when programmatically selecting it. but for whatever reason it's not shown 😕

I looked into it and found the issue to be not rendering the layout, so we just need to update the display. I will open a PR once I'm able to.

@NazimHAli
Copy link
Contributor Author

Additional findings from research/experimentation for future reference:

@daneah daneah added the note/environment-specific This issue is specific to a device, operating system, or browser label Feb 9, 2023
@daneah
Copy link
Member

daneah commented Jul 7, 2023

We should consider how this is impacted as we think about using :focus-visible (#175)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug note/environment-specific This issue is specific to a device, operating system, or browser
Projects
None yet
Development

No branches or pull requests

3 participants