Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Elevation 5 to MODAL #665

Closed
nkamau opened this issue Jan 17, 2024 · 1 comment
Closed

Apply Elevation 5 to MODAL #665

nkamau opened this issue Jan 17, 2024 · 1 comment

Comments

@nkamau
Copy link
Contributor

nkamau commented Jan 17, 2024

The problem
Devs have to add elevation values to components after adding the component. We want to cut that extra step out. Instead of adding a component then adding the elevation effect after, the elevation effect will already be attached to the component.

The solution
Please use these links to apply the value to the respective component:

MODAL uses Elevation 5.

Please use the value of "pharos-elevation-level-5" in storybook: https://pharos.jstor.org/storybook/?path=/story/react_styles-design-tokens--elevation

@brentswisher
Copy link
Contributor

Closed with #681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants