You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem
There are Pharos components that utilize the label attribute to add the aria-label attribute to the inner HTML element. PR #594 addresses the Button component but there are still a few that need to be updated.
The solution
The following components will need to have the label attribute updated to a11y-label and have similar changes that were made to the Button component.
pharos-dropdown-menu-nav
pharos-link
pharos-popover
Similar to the updates for the Button component it may be wise to create a non-breaking change in a minor release that includes deprecation warnings and then remove those in a breaking change for the next major release.
The text was updated successfully, but these errors were encountered:
The problem
There are Pharos components that utilize the
label
attribute to add thearia-label
attribute to the inner HTML element. PR #594 addresses the Button component but there are still a few that need to be updated.The solution
The following components will need to have the
label
attribute updated toa11y-label
and have similar changes that were made to the Button component.Similar to the updates for the Button component it may be wise to create a non-breaking change in a minor release that includes deprecation warnings and then remove those in a breaking change for the next major release.
The text was updated successfully, but these errors were encountered: