Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components using ARIA attributes to new "a11y-" naming convention #674

Closed
sirrah-tam opened this issue Jan 22, 2024 · 1 comment
Closed

Comments

@sirrah-tam
Copy link
Contributor

The problem
There are Pharos components that utilize the label attribute to add the aria-label attribute to the inner HTML element. PR #594 addresses the Button component but there are still a few that need to be updated.

The solution
The following components will need to have the label attribute updated to a11y-label and have similar changes that were made to the Button component.

  • pharos-dropdown-menu-nav
  • pharos-link
  • pharos-popover

Similar to the updates for the Button component it may be wise to create a non-breaking change in a minor release that includes deprecation warnings and then remove those in a breaking change for the next major release.

@sirrah-tam
Copy link
Contributor Author

Closed after merging in #675 & #675 to their respective branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant