Fix sonar warnings

Author: kaklakariada

jfxui/src/main/java/org/itsallcode/whiterabbit/jfxui/table/days/DayRecordTable.java

@@ -117,7 +117,7 @@ private void updateSelectedRow(final MonthIndex previousMonth, final MonthIndex
         }
     }
 
-    private boolean otherMonthSelected(final MonthIndex previousMonth, final MonthIndex month)
+    private static boolean otherMonthSelected(final MonthIndex previousMonth, final MonthIndex month)
     {
         return previousMonth != null
                 && !month.getYearMonth().equals(previousMonth.getYearMonth());

jfxui/src/main/java/org/itsallcode/whiterabbit/jfxui/ui/YearlyProjectReportViewer.java

@@ -71,7 +71,7 @@ private static ReportRow createRow(final int year, final ProjectReportActivity p
         return new ReportRow(year, project);
     }
 
-    public static class ReportRow
+    public final static class ReportRow
     {
         private final int year;
         private final ProjectReportActivity project;

logic/src/main/java/org/itsallcode/whiterabbit/logic/autocomplete/AutocompleteService.java

@@ -111,7 +111,7 @@ public Optional<ProjectImpl> getSuggestedProject()
         return mostFrequentlyUsedProject;
     }
 
-    private static class CachingAutocompleter implements AutocompleteEntrySupplier
+    private static final class CachingAutocompleter implements AutocompleteEntrySupplier
     {
         private TextIndex index;
         private final Supplier<List<String>> availableTextSupplier;

logic/src/main/java/org/itsallcode/whiterabbit/logic/autocomplete/TextIndex.java

@@ -15,7 +15,7 @@
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
-class TextIndex implements AutocompleteEntrySupplier
+final class TextIndex implements AutocompleteEntrySupplier
 {
     private static final Logger LOG = LogManager.getLogger(TextIndex.class);
     private static final int MAX_RESULTS = 10;

logic/src/main/java/org/itsallcode/whiterabbit/logic/model/DayActivities.java

@@ -136,6 +136,7 @@ private Duration getUnallocatedDuration()
         return dayRecord.getWorkingTime().minus(allocatedDuration);
     }
 
+    @SuppressWarnings("java:S1142") // More than 3 returns required for logging
     public boolean isValidAllocation()
     {
         final List<ActivityData> remainderActivities = getActivities()

logic/src/main/java/org/itsallcode/whiterabbit/logic/model/MonthIndex.java

@@ -21,12 +21,13 @@
 import org.itsallcode.whiterabbit.logic.service.contract.ContractTermsService;
 import org.itsallcode.whiterabbit.logic.service.project.ProjectService;
 
-public class MonthIndex
+public final class MonthIndex
 {
     private final ModelFactory modelFactory;
     private final MonthData monthRecord;
     private final Map<LocalDate, DayRecord> days;
 
+    @SuppressWarnings("java:S2384") // Storing a copy of "days" is required here
     private MonthIndex(final ModelFactory modelFactory, final MonthData monthRecord,
             final Map<LocalDate, DayRecord> days)
     {

logic/src/main/java/org/itsallcode/whiterabbit/logic/report/project/ProjectReportGenerator.java

@@ -19,64 +19,64 @@
 
 public class ProjectReportGenerator
 {
-        private final Storage storage;
+    private final Storage storage;
 
-        public ProjectReportGenerator(final Storage storage)
-        {
-                this.storage = storage;
-        }
+    public ProjectReportGenerator(final Storage storage)
+    {
+        this.storage = storage;
+    }
 
-        public ProjectReport generateReport(final YearMonth month)
-        {
-                final List<DayRecord> sortedDays = storage.loadMonth(month)
-                                .map(MonthIndex::getSortedDays).orElse(Stream.empty()).toList();
+    public ProjectReport generateReport(final YearMonth month)
+    {
+        final List<DayRecord> sortedDays = storage.loadMonth(month)
+                .map(MonthIndex::getSortedDays).orElse(Stream.empty()).toList();
 
-                final List<ProjectReportDay> reportDays = sortedDays.stream()
-                                .map(this::generateDayReport)
-                                .toList();
+        final List<ProjectReportDay> reportDays = sortedDays.stream()
+                .map(this::generateDayReport)
+                .toList();
 
-                final List<ProjectReportActivity> reportProjects = sortedDays.stream()
-                                .flatMap(day -> day.activities().getAll().stream())
-                                .filter(activity -> activity.getProject() != null)
-                                .collect(groupingBy(Activity::getProject))
-                                .values().stream()
-                                .map(ProjectReportGenerator::aggregateProject)
-                                .toList();
+        final List<ProjectReportActivity> reportProjects = sortedDays.stream()
+                .flatMap(day -> day.activities().getAll().stream())
+                .filter(activity -> activity.getProject() != null)
+                .collect(groupingBy(Activity::getProject))
+                .values().stream()
+                .map(ProjectReportGenerator::aggregateProject)
+                .toList();
 
-                return new ProjectReportImpl(month, reportDays, reportProjects);
-        }
+        return new ProjectReportImpl(month, reportDays, reportProjects);
+    }
 
-        private ProjectReportDay generateDayReport(final DayRecord dayRecord)
-        {
-                final List<ProjectReportActivity> projects = dayRecord.activities()
-                                .getAll().stream()
-                                .filter(activity -> activity.getProject() != null)
-                                .collect(groupingBy(this::activityProject))
-                                .values().stream()
-                                .map(ProjectReportGenerator::aggregateProject)
-                                .toList();
+    private ProjectReportDay generateDayReport(final DayRecord dayRecord)
+    {
+        final List<ProjectReportActivity> projects = dayRecord.activities()
+                .getAll().stream()
+                .filter(activity -> activity.getProject() != null)
+                .collect(groupingBy(this::activityProject))
+                .values().stream()
+                .map(ProjectReportGenerator::aggregateProject)
+                .toList();
 
-                return new DayImpl(dayRecord.getDate(), dayRecord.getType(), dayRecord.getComment(), projects);
-        }
+        return new DayImpl(dayRecord.getDate(), dayRecord.getType(), dayRecord.getComment(), projects);
+    }
 
-        private String activityProject(final Activity activity)
-        {
-                return activity.getProject().getProjectId();
-        }
+    private String activityProject(final Activity activity)
+    {
+        return activity.getProject().getProjectId();
+    }
 
-        private static ProjectReportActivity aggregateProject(final List<Activity> projectActivites)
-        {
-                final Duration totalWorkingTime = projectActivites.stream()
-                                .filter(activity -> activity.getDuration() != null)
-                                .map(Activity::getDuration).reduce(Duration::plus)
-                                .orElse(Duration.ZERO);
-                final List<String> comments = projectActivites.stream()
-                                .map(Activity::getComment)
-                                .filter(Objects::nonNull)
-                                .filter(comment -> !comment.isBlank())
-                                .distinct()
-                                .toList();
-                return new ProjectReportImpl.ProjectActivityImpl(projectActivites.get(0).getProject(), totalWorkingTime,
-                                comments);
-        }
+    private static ProjectReportActivity aggregateProject(final List<Activity> projectActivites)
+    {
+        final Duration totalWorkingTime = projectActivites.stream()
+                .filter(activity -> activity.getDuration() != null)
+                .map(Activity::getDuration).reduce(Duration::plus)
+                .orElse(Duration.ZERO);
+        final List<String> comments = projectActivites.stream()
+                .map(Activity::getComment)
+                .filter(Objects::nonNull)
+                .filter(comment -> !comment.isBlank())
+                .distinct()
+                .toList();
+        return new ProjectReportImpl.ProjectActivityImpl(projectActivites.get(0).getProject(), totalWorkingTime,
+                comments);
+    }
 }

logic/src/main/java/org/itsallcode/whiterabbit/logic/service/plugin/AppPluginImpl.java

@@ -12,7 +12,7 @@
 import org.itsallcode.whiterabbit.api.features.PluginFeature;
 import org.itsallcode.whiterabbit.logic.Config;
 
-class AppPluginImpl implements AppPlugin
+final class AppPluginImpl implements AppPlugin
 {
     private static final Logger LOG = LogManager.getLogger(AppPluginImpl.class);
 
@@ -70,6 +70,7 @@ public boolean supports(final Class<? extends PluginFeature> featureType)
         }
     }
 
+    @Override
     public <T extends PluginFeature> Optional<T> getFeature(final Class<T> featureType)
     {
         return plugin.getFeature(featureType);