Bump actions/upload-artifact from 3 to 4 (#269)

* Bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix duplicate package names

* Simplify build

* Update vscode config

* Update build script

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kaklakariada <kaklakariada@users.noreply.github.com>

Author: dependabot[bot]

.github/workflows/build.yml

@@ -40,13 +40,13 @@ jobs:
     - uses: gradle/wrapper-validation-action@v1
 
     - name: Cache SonarQube packages
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: ~/.sonar/cache
         key: ${{ runner.os }}-java-${{ matrix.java }}-sonar
         restore-keys: ${{ runner.os }}-java-${{ matrix.java }}-sonar
 
-    - name: Build with Gradle
+    - name: Build with Gradle using Java ${{ matrix.java }}
       run: |
         ./gradlew build --info --warning-mode=summary -PskipFlakyTests=true -PjavaVersion=${{ matrix.java }}
 
@@ -65,14 +65,14 @@ jobs:
         report_paths: '**/build/test-results/*/TEST-*.xml'
         github_token: ${{ secrets.GITHUB_TOKEN }}
 
-    - name: Archive executable jar
-      uses: actions/upload-artifact@v3
+    - name: Archive executable JAR for ${{ matrix.java }}
+      uses: actions/upload-artifact@v4
       if: ${{ env.DEFAULT_JAVA == matrix.java && env.DEFAULT_OS == matrix.os }}
       with:
         name: packages
         path: jfxui/build/libs/white-rabbit-fx-*.jar
 
-    - name: Build native package for ${{ runner.os }}
+    - name: Build native package for ${{ runner.os }} using Java ${{ matrix.java }}
       if: ${{ env.DEFAULT_JAVA == matrix.java }}
       run: |
         ./gradlew jpackage createChecksums --info --warning-mode=summary -PjavaVersion=${{ matrix.java }}
@@ -82,16 +82,16 @@ jobs:
         ./gradlew -status
         ./gradlew -stop
 
-    - name: Archive native package
-      uses: actions/upload-artifact@v3
+    - name: Archive native package for ${{ runner.os }}
+      uses: actions/upload-artifact@v4
       if: ${{ env.DEFAULT_JAVA == matrix.java }}
       with:
-        name: packages
+        name: packages-${{ runner.os }}
         path: jfxui/build/jpackage-dist/*
 
-    - name: Archive checksums
-      uses: actions/upload-artifact@v3
+    - name: Archive checksums for ${{ runner.os }}
+      uses: actions/upload-artifact@v4
       if: ${{ env.DEFAULT_JAVA == matrix.java }}
       with:
-        name: checksums
+        name: checksums-${{ runner.os }}
         path: jfxui/build/generatedChecksums/*

.github/workflows/codeql-analysis.yml

@@ -18,8 +18,6 @@ jobs:
 
     strategy:
       fail-fast: false
-      matrix:
-        language: ['java']
 
     steps:
     - name: Checkout repository
@@ -38,7 +36,7 @@ jobs:
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3
       with:
-        languages: ${{ matrix.language }}
+        languages: java
 
     - name: Autobuild
       uses: github/codeql-action/autobuild@v3

.vscode/settings.json

@@ -10,8 +10,8 @@
         ".idea/": true,
     },
     "editor.codeActionsOnSave": {
-        "source.organizeImports": true,
-        "source.fixAll": true,
+        "source.organizeImports": "explicit",
+        "source.fixAll": "explicit"
     },
     "java.codeGeneration.useBlocks": true,
     "editor.formatOnSave": true,