Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-think current margin setup #64

Open
ivarref opened this issue May 1, 2017 · 6 comments
Open

Re-think current margin setup #64

ivarref opened this issue May 1, 2017 · 6 comments

Comments

@ivarref
Copy link
Owner

ivarref commented May 1, 2017

Probably should use something like [:g (translate 15 15) ... at the top (?)

@ivarref
Copy link
Owner Author

ivarref commented May 5, 2017

Make axis rendering only grow downwards and to the right.

This means that merely something like available-width and available-height will be sent in to the axis.
The actual width and height of the chart itself will be determined based on text width & height.

@ivarref
Copy link
Owner Author

ivarref commented May 5, 2017

This should be a separate abstraction that uses scale behind the scenes.

@ivarref
Copy link
Owner Author

ivarref commented May 5, 2017

This is because both x and y scales/axis may contribute to margins.

@ivarref
Copy link
Owner Author

ivarref commented May 5, 2017

For example: Y axis labels will contribute to margins that will determine the width.

@ivarref
Copy link
Owner Author

ivarref commented May 5, 2017

IF x axis labels should be allowed to be rotated, then they also may severely contribute to height...

@ivarref
Copy link
Owner Author

ivarref commented May 5, 2017

But usually y axis (ordinal) labels will have the greatest impact on width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant