From 5b4864166ebc468b4f5280a30f69b1eaca571080 Mon Sep 17 00:00:00 2001 From: Abdurrahman Rajab Date: Thu, 14 Sep 2023 12:51:23 +0300 Subject: [PATCH] ci: show welcome message always (#23592) --- .../{auto-comment.yml => welcome-message.yml} | 118 +++++++++--------- 1 file changed, 56 insertions(+), 62 deletions(-) rename .github/workflows/{auto-comment.yml => welcome-message.yml} (80%) diff --git a/.github/workflows/auto-comment.yml b/.github/workflows/welcome-message.yml similarity index 80% rename from .github/workflows/auto-comment.yml rename to .github/workflows/welcome-message.yml index 4df3253fbad38..93c6373aa00e1 100644 --- a/.github/workflows/auto-comment.yml +++ b/.github/workflows/welcome-message.yml @@ -1,62 +1,56 @@ -name: Check Semantic and welcome new contributors - -on: - pull_request_target: - types: - - opened - - edited - - synchronize - - reopened - workflow_call: - -permissions: - pull-requests: write - -jobs: - semantics: - name: Semantics - runs-on: ubuntu-latest - timeout-minutes: 10 - steps: - - uses: amannn/action-semantic-pull-request@v3.4.0 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - pr-compliance-checks: - name: PR Compliance Checks - runs-on: ubuntu-latest - timeout-minutes: 10 - steps: - - uses: mtfoley/pr-compliance-action@v0.5.0 - with: - body-auto-close: false - protected-branch-auto-close: false - body-comment: > - ## Issue Reference - - In order to be considered for merging, the pull request description must refer to a - specific issue number. This is described in our - [contributing guide](https://unify.ai/docs/ivy/overview/contributing/the_basics.html#todo-list-issues) and our PR template. - - This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue - number that this PR is meant to address. - - welcome: - name: Welcome - runs-on: ubuntu-latest - timeout-minutes: 10 - needs: semantics - if: github.event.action == 'opened' - steps: - - uses: actions/first-interaction@v1 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - pr-message: |- - Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉 - Joing the conversation in our [Discord](https://discord.com/invite/sXyFF8tDtm) - - Here are some notes to understand our tests: - - We have merged all the tests in one file called \`display_test_results\` job. 👀 It contains the following two sections: - - **Combined Test Results:** This shows the results of all the ivy tests that ran on the PR. ✔️ - - **New Failures Introduced:** This lists the tests that are passing on main, but fail on the PR Fork. - Please try to make sure that there are no such tests. 💪 \ No newline at end of file +name: Check Semantic and welcome new contributors + +on: + pull_request_target: + types: + - opened + - edited + - synchronize + - reopened + workflow_call: + +permissions: + pull-requests: write + +jobs: + pr-compliance-checks: + name: PR Compliance Checks + runs-on: ubuntu-latest + timeout-minutes: 10 + steps: + - uses: mtfoley/pr-compliance-action@v0.5.0 + with: + body-auto-close: false + protected-branch-auto-close: false + body-comment: > + ## Issue Reference + + In order to be considered for merging, the pull request description must refer to a + specific issue number. This is described in our + [contributing guide](https://unify.ai/docs/ivy/overview/contributing/the_basics.html#todo-list-issues) and our PR template. + + This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue + number that this PR is meant to address. + + welcome: + name: Welcome + runs-on: ubuntu-latest + timeout-minutes: 10 + needs: semantics + if: github.event.action == 'opened' + steps: + - uses: actions/first-interaction@v1 + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} + pr-message: |- + Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉 + Join the conversation in our [Discord](https://discord.com/invite/sXyFF8tDtm) + + Here are some notes to understand our tests: + - We have merged all the tests in one file called \`display_test_results\` job. 👀 It contains the following two sections: + - **Combined Test Results:** This shows the results of all the ivy tests that ran on the PR. ✔️ + - **New Failures Introduced:** This lists the tests that fails on this PR. + + Please make sure they are passing. 💪 + + Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, so be patient. \ No newline at end of file