feat: Added ref method to TensorFlow Frontend #26316
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord
Here are some notes to understand our tests:
- We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that fails on this PR.
Please make sure they are passing. 💪
Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.
ShruAgarwal
changed the title
ivy-leaves
added
the
TensorFlow Frontend
There was a problem hiding this comment.
I have added the ref() function method for the code number lines 59, 60 and 61. It requires ref() method to be added into the code for Tensorflow Frontend application for the issue #26316
| @@ -53,6 +53,9 @@ def shape(self): | |||
| def get_shape(self): | |||
| return tf_frontend.raw_ops.Shape(input=self) | |||
|
|
|||
| def ref(self): | |||
| return self._ivy_array.ref() | |||
|
|
|||
| def set_shape(self, shape): | |||
| if shape is None: | |||
| return | |||
There was a problem hiding this comment.
def ref(self, shape):
if shape is None:
return self._ivy_array.ref()
There was a problem hiding this comment.
Hey @Kamalesh3112
Thanks for reviewing! :)
But, according to the TensorFlow API docs, ref method doesn't have any parameters. 😅
Did you add that by mistake or does it point to something that needs to be improved?
There was a problem hiding this comment.
Yeah, the ref() method doesn't have any parameters and it has to be improved by adding those particular lines of code.
This reverts commit 32dfce66a478360e4a9897e71028b147da752b2b.
ShruAgarwal
force-pushed
the
add_tf_ref
branch
from
c07240a
to
8d5cc46
Compare
This reverts commit 8d5cc46.
|
@KareemMAX Sorry for those extra revert commits as I'm learning to figure it out. 😅 Also, do the failed checks from above need to be resolved? |
|
Hi @ShruAgarwal , |
1 similar comment
|
Hi @ShruAgarwal , |
Hey @NiteshK84, |
|
Hello, I think this PR is unactive for a little while, so I'll close it for now. If you want to continue working on it in the future please feel free to open it and start working. Thanks and happy contributing 😊 |
PR Description
Implemented an Instance Method named,
refto TensorFlow FrontendI tested running the function over all backends but, unfortunately, it fails for all of them except for
tensorflow. Later, I came to know thatrefmethod or any such similar method doesn't exist in any other backend frameworks. 😅Related Issue
Pending issue to be resolved #26516
Close #26140
Checklist
Please review the changes and let me know your thoughts if I'm correct or not. 🙏