Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budget vs compressed size? - add Gzip support #3

Open
cjsaylor opened this issue Mar 26, 2018 · 5 comments
Open

Budget vs compressed size? - add Gzip support #3

cjsaylor opened this issue Mar 26, 2018 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@cjsaylor
Copy link

Would it be possible to have the budget calculate the gzipped value? I assume most people serve their apps gzipped (I do from S3), and trying to estimate the uncompressed budget isn't ideal.

@jadjoubran jadjoubran added the enhancement New feature or request label Mar 26, 2018
@jadjoubran
Copy link
Owner

Thanks for checking it out and opening an issue Chris!
I do agree that gzipped would be useful
GZip stats would make sense when taking into consideration
however from a parse performance perspective, the size (after Gzip) of JavaScript that you're running in the browser matters a lot on Mobile
So 500kb on JS on mobile is 500kb of JS (regardless of whether it was Gzipped or not), and as demonstrated in the article referenced below

1_8bq3bcyu1avvjwpr1x8yig

I think we'll have a gzip toggle that you can enable & disable, and I will try to get in touch with @addyosmani if possible to get a recommendation on the defaults as I'd love to make people more aware about the cost of JavaScript

Source: The Cost of JavaScript

@cjsaylor
Copy link
Author

Good point, nice article info, thank!

@jadjoubran jadjoubran added this to the 1.3 milestone Mar 27, 2018
@jadjoubran
Copy link
Owner

okay so I got a response!
Let's go with 170KB gzipped as a default, and developers can customize the values
So default is gzipped
budget is 170kb (customizable)
and rather than a toggle, we'll display the total size (non compressed)

@jadjoubran
Copy link
Owner

@jadjoubran
Copy link
Owner

will also add brotli support
so we probably need a dropdown/toggle

@jadjoubran jadjoubran changed the title Budget vs compressed size? Budget vs compressed size? - add Gzip support Mar 31, 2018
jadjoubran added a commit that referenced this issue Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants