Skip to content
This repository was archived by the owner on May 18, 2020. It is now read-only.

Commit 07bfd6d

Browse files
committed
Rename tests and minor refactor
1 parent 03ba3e2 commit 07bfd6d

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

all-in-one/src/test/java/io/jaegertracing/kubernetes/AllInOneETest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@
1414
package io.jaegertracing.kubernetes;
1515

1616
import io.jaegertracing.kubernetes.deployment.BaseETest;
17+
import org.junit.Ignore;
1718

1819
/**
1920
* @author Pavol Loffay
2021
*/
22+
@Ignore
2123
public class AllInOneETest extends BaseETest {
2224
}

jaegertracing-kubernetes-deployment-itest/src/main/java/io/jaegertracing/kubernetes/deployment/BaseETest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,13 @@ public class BaseETest {
6767
@Named(COLLECTOR_SERVICE_NAME)
6868
@PortForward
6969
@ArquillianResource
70-
protected URL collectorUrl;
70+
private URL collectorUrl;
7171

7272
@Port(9411)
7373
@Named(ZIPKIN_SERVICE_NAME)
7474
@PortForward
7575
@ArquillianResource
76-
protected URL zipkinUrl;
76+
private URL zipkinUrl;
7777

7878
@Test
7979
public void testUiResponds() throws IOException, InterruptedException {

production-elasticsearch/src/test/java/io/jaegertracing/kubernetes/ProductionETest.java renamed to production-elasticsearch/src/test/java/io/jaegertracing/kubernetes/ElasticearchETest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,14 @@
2020
import okhttp3.Request;
2121
import okhttp3.Response;
2222
import org.junit.Before;
23+
import org.junit.Ignore;
2324

2425
import static org.awaitility.Awaitility.await;
2526

2627
/**
2728
* @author Pavol Loffay
2829
*/
29-
public class ProductionETest extends BaseETest {
30+
public class ElasticearchETest extends BaseETest {
3031

3132
/**
3233
* We need to initialize ES storage, before we proceed to tests for two reasons:
@@ -53,6 +54,7 @@ public void before() {
5354
});
5455
}
5556

57+
@Ignore("It requires spark job")
5658
public void testDependencyLinks() throws IOException, InterruptedException {
5759
}
5860
}

production/src/test/java/io/jaegertracing/kubernetes/ProductionETest.java renamed to production/src/test/java/io/jaegertracing/kubernetes/CassandraETest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
/**
2121
* @author Pavol Loffay
2222
*/
23-
public class ProductionETest extends BaseETest {
23+
public class CassandraETest extends BaseETest {
2424

25-
@Ignore("dependency links returns 404 because of old Cassandra image")
25+
@Ignore("It requires spark job")
2626
public void testDependencyLinks() throws IOException, InterruptedException {
2727
}
2828
}

0 commit comments

Comments
 (0)