Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode/light mode toggle button not visible on safari browser, macOS #24

Closed
Peddinti-Sriram-Bharadwaj opened this issue Oct 4, 2024 · 3 comments · Fixed by #35
Closed

Comments

@Peddinti-Sriram-Bharadwaj
Copy link
Contributor

Describe the bug
On Safari Browser, the dark mode icon/light mode is not visible.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '.https://design-deck.vercel.app/#'
  2. Click on '....'
  3. Scroll down to 'Home'
  4. See error

Expected behavior
Dark mode/light mode icons visible on all browsers.

Screenshots
image
image

Desktop (please complete the following information):

  • OS: Macos [e.g. iOS]
  • Browser Safari[e.g. chrome, safari]
  • Version 18.1[e.g. 22]

Smartphone (please complete the following information):

  • Device: NA
  • OS: NA
  • Browser NA
  • Version NA

Additional context
Add any other context about the problem here.
furthermore, dark mode is not working as intended on multiple pages. I would like two work on them as well, by raising Issues.
please assign me to this issue, so that I can fix the browser specific UI issue.
request to please add the hactoberfest and gssoc-ext labels and a level-2 contribution labels as well.

Copy link

github-actions bot commented Oct 4, 2024

👋 Thank you for raising an issue! We appreciate your effort in helping us improve. Our team will review it shortly. Stay tuned!

@jahnvisahni31
Copy link
Owner

done assigned you this issue

@Peddinti-Sriram-Bharadwaj
Copy link
Contributor Author

Thank you, I shall start working on this

jahnvisahni31 added a commit that referenced this issue Oct 5, 2024
fixed issue #24 and #25:- ThemeSwitcher toggle button now works as intended on all devices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment