Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in setup script #3

Open
smac89 opened this issue Mar 18, 2024 · 0 comments · May be fixed by #4
Open

Bugs in setup script #3

smac89 opened this issue Mar 18, 2024 · 0 comments · May be fixed by #4

Comments

@smac89
Copy link

smac89 commented Mar 18, 2024

  1. If there are several connected disks, each with an EFI partition, the setup script may end up picking the wrong one to install the theme into. Ideally, it should be safe to break out of the loop once we find a valid ESP.
  2. The findmnt command does not return empty output even if "$ESP" is empty. In this case, findmnt will default to printing information about / mount. This also affects people who have several EFI disks, even if none are mounted.
smac89 added a commit to smac89/refind-theme-nord that referenced this issue Mar 18, 2024
@smac89
Fix bug with finding ESP in setup.sh
fe38f21 
Fixes jaltuna#3
@smac89 smac89 linked a pull request Mar 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug with finding ESP in setup.sh smac89/refind-theme-nord
1 participant
@smac89