From 6a19a6b672e5c2833107981db11300c490da5796 Mon Sep 17 00:00:00 2001 From: SoloTel Date: Thu, 14 Feb 2019 17:17:19 +0000 Subject: [PATCH] Fallback to package.Id if title not available If a package title is not set in the nuspec tile, normal user installs work fine, but the installation folder set in the Wix for the machine wide installer becomes "%programfiles%\ Installer\ .... " - note the space where the title should be. When the folder is created this space is silently removed by the operating system, however in the registry Run entry, the space is present. As the name in the registry and the actual path don't match, the machine wide installer never runs. This change means that the installer falls back to using the id if the name is not available --- src/Update/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Update/Program.cs b/src/Update/Program.cs index 3a026a291..b1559b4e2 100644 --- a/src/Update/Program.cs +++ b/src/Update/Program.cs @@ -732,7 +732,7 @@ static async Task createMsiPackage(string setupExe, IPackage package) var templateText = File.ReadAllText(Path.Combine(pathToWix, "template.wxs")); var templateData = new Dictionary { { "Id", package.Id }, - { "Title", package.Title }, + { "Title", package.Title ?? package.Id }, { "Author", company }, { "Version", Regex.Replace(package.Version.ToString(), @"-.*$", "") }, { "Summary", package.Summary ?? package.Description ?? package.Id },