Skip to content

Latest commit

 

History

History
12 lines (9 loc) · 1.51 KB

CONTRIBUTION_GUIDELINES.rdoc

File metadata and controls

12 lines (9 loc) · 1.51 KB
Raw

We’re using GitHub and Lighthouse, and we’ve been getting any combination of github pull requests, Lighthouse tickets, patches, emails, etc. We need to normalize this workflow to make sure we don’t miss any fixes.

  • Make sure you’re accessing the source from the official repository.

  • We prefer git branches over patches, but we can take either.

  • If you’re using git, please make a branch for each separate contribution. We can cherry pick your commits, but pulling from a branch is easier.

  • If you’re submitting patches, please cut each fix or feature into a separate patch.

  • There should be a Lighthouse ticket for any submission. If you’ve found a bug and want to fix it, open a new ticket at the same time.

  • We’ve got github/lighthouse integration going, so you can update tickets when you commit. This blog post explains the commit options pretty well.

  • Please don’t send pull requests Just update the lighthouse ticket with the url for your fix (or attach the patch) when it’s ready. The github pull requests pretty much get dropped on the floor until someone with commit rights notices them in the mailbox.

  • Contributions without tests won’t be accepted. The file /test/README explains the testing system pretty thoroughly.