Skip to content

Replaced urllib with requests api to fix cloudfare cookie error. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replaced urllib with requests api to fix cloudfare cookie error. #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c29ed0
Replaced urllib with requests api to fix cloudfare cookie error.
Dec 4, 2014
ab3ea75
Ignore ascii conversion errors
Dec 4, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gamesdb/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import urllib
import requests
import xml.etree.ElementTree as ET
from urlutils import urlencode_no_plus

Expand Down Expand Up @@ -60,10 +60,10 @@ def make_call(api_url, query_args=None):
# APIException, passing forward the pages contents (which generally gives some indication of the error.
if query_args is not None:
get_params = urlencode_no_plus.urlencode_no_plus(query_args)
response = urllib.urlopen(api_url+'%s' % get_params)
response = requests.get(api_url+'%s' % get_params)
else:
response = urllib.urlopen(api_url)
page = response.read()
response = requests.get(api_url)
page = response.text.encode('ascii', 'ignore')

# Make sure the XML Parser doesn't return a ParsError. If it does, it's probably and API Issue, so raise an
# exception, printing the response from the API call.
Expand Down