From 17d61955128242761161dab04d839ad35b0222f4 Mon Sep 17 00:00:00 2001 From: poco0317 Date: Mon, 26 Nov 2018 18:41:05 -0600 Subject: [PATCH] Fix crash when grabbing offset vectors for old replays --- src/PlayerStageStats.cpp | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/PlayerStageStats.cpp b/src/PlayerStageStats.cpp index ec2028ae78..5106dccb0c 100644 --- a/src/PlayerStageStats.cpp +++ b/src/PlayerStageStats.cpp @@ -1040,9 +1040,16 @@ LuaFunction(GetGradeFromPercent, GetGradeFromPercent(FArg(1))) auto& offs = p->m_vOffsetVector; auto& type = p->m_vTapNoteTypeVector; vector doot; - for (size_t i = 0; i < offs.size(); ++i) - if (type[i] != TapNoteType_Mine) + // type would not be empty in Full Replays (> v0.60) + if (!type.empty()) { + for (size_t i = 0; i < offs.size(); ++i) + if (type[i] != TapNoteType_Mine) + doot.emplace_back(offs[i] * 1000); + } else { + // But type is empty if the replay is old :( + for (size_t i = 0; i < offs.size(); ++i) doot.emplace_back(offs[i] * 1000); + } LuaHelpers::CreateTableFromArray(doot, L); return 1; }