use a conversion map to reconcile keys rather than looping through things like an idiot

Author: MinaciousGrace

src/SongManager.cpp

@@ -361,12 +361,8 @@ string SongManager::ReconcileBustedKeys(const string& ck) {
 	if (StepsByKey.count(ck))
 		return ck;
 
-	FOREACHUM(string, Steps*, StepsByKey, i)
-		for (auto& n : i->second->bustedkeys)
-			if (ck == n) {
-				LOG->Trace("Reconciled key for %s to %s", ck.c_str(), i->second->GetChartKey().c_str());
-				return i->second->GetChartKey();
-			}
+	if (keyconversionmap.count(ck))
+		return keyconversionmap[ck];
 	return ck;
 }
 

src/SongManager.h

@@ -194,6 +194,7 @@ class SongManager
 	string activeplaylist;
 	string playlistcourse;
 	string ReconcileBustedKeys(const string& ck);
+	map<string, string> keyconversionmap;
 
 	map<string, vector<Song*>> groupderps;
 protected:

src/Steps.cpp

@@ -386,8 +386,7 @@ void Steps::CalcEtternaMetadata() {
 	stuffnthings = MinaSDCalc(GetNoteData().SerializeNoteData(etaner), GetNoteData().GetNumTracks(), 0.93f, 1.f, GetTimingData()->HasWarps());
 	ChartKey = GenerateChartKey(*m_pNoteData, GetTimingData());
 	for (int i = 0; i < 8; ++i)
-		bustedkeys.emplace_back(GenerateBustedChartKey(*m_pNoteData, GetTimingData(), i));
-
+		SONGMAN->keyconversionmap.emplace(GenerateBustedChartKey(*m_pNoteData, GetTimingData(), i), ChartKey);
 
 	m_pNoteData->UnsetNerv();
 	m_pNoteData->UnsetSerializedNoteData();