Skip to content

Commit 913b0d8

Browse files
committed
Band-aid Replay issue allowing Player to tap any note that exists
basically setting this to -1 allows the Step function to tap anything it wants since the score we give that Step is according to the ReplayData. So if it fails for some reason, it scores a possibly incorrect and possibly otherwise impossible tap. This causes Replays to look very bad. A regular example was found and this solves that. The other example is itsjake's 1h54m js 1.4x. That case is still not solved, but plays back much better using this change.
1 parent 2a09f35 commit 913b0d8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Etterna/Actor/Gameplay/PlayerReplay.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ PlayerReplay::Update(float fDeltaTime)
227227
for (TapReplayResult& trr : trrVector) {
228228
// LOG->Trace("\tPassing row %d pressed on %d", iSongRow,
229229
// trr.row);
230-
Step(trr.track, -1, now, false, false, 0.f, trr.row);
230+
Step(trr.track, trr.row, now, false, false, 0.f, trr.row);
231231
}
232232
}
233233
}

0 commit comments

Comments
 (0)