Rename GameplayReplay functions in more sane ways

i did this to confuse people and make them thing pausing was possible haha (it is though please dont tell them)

Author: poco0317

Themes/Til Death/BGAnimations/ScreenGameplay overlay/WifeJudgmentSpotting.lua

@@ -689,7 +689,7 @@ local replaySlider =
 		-- Change to onValueChangeEnd if this
 		-- lags too much
 		onValueChange = function(val)
-			SCREENMAN:GetTopScreen():SetReplayPosition(val)
+			SCREENMAN:GetTopScreen():SetSongPosition(val)
 		end
 	} or
 	Def.Actor {}

Themes/Til Death/BGAnimations/ScreenGameplay overlay/replayscrolling.lua

@@ -92,25 +92,25 @@ scroller =
 	end,
 	ReplayScrollCommand = function(self)
 		newpos = getNewSongPos()
-		SCREENMAN:GetTopScreen():SetReplayPosition(newpos)
+		SCREENMAN:GetTopScreen():SetSongPosition(newpos)
 	end,
 	ReplayRateCommand = function(self)
 		newrate = getNewRate()
-		givenrate = SCREENMAN:GetTopScreen():SetReplayRate(newrate)
+		givenrate = SCREENMAN:GetTopScreen():SetRate(newrate)
 		if givenrate ~= nil then
 			realnewrate = notShit.round(givenrate, 3)
 		--SCREENMAN:SystemMessage(string.format("Set rate to %f", realnewrate))
 		end
 	end,
 	ReplayPauseToggleCommand = function(self)
-		SCREENMAN:GetTopScreen():ToggleReplayPause()
+		SCREENMAN:GetTopScreen():TogglePause()
 	end,
 	ReplayBookmarkSetCommand = function(self)
 		position = SCREENMAN:GetTopScreen():GetSongPosition()
-		SCREENMAN:GetTopScreen():SetReplayBookmark(position)
+		SCREENMAN:GetTopScreen():SetBookmark(position)
 	end,
 	ReplayBookmarkGotoCommand = function(self)
-		SCREENMAN:GetTopScreen():JumpToReplayBookmark()
+		SCREENMAN:GetTopScreen():JumpToBookmark()
 	end,
 }
 local span = 50
@@ -147,21 +147,21 @@ scroller[#scroller + 1] =
 		button(
 			"Pause",
 			function(self)
-				SCREENMAN:GetTopScreen():ToggleReplayPause()
+				SCREENMAN:GetTopScreen():TogglePause()
 				local paused = GAMESTATE:IsPaused()
 				self.label.actor:settext(paused and "Play" or "Pause")
 			end
 		),
 		button(
 			"Fast Forward",
 			function()
-				SCREENMAN:GetTopScreen():SetReplayPosition(SCREENMAN:GetTopScreen():GetSongPosition() + 5)
+				SCREENMAN:GetTopScreen():SetSongPosition(SCREENMAN:GetTopScreen():GetSongPosition() + 5)
 			end
 		),
 		button(
 			"Rewind",
 			function()
-				SCREENMAN:GetTopScreen():SetReplayPosition(SCREENMAN:GetTopScreen():GetSongPosition() - 5)
+				SCREENMAN:GetTopScreen():SetSongPosition(SCREENMAN:GetTopScreen():GetSongPosition() - 5)
 			end
 		),
 	}

src/Etterna/Screen/Gameplay/ScreenGameplayReplay.cpp

@@ -384,7 +384,7 @@ ScreenGameplayReplay::SetSongPosition(float newPositionSeconds)
 }
 
 void
-ScreenGameplayReplay::ToggleReplayPause()
+ScreenGameplayReplay::TogglePause()
 {
 	// True if we were paused before now
 	bool oldPause = GAMESTATE->GetPaused();
@@ -529,14 +529,14 @@ ScreenGameplayReplay::ToggleReplayPause()
 class LunaScreenGameplayReplay : public Luna<ScreenGameplayReplay>
 {
   public:
-	static int SetReplayPosition(T* p, lua_State* L)
+	static int SetSongPosition(T* p, lua_State* L)
 	{
 		float newpos = FArg(1);
 		if (GAMESTATE->GetPaused())
 			p->SetSongPosition(newpos);
 		return 0;
 	}
-	static int SetReplayRate(T* p, lua_State* L)
+	static int SetRate(T* p, lua_State* L)
 	{
 		float newrate = FArg(1);
 		if (!GAMESTATE->GetPaused()) {
@@ -546,18 +546,18 @@ class LunaScreenGameplayReplay : public Luna<ScreenGameplayReplay>
 		lua_pushnumber(L, p->SetRate(newrate));
 		return 1;
 	}
-	static int ToggleReplayPause(T* p, lua_State* L)
+	static int TogglePause(T* p, lua_State* L)
 	{
-		p->ToggleReplayPause();
+		p->TogglePause();
 		return 0;
 	}
-	static int SetReplayBookmark(T* p, lua_State* L)
+	static int SetBookmark(T* p, lua_State* L)
 	{
 		float position = FArg(1);
 		p->m_fReplayBookmarkSeconds = position;
 		return 0;
 	}
-	static int JumpToReplayBookmark(T* p, lua_State* L)
+	static int JumpToBookmark(T* p, lua_State* L)
 	{
 		if (GAMESTATE->GetPaused()) {
 			p->SetSongPosition(p->m_fReplayBookmarkSeconds);
@@ -568,11 +568,11 @@ class LunaScreenGameplayReplay : public Luna<ScreenGameplayReplay>
 
 	LunaScreenGameplayReplay()
 	{
-		ADD_METHOD(SetReplayPosition);
-		ADD_METHOD(SetReplayRate);
-		ADD_METHOD(ToggleReplayPause);
-		ADD_METHOD(SetReplayBookmark);
-		ADD_METHOD(JumpToReplayBookmark);
+		ADD_METHOD(SetSongPosition);
+		ADD_METHOD(SetRate);
+		ADD_METHOD(TogglePause);
+		ADD_METHOD(SetBookmark);
+		ADD_METHOD(JumpToBookmark);
 	}
 };
 

src/Etterna/Screen/Gameplay/ScreenGameplayReplay.h

@@ -25,7 +25,7 @@ class ScreenGameplayReplay : public ScreenGameplay
 	// Move the current position of the song in the middle of gameplay
 	void SetSongPosition(float newPositionSeconds);
 	// Toggle pause
-	void ToggleReplayPause();
+	void TogglePause();
 	float m_fReplayBookmarkSeconds;
 
   protected: