forked from FormidableLabs/radium
-
Notifications
You must be signed in to change notification settings - Fork 1
/
Copy pathresolve-styles-test.js
767 lines (616 loc) · 23 KB
/
resolve-styles-test.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
import React from 'react';
import MouseUpListener from 'plugins/mouse-up-listener';
import objectAssign from 'object-assign';
const resolveStyles = require('inject-loader!resolve-styles')({
exenv: require('__mocks__/exenv')
}).default;
const genComponent = function(initialState = {}) {
return {
setState: sinon.spy(function(newState) {
objectAssign(this.state, newState);
}),
state: initialState,
_radiumIsMounted: true
};
};
// http://stackoverflow.com/a/25395068/13932
const permutate = function(arr) {
const permutations = [];
if (arr.length === 1) {
return [arr];
}
for (let i = 0; i < arr.length; i++) {
const subPerms = permutate(arr.slice(0, i).concat(arr.slice(i + 1)));
for (let j = 0; j < subPerms.length; j++) {
subPerms[j].unshift(arr[i]);
permutations.push(subPerms[j]);
}
}
return permutations;
};
const getChildrenArray = function(children) {
const childrenArray = [];
React.Children.forEach(children, function(child) {
childrenArray.push(child);
});
return childrenArray;
};
describe('resolveStyles', () => {
beforeEach(() => {
MouseUpListener.subscribe = sinon.spy();
});
describe('no-op behavior', () => {
it('handles null rendered element', () => {
const component = genComponent();
resolveStyles(component, null);
});
it("doesn't explode", () => {
const component = genComponent();
const renderedElement = <div />;
const result = resolveStyles(component, renderedElement).element;
expect(result).to.equal(renderedElement);
expect(result.props).to.equal(renderedElement.props);
});
it('passes through normal style objects', () => {
const component = genComponent();
const renderedElement = <div style={{color: 'blue'}} />;
const result = resolveStyles(component, renderedElement).element;
expect(result.props.style).to.deep.equal(renderedElement.props.style);
});
it('passes through normal style objects of children', () => {
const component = genComponent();
const style = {color: 'blue'};
const renderedElement = (
<div>
<div style={style} />
</div>
);
const result = resolveStyles(component, renderedElement).element;
const children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.deep.equal(style);
});
it("doesn't wrap string children in spans", () => {
const component = genComponent();
const renderedElement = <div>Hello</div>;
const result = resolveStyles(component, renderedElement).element;
expect(result.props.children).to.equal('Hello');
});
it("doesn't wrap number children in spans", () => {
const component = genComponent();
const renderedElement = <div>{88347}</div>;
const result = resolveStyles(component, renderedElement).element;
expect(result.props.children).to.equal(88347);
});
it('ignores invalid children', () => {
const component = genComponent();
// JSX won't let this through, so do it with a plain object instead
const renderedElement = {
props: {
children: [null]
}
};
const result = resolveStyles(component, renderedElement).element;
const children = getChildrenArray(result.props.children);
expect(children[0]).to.be.undefined;
});
it('only processes an element once', () => {
sinon.spy(React, 'cloneElement');
const component = genComponent();
const renderedElement = (
<div style={[{background: 'white'}, {color: 'blue'}]} />
);
let result = resolveStyles(component, renderedElement).element;
result = resolveStyles(component, result).element;
expect(result.props.style).to.deep.equal({
background: 'white',
color: 'blue'
});
expect(React.cloneElement).to.have.been.calledOnce;
React.cloneElement.restore();
});
});
describe('style array', () => {
it('merges an array of style objects', () => {
const component = genComponent();
const renderedElement = (
<div style={[{background: 'white'}, {color: 'blue'}]} />
);
const result = resolveStyles(component, renderedElement).element;
expect(result.props.style).to.deep.equal({
background: 'white',
color: 'blue'
});
});
it('skips falsy and non-object entries', () => {
const component = genComponent();
const renderedElement = (
<div
style={[
{background: 'white'},
false,
null,
''.someUndefinedVar,
'',
[1, 2, 3],
{color: 'blue'}
]}
/>
);
const result = resolveStyles(component, renderedElement).element;
expect(result.props.style).to.deep.equal({
background: 'white',
color: 'blue'
});
});
it('overwrites earlier styles with later ones', () => {
const component = genComponent();
const renderedElement = (
<div style={[{background: 'white'}, {background: 'blue'}]} />
);
const result = resolveStyles(component, renderedElement).element;
expect(result.props.style).to.deep.equal({
background: 'blue'
});
});
it('merges nested special styles', () => {
const component = genComponent();
const renderedElement = (
<div
style={[
{':hover': {background: 'white'}},
{':hover': {color: 'blue'}}
]}
/>
);
let result = resolveStyles(component, renderedElement).element;
result.props.onMouseEnter();
result = resolveStyles(component, renderedElement).element;
expect(result.props.style).to.deep.equal({
background: 'white',
color: 'blue'
});
});
});
const createPseduoStyleTests = function(
pseudo,
onHandlerName,
offHandlerName
) {
it('strips special styles if not applied', () => {
const component = genComponent();
const style = {background: 'blue'};
style[':' + pseudo] = {background: 'red'};
const renderedElement = <div style={style} />;
const result = resolveStyles(component, renderedElement).element;
expect(result.props.style).to.deep.equal({background: 'blue'});
});
it('adds appropriate handlers for ' + pseudo + ' styles', () => {
const component = genComponent();
const style = {background: 'blue'};
style[':' + pseudo] = {background: 'red'};
const renderedElement = <div style={style} />;
const result = resolveStyles(component, renderedElement).element;
expect(typeof result.props[onHandlerName]).to.equal('function');
if (offHandlerName) {
expect(typeof result.props[offHandlerName]).to.equal('function');
}
});
it('adds ' + pseudo + ' styles ' + onHandlerName, () => {
const component = genComponent();
const style = {background: 'blue'};
style[':' + pseudo] = {background: 'red'};
const renderedElement = <div style={style} />;
let result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal('blue');
result.props[onHandlerName]();
expect(component.setState).to.have.been.called;
// Must create a new renderedElement each time, same as React, since
// resolveStyles mutates
result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal('red');
});
it('throws if multiple elements have the same key', () => {
const component = genComponent();
const style = {background: 'blue'};
style[':' + pseudo] = {background: 'red'};
// Use ref instead of key here because React.Children.map will discard
// the duplicate keyed element.
const renderedElement = (
<div>
<div ref="foo" style={style} />
<div ref="foo" style={style} />
</div>
);
expect(() => {
resolveStyles(component, renderedElement);
}).to.throw();
});
it('throws if multiple elements have no key', () => {
const component = genComponent();
const style = {background: 'blue'};
style[':' + pseudo] = {background: 'red'};
const renderedElement = (
<div>
<div style={style} />
<div style={style} />
</div>
);
expect(() => {
resolveStyles(component, renderedElement);
}).to.throw();
});
it('adds ' + pseudo + ' styles to correct element by key', () => {
const component = genComponent();
const style = {background: 'blue'};
style[':' + pseudo] = {background: 'red'};
const renderedElement = (
<div>
<div key="foo" />
<div key="bar" style={style} />
</div>
);
let result = resolveStyles(component, renderedElement).element;
let children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.be.undefined;
expect(children[1].props.style.background).to.equal('blue');
children[1].props[onHandlerName]();
result = resolveStyles(component, renderedElement).element;
children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.be.undefined;
expect(children[1].props.style.background).to.equal('red');
});
it('adds ' + pseudo + ' styles to correct element by ref', () => {
const component = genComponent();
const style = {background: 'blue'};
style[':' + pseudo] = {background: 'red'};
const renderedElement = (
<div>
<div ref="foo" />
<div ref="bar" style={style} />
</div>
);
let result = resolveStyles(component, renderedElement).element;
let children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.be.undefined;
expect(children[1].props.style.background).to.equal('blue');
children[1].props[onHandlerName]();
result = resolveStyles(component, renderedElement).element;
children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.be.undefined;
expect(children[1].props.style.background).to.equal('red');
});
if (offHandlerName) {
it('removes ' + pseudo + ' styles ' + offHandlerName, () => {
const component = genComponent();
const style = {background: 'blue'};
style[':' + pseudo] = {background: 'red'};
const renderedElement = <div style={style} />;
let result = resolveStyles(component, renderedElement).element;
result.props[onHandlerName]();
result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal('red');
result.props[offHandlerName]();
expect(component.setState).to.have.been.called;
result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal('blue');
});
it("doesn't mutate state", () => {
const component = genComponent();
const style = {background: 'blue'};
style[':' + pseudo] = {background: 'red'};
const renderedElement = <div style={style} />;
let result = resolveStyles(component, renderedElement).element;
// Capturing a reference to the existing state is enough, since Radium
// MUST return a new copy for shouldComponentUpdate.
let previousState = component.state._radiumStyleState;
result.props[onHandlerName]();
// If they are still equal here, that means we mutated the existing
// state, which will break shouldComponentUpdate.
expect(component.state._radiumStyleState).not.to.equal(previousState);
result = resolveStyles(component, renderedElement).element;
previousState = component.state._radiumStyleState;
result.props[offHandlerName]();
expect(component.state._radiumStyleState).not.to.equal(previousState);
});
}
};
describe(':hover', () => {
createPseduoStyleTests('hover', 'onMouseEnter', 'onMouseLeave');
});
describe(':focus', () => {
createPseduoStyleTests('focus', 'onFocus', 'onBlur');
});
describe(':active', () => {
createPseduoStyleTests('active', 'onMouseDown');
it('subscribes to mouse up listener', () => {
const component = genComponent();
const renderedElement = <div style={{':active': {background: 'red'}}} />;
resolveStyles(component, renderedElement);
expect(MouseUpListener.subscribe).to.have.been.called;
});
it('adds active styles on mouse down', () => {
const component = genComponent();
const style = {
background: 'blue',
':active': {background: 'red'}
};
const renderedElement = <div style={style} />;
let result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal('blue');
result.props.onMouseDown();
result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal('red');
});
it('removes active styles on mouse up', () => {
const component = genComponent();
const style = {
background: 'blue',
':active': {background: 'red'}
};
const renderedElement = <div style={style} />;
let result = resolveStyles(component, renderedElement).element;
result.props.onMouseDown();
result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal('red');
// tigger global mouseup handler
MouseUpListener.subscribe.firstCall.args[0]();
result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal('blue');
});
it('ignores mouse up if no active styles', () => {
const component = genComponent();
const style = {
background: 'blue',
':active': {background: 'red'}
};
const renderedElement = <div style={style} />;
let result = resolveStyles(component, renderedElement).element;
result.props.onMouseDown();
// tigger global mouseup handler
MouseUpListener.subscribe.firstCall.args[0]();
MouseUpListener.subscribe.firstCall.args[0]();
result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal('blue');
});
it('calls existing onMouseDown handler', () => {
const component = genComponent();
const style = {
background: 'blue',
':active': {background: 'red'}
};
const originalOnMouseDown = sinon.spy();
const renderedElement = (
<div onMouseDown={originalOnMouseDown} style={style} />
);
let result = resolveStyles(component, renderedElement).element;
result.props.onMouseDown();
expect(originalOnMouseDown).to.have.been.called;
result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal('red');
});
});
describe('multiple states triggered at once', () => {
describe('applies pseudo styles in the defined order', () => {
const component = genComponent();
const stylePermutations = permutate([
{name: ':active', style: {background: 'red'}},
{name: ':focus', style: {background: 'yellow'}},
{name: ':hover', style: {background: 'blue'}}
]);
const onHandlerPermutations = permutate([
'onFocus',
'onMouseDown',
'onMouseEnter'
]);
const createMultiPseudoTest = function(pseudoStyles, onHandlers) {
const name =
'applies pseudo styles in the defined order: ' +
pseudoStyles.map(pseudo => pseudo.name).join(', ') +
' when handlers called in order: ' +
onHandlers.join(', ');
it(name, () => {
const style = {};
pseudoStyles.forEach(pseudo => {
style[pseudo.name] = pseudo.style;
});
const renderedElement = <div style={style} />;
let result = resolveStyles(component, renderedElement).element;
onHandlers.forEach(onHandler => {
result.props[onHandler]();
});
result = resolveStyles(component, renderedElement).element;
expect(result.props.style.background).to.equal(
pseudoStyles[pseudoStyles.length - 1].style.background
);
});
};
stylePermutations.forEach(pseudoStyles => {
onHandlerPermutations.forEach(onHandlers => {
createMultiPseudoTest(pseudoStyles, onHandlers);
});
});
});
});
describe('when elements are unmounted', () => {
it('returns an extraStateKeyMap with keys of unmounted elements', () => {
const initialState = {
_radiumStyleState: {
mountedDiv: {},
unmountedDiv: {}
}
};
const component = genComponent(initialState);
const renderedElement = (
<div>
<div ref="mountedDiv" />
</div>
);
const result = resolveStyles(component, renderedElement).extraStateKeyMap;
expect(result).to.deep.equal({unmountedDiv: true});
});
});
describe('React.Children.only', () => {
it("doesn't break React.Children.only", () => {
const component = genComponent();
const renderedElement = (
<div>
<span />
</div>
);
const result = resolveStyles(component, renderedElement).element;
expect(React.Children.only(result.props.children)).to.be.ok;
});
it("doesn't break when only child isn't ReactElement", () => {
const component = genComponent();
const renderedElement = <div>Foo</div>;
resolveStyles(component, renderedElement);
});
});
describe('ReactComponentElement children', () => {
it("doesn't resolve ReactComponentElement children", () => {
const component = genComponent();
class CustomComponent extends React.Component {}
const style = {':hover': {}};
const renderedElement = (
<div>
<CustomComponent style={style} />
</div>
);
const result = resolveStyles(component, renderedElement).element;
const children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.deep.equal(style);
});
it('resolves ReactDOMElement children of ReactComponentElements', () => {
const component = genComponent();
class CustomComponent extends React.Component {}
const style = [{background: 'white'}, {color: 'blue'}];
const renderedElement = (
<div style={style}>
<CustomComponent style={style}>
<div style={style} />
</CustomComponent>
</div>
);
const result = resolveStyles(component, renderedElement).element;
expect(result.props.style).to.deep.equal({
background: 'white',
color: 'blue'
});
const children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.deep.equal(style);
const componentChildren = getChildrenArray(children[0].props.children);
expect(componentChildren[0].props.style).to.deep.equal({
background: 'white',
color: 'blue'
});
});
});
describe('disabled', () => {
it('discards interaction styles if element is disabled', () => {
const component = genComponent();
const style = {background: 'blue'};
style[':hover'] = {background: 'red'};
const renderedElement = (
<div>
<div ref="foo" />
<div disabled ref="bar" style={style} />
</div>
);
let result = resolveStyles(component, renderedElement).element;
let children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.be.undefined;
expect(children[1].props.style.background).to.equal('blue');
children[1].props.onMouseEnter();
result = resolveStyles(component, renderedElement).element;
children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.be.undefined;
expect(children[1].props.style.background).to.equal('blue');
});
it('styles according to :disabled style if element is disabled', () => {
const component = genComponent();
const style = {background: 'blue'};
style[':hover'] = {background: 'red'};
style[':disabled'] = {background: 'yellow'};
const renderedElement = (
<div>
<div ref="foo" />
<div disabled ref="bar" style={style} />
</div>
);
let result = resolveStyles(component, renderedElement).element;
let children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.be.undefined;
expect(children[1].props.style.background).to.equal('yellow');
children[1].props.onMouseEnter();
result = resolveStyles(component, renderedElement).element;
children = getChildrenArray(result.props.children);
expect(children[0].props.style).to.be.undefined;
expect(children[1].props.style.background).to.equal('yellow');
});
});
/* eslint-disable no-console */
describe('warnings', () => {
beforeEach(() => {
sinon.stub(console, 'warn');
});
afterEach(() => {
console.warn.restore();
process.env.NODE_ENV = null;
});
it('warns when mixing longhand and shorthand properties', () => {
const component = genComponent();
const renderedElement = (
<div
style={{
border: '1px solid black',
borderWidth: '0 1px 1px 1px'
}}
/>
);
resolveStyles(component, renderedElement);
expect(console.warn).to.have.been.called;
expect(
console.warn.firstCall.args[0].indexOf('border')
).to.be.greaterThan(0);
});
it('warns when mixing longhand and shorthand properties in nested styles', () => {
const component = genComponent();
const renderedElement = (
<div
style={{
':hover': {
border: '1px solid black',
borderWidth: '0 1px 1px 1px'
}
}}
/>
);
resolveStyles(component, renderedElement);
expect(console.warn).to.have.been.called;
expect(
console.warn.firstCall.args[0].indexOf('border')
).to.be.greaterThan(0);
});
it('does not warn when mixing border and borderRadius', () => {
const component = genComponent();
const renderedElement = (
<div
style={{
border: '1px solid black',
borderRadius: '5px'
}}
/>
);
resolveStyles(component, renderedElement);
expect(console.warn).to.not.have.been.called;
});
it('does not throw when passed a falsy entry value', () => {
const component = genComponent();
const renderedElement = <div style={{height: null}} />;
expect(() => {
resolveStyles(component, renderedElement);
}).to.not.throw();
});
});
/* eslint-enable no-console */
});