test(predicates): Corrected the assertions around error handling

Author: jan-molak

spec/predicates/and.spec.ts

@@ -23,7 +23,7 @@ describe('predicates', () => {
         }
 
         it('ensures that all the predicates are met', () => {
-            expect(new InvestmentLengthInYears(10)).to.not.throw;      // tslint:disable-line:no-unused-expression
+            expect(() => new InvestmentLengthInYears(10)).to.not.throw;      // tslint:disable-line:no-unused-expression
         });
 
         given(

spec/predicates/hasLengthOf.spec.ts

@@ -20,7 +20,7 @@ describe('predicates', () => {
             }
 
             it('ensures that the value has a correct length', () => {
-                expect(new Password('P@ssw0rd')).to.not.throw;                   // tslint:disable-line:no-unused-expression
+                expect(() => new Password('P@ssw0rd')).to.not.throw;         // tslint:disable-line:no-unused-expression
             });
 
             given(
@@ -43,7 +43,7 @@ describe('predicates', () => {
             }
 
             it('ensures that the value has a correct length', () => {
-                expect(new Collection(['a', 'b'])).to.not.throw;             // tslint:disable-line:no-unused-expression
+                expect(() => new Collection(['a', 'b'])).to.not.throw;       // tslint:disable-line:no-unused-expression
             });
 
             given(

spec/predicates/isArray.spec.ts

@@ -18,7 +18,7 @@ describe('predicates', () => {
         }
 
         it('ensures that the argument is an array', () => {
-            expect(new Strings(['lorem', 'ipsum'])).to.not.throw;          // tslint:disable-line:no-unused-expression
+            expect(() => new Strings(['lorem', 'ipsum'])).to.not.throw;      // tslint:disable-line:no-unused-expression
         });
 
         given(

spec/predicates/isBoolean.spec.ts

@@ -18,7 +18,7 @@ describe('predicates', () => {
         }
 
         it('ensures that the argument is a boolean value', () => {
-            expect(new MarketingOptIn(false)).to.not.throw;                  // tslint:disable-line:no-unused-expression
+            expect(() => new MarketingOptIn(false)).to.not.throw;            // tslint:disable-line:no-unused-expression
         });
 
         given(

spec/predicates/isDefined.spec.ts

@@ -17,7 +17,7 @@ describe('predicates', () => {
         }
 
         it('ensures that the value is defined', () => {
-            expect(() => new UserName('Jan')).to.not.throw;                            // tslint:disable-line:no-unused-expression
+            expect(() => new UserName('Jan')).to.not.throw;                  // tslint:disable-line:no-unused-expression
         });
 
         given<any>(
@@ -26,7 +26,7 @@ describe('predicates', () => {
             true,
             false,
         ).it('works for any defined value, even the "falsy" ones', (value: any) => {
-            expect(new UserName(value)).to.not.throw;                            // tslint:disable-line:no-unused-expression
+            expect(() => new UserName(value)).to.not.throw;                  // tslint:disable-line:no-unused-expression
         });
     });
 });

spec/predicates/isEqualTo.spec.ts

@@ -29,7 +29,8 @@ describe('predicates', () => {
 
                 const upgradeOwnAccount = new UpgradeAccount(loggedInUser);
 
-                expect(accounts.handle(upgradeOwnAccount)).to.not.throw;     // tslint:disable-line:no-unused-expression
+                // tslint:disable-next-line:no-unused-expression
+                expect(() => accounts.handle(upgradeOwnAccount)).to.not.throw;
             });
 
             it('complains if the objects are not identical by value', () => {
@@ -58,7 +59,8 @@ describe('predicates', () => {
                 [],
             ).
             it('ensures they are equal', (value: any) => {
-                expect(ensure('Val', value, isEqualTo(value))).to.not.throw;  // tslint:disable-line:no-unused-expression
+                // tslint:disable-next-line:no-unused-expression
+                expect(() => ensure('Val', value, isEqualTo(value))).to.not.throw;
             });
 
             given(

spec/predicates/isGreaterThan.spec.ts

@@ -17,7 +17,7 @@ describe('predicates', () => {
         }
 
         it('ensures that the argument is greater than a specified number', () => {
-            expect(new InvestmentLength(5)).to.not.throw;                    // tslint:disable-line:no-unused-expression
+            expect(() => new InvestmentLength(5)).to.not.throw;              // tslint:disable-line:no-unused-expression
         });
 
         it('complains if the argument is more than a specified number', () => {

spec/predicates/isGreaterThanOrEqualTo.spec.ts

@@ -18,7 +18,7 @@ describe('predicates', () => {
 
         given(0, 1).
         it('ensures that the argument is greater than or equal to a specified number', (value: number) => {
-            expect(new InvestmentLength(value)).to.not.throw;                // tslint:disable-line:no-unused-expression
+            expect(() => new InvestmentLength(value)).to.not.throw;          // tslint:disable-line:no-unused-expression
         });
 
         it('complains if the argument is less than the lower bound', () => {

spec/predicates/isInRange.spec.ts

@@ -19,7 +19,7 @@ describe('predicates', () => {
 
         given(1, 2, 3, 4, 5).
         it('ensures that the value is within the range specified', (value: number) => {
-            expect(new InvestmentLength(value)).to.not.throw;                // tslint:disable-line:no-unused-expression
+            expect(() => new InvestmentLength(value)).to.not.throw;          // tslint:disable-line:no-unused-expression
         });
 
         it('complains if the value is lower than the lower bound', () => {

spec/predicates/isInteger.spec.ts

@@ -17,7 +17,7 @@ describe('predicates', () => {
         }
 
         it('ensures that the argument in an integer', () => {
-            expect(new AgeInYears(42)).to.not.throw;                         // tslint:disable-line:no-unused-expression
+            expect(() => new AgeInYears(42)).to.not.throw;                   // tslint:disable-line:no-unused-expression
         });
 
         given(

spec/predicates/isLessThan.spec.ts

@@ -17,7 +17,7 @@ describe('predicates', () => {
         }
 
         it('ensures that the argument is less than a specified number', () => {
-            expect(new InvestmentLength(5)).to.not.throw;                    // tslint:disable-line:no-unused-expression
+            expect(() => new InvestmentLength(5)).to.not.throw;              // tslint:disable-line:no-unused-expression
         });
 
         it('complains if the argument is more than a specified number', () => {

spec/predicates/isLessThanOrEqual.spec.ts

@@ -18,7 +18,7 @@ describe('predicates', () => {
 
         given(49, 50).
         it('ensures that the argument is less than or equal to the upper bound', (value: number) => {
-            expect(new InvestmentLength(value)).to.not.throw;                // tslint:disable-line:no-unused-expression
+            expect(() => new InvestmentLength(value)).to.not.throw;          // tslint:disable-line:no-unused-expression
         });
 
         it('complains if the argument is greater than the upper bound', () => {

spec/predicates/isNumber.spec.ts

@@ -17,7 +17,7 @@ describe('predicates', () => {
         }
 
         it('ensures that the argument in a number', () => {
-            expect(new Percentage(42)).to.not.throw;                         // tslint:disable-line:no-unused-expression
+            expect(() => new Percentage(42)).to.not.throw;                   // tslint:disable-line:no-unused-expression
         });
 
         given(

spec/predicates/isOneOf.spec.ts

@@ -19,7 +19,7 @@ describe('predicates', () => {
 
         given('red', 'yellow', 'green').
         it('ensures that the value is equal to one of the allowed values', (value: string) => {
-            expect(new StreetLight(value)).to.not.throw;                     // tslint:disable-line:no-unused-expression
+            expect(() => new StreetLight(value)).to.not.throw;               // tslint:disable-line:no-unused-expression
         });
 
         it('complains if the value not one the allowed ones', () => {

spec/predicates/isString.spec.ts

@@ -17,7 +17,7 @@ describe('predicates', () => {
         }
 
         it('ensures that the argument in a string', () => {
-            expect(new FirstName('Jan')).to.not.throw;                       // tslint:disable-line:no-unused-expression
+            expect(() => new FirstName('Jan')).to.not.throw;                 // tslint:disable-line:no-unused-expression
         });
 
         given(

spec/predicates/or.spec.ts

@@ -23,7 +23,7 @@ describe('predicates', () => {
 
         given(0, 1, 99, 100).
         it('ensures that at least one of the `or` predicates is met', (value: number) => {
-            expect(new Percentage(value)).to.not.throw;                      // tslint:disable-line:no-unused-expression
+            expect(() => new Percentage(value)).to.not.throw;                // tslint:disable-line:no-unused-expression
         });
 
         given(