don't build/test CRC versions when building for non-x86 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atforms. Signed-off-by: Lexi Bromfield <lexinadia@google.com>
koct9i
added a commit
to ytsaurus/ytsaurus
that referenced
this pull request
Mar 10, 2025
Metro128crc uses SSE4.2 CRC32C. ARM v8.1 has CRC32C too, but this hash function seems pretty much obsolete and unused. Link: jandrewrogers/MetroHash#19 Signed-off-by: Konstantin Khlebnikov <khlebnikov@tracto.ai>
robot-piglet
pushed a commit
to ytsaurus/ytsaurus
that referenced
this pull request
Mar 24, 2025
Metro128crc uses SSE4.2 CRC32C. ARM v8.1 has CRC32C too, but this hash function seems pretty much obsolete and unused. Link: jandrewrogers/MetroHash#19 Signed-off-by: Konstantin Khlebnikov <khlebnikov@tracto.ai> --- Pull Request resolved: #1121 commit_hash:b4ac18cd168b1067062e2d4fdab0edcc4176715c
robot-piglet
pushed a commit
to ytsaurus/ytsaurus
that referenced
this pull request
Mar 24, 2025
Metro128crc uses SSE4.2 CRC32C. ARM v8.1 has CRC32C too, but this hash function seems pretty much obsolete and unused. Link: jandrewrogers/MetroHash#19 Signed-off-by: Konstantin Khlebnikov <khlebnikov@tracto.ai> --- Pull Request resolved: #1121 commit_hash:b4ac18cd168b1067062e2d4fdab0edcc4176715c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't build/test CRC versions when building for non-x86 target platforms.
Signed-off-by: Lexi Bromfield lexinadia@google.com