invalid map entry: nil

[frenchy64]

;; jank
clojure.core=> (conj {} nil)
Exception: invalid map entry: nil

;; clojure
user=> (conj {} nil)
{}

[frenchy64]

Also related, certain map types cannot be merged due to hardcoding.

clojure.core=> (merge {} (sorted-map))
Exception: invalid map entry: {}

[frenchy64]

I looked into this. One solution could be to pull out a common helper to define conj in terms of assoc and fix the problems there. Maybe it could even go in base_persistent_map. Something like this:

  object_ptr conj_map_like(object_ptr const m, object_ptr const head)
  {
    // fix (conj {} nil)
    if(head == obj::nil::nil_const())
    {
      return m;
    }

    // fix (merge {} (sorted-map))
    if(is_map(head->type))
    {
      return runtime::merge(m, head);
    }

    if(head->type != object_type::persistent_vector)
    {
      throw std::runtime_error{ fmt::format("invalid map entry: {}", runtime::to_string(head)) };
    }

    auto const vec(expect_object<obj::persistent_vector>(head));
    if(vec->count() != 2)
    {
      throw std::runtime_error{ fmt::format("invalid map entry: {}", runtime::to_string(head)) };
    }

    return assoc(m, vec->data[0], vec->data[1]);
  }

[jeaye]

Also related, certain map types cannot be merged due to hardcoding.

clojure.core=> (merge {} (sorted-map))
Exception: invalid map entry: {}

This code predates behavior::map_like, which we now have. merge should just be updated to use that. We may want a similar concept for map transients, such as behavior::map_transient_like.