server: do not configure acme if tls listener is not enabled

janos · janos · commit 5d32bc7523e8 · 2019-11-09T22:08:15.000+01:00
diff --git a/server/server.go b/server/server.go
@@ -251,7 +251,7 @@ func (s *Server) WithHTTP(o HTTPOptions) (err error) {
 		ClientSessionCache: tls.NewLRUClientSessionCache(-1),
 	}
 	var acmeHTTPHandler func(fallback http.Handler) http.Handler
-	if s.acmeCertsDir != "" {
+	if s.acmeCertsDir != "" && o.ListenTLS != "" {
 		certManager := autocert.Manager{
 			Prompt: autocert.AcceptTOS,
 			Cache:  autocert.DirCache(s.acmeCertsDir),

Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,7 @@ func (s *Server) WithHTTP(o HTTPOptions) (err error) {`
`251`	`251`	`ClientSessionCache: tls.NewLRUClientSessionCache(-1),`
`252`	`252`	`}`
`253`	`253`	`var acmeHTTPHandler func(fallback http.Handler) http.Handler`
`254`		`- if s.acmeCertsDir != "" {`
	`254`	`+ if s.acmeCertsDir != "" && o.ListenTLS != "" {`
`255`	`255`	`certManager := autocert.Manager{`
`256`	`256`	`Prompt: autocert.AcceptTOS,`
`257`	`257`	`Cache: autocert.DirCache(s.acmeCertsDir),`