-
Notifications
You must be signed in to change notification settings - Fork 53
Missing labels #114
Comments
@christophe-f I believe the upstream backstage chart already provides the ability to apply common labels:
helm-backstage/charts/backstage/values.schema.json Lines 4044 to 4051 in 417057a
We can also use the helm-backstage/charts/backstage/values.schema.json Lines 3732 to 3739 in 417057a
So to get labels on BOTH the backstage deployment and the backstage deployment's pods, the end user will need to apply both. Currently it doesn't seem there's a way to apply labels via the helm chart for the other resources (ex: postgres stateful set, route resources, service resources, etc.) What is the acceptance criteria for this issue? What resources do we want to be able to set labels for in the helm chart? |
It appears that the backstage upstream chart uses a bitnami postgreSQL chart which appears to also have a upstream:
nameOverride: backstage
backstage:
# backstage configs
commonLabels:
test: label
postgresql:
# postgresql configs Only the backstage resources (excluding pods) get the |
I think this is expected. The values are not inherited into nested Charts like this. upstream:
nameOverride: backstage
backstage:
# backstage configs
commonLabels:
test: label
postgresql:
commonLabels:
test: label
# postgresql configs
|
This issue stemmed from an EAP customer asking for the ability to add labels to the pods in the backstage deployment. This issue occurred to them when the dependency for the upstream backstage chart used The Since the current upstream backstage chart dependency is |
What do you want to improve?
Would like to be able to set labels.
What is the current behavior?
What is the new behavior?
The text was updated successfully, but these errors were encountered: