Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Issue: All forms are vulnerable to CSRF #29

Open
deanc opened this issue Dec 23, 2014 · 1 comment
Open

Security Issue: All forms are vulnerable to CSRF #29

deanc opened this issue Dec 23, 2014 · 1 comment

Comments

@deanc
Copy link

deanc commented Dec 23, 2014

Right now this is a security issue, as CSRF can occur.

You should consider moving decoupling all forms into an AbstractType and using the SF2 Form component.

One benefit of this is you can re-use forms elsewhere (and so can people who use the library). Also if you bump up the dependency to SF2.6 you can also use bootstrap form theme out the box, so the templates will also be a lot simpler.

@deanc deanc changed the title Change all hard-coded forms to use SF2 form component Security Issue: Change all hard-coded forms to use SF2 form component (avoid CSRF) Dec 23, 2014
@deanc deanc changed the title Security Issue: Change all hard-coded forms to use SF2 form component (avoid CSRF) Security Issue: All forms are vulnerable to CSRF Dec 23, 2014
@deanc
Copy link
Author

deanc commented Dec 25, 2014

Another issue that I stumbled upon today which could be solved by doing this, is that the custom profile fields are only available after account creation. In theory if the registration form were its own type, you could inject the $app object into the AbstractType for the registration form in the constructor, and therefore dynamically add some custom fields based on the available custom fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant