-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add behavior.{source,user_source} for custom env #26
Conversation
And theres also the clang-tidy thing, but I think its too much, it deserves a rewrite tbh. |
this cod goo, I aprov 👍 |
thats not how reviews works 😭 |
🤓 |
i shoudl build locally before pushing..... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cod is good 👍 |
told u |
only thing left is decent readme which ill do separately... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the best commit in this project so far.
Which one? Or all the PR? |
And false, the best one is 255256b |
srsly? dam, that was just error commenting on my bad code in vc 😔 |
I should put this on a release along with the vectors thing which is not in any release so far
Also, aside, I should also clean up readme and docs in general, and threaten people to star the repo at the end of the readme +
https://api.star-history.com/svg?repos=javalsai/lidm&type=Date
. Not sure if in this PR and branch (its not gonna be much) or a new one. If yall think for another PR, pls review this and I'll merge it in a sec.