Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add behavior.{source,user_source} for custom env #26

Merged
merged 8 commits into from
Dec 25, 2024
Merged

Conversation

javalsai
Copy link
Owner

I should put this on a release along with the vectors thing which is not in any release so far

Also, aside, I should also clean up readme and docs in general, and threaten people to star the repo at the end of the readme + https://api.star-history.com/svg?repos=javalsai/lidm&type=Date. Not sure if in this PR and branch (its not gonna be much) or a new one. If yall think for another PR, pls review this and I'll merge it in a sec.

@javalsai javalsai added the enhancement New feature or request label Dec 25, 2024
@javalsai javalsai self-assigned this Dec 25, 2024
@javalsai
Copy link
Owner Author

And theres also the clang-tidy thing, but I think its too much, it deserves a rewrite tbh.

@mememan77
Copy link

this cod goo, I aprov 👍

@javalsai
Copy link
Owner Author

this cod goo, I aprov 👍

thats not how reviews works 😭

@mememan77
Copy link

this cod goo, I aprov 👍

thats not how reviews works 😭

🤓

@javalsai
Copy link
Owner Author

i shoudl build locally before pushing.....

Copy link
Collaborator

@Pickzelle Pickzelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mememan77
Copy link

cod is good 👍

@mememan77
Copy link

told u

@javalsai
Copy link
Owner Author

only thing left is decent readme which ill do separately...

@javalsai javalsai merged commit 4fb2bb2 into master Dec 25, 2024
13 checks passed
@javalsai javalsai deleted the env-fixes branch December 25, 2024 21:26
Copy link
Collaborator

@grialion grialion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the best commit in this project so far.

@javalsai
Copy link
Owner Author

This is the best commit in this project so far.

Which one? Or all the PR?

@javalsai
Copy link
Owner Author

And false, the best one is 255256b

@grialion
Copy link
Collaborator

4c7d221

@javalsai
Copy link
Owner Author

4c7d221

srsly? dam, that was just error commenting on my bad code in vc 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants