Fix CI deprecation artifact upload/download (#205)

+ fix long scheme parsing
+ remove useless call on hasattr check (before pool memorize)
+ add note about using "multiplexed=True" along with requests-cache

Author: Ousret

.github/workflows/publish.yml

@@ -38,7 +38,7 @@ jobs:
           cd dist && echo "::set-output name=hashes::$(sha256sum * | base64 -w0)"
 
       - name: "Upload dists"
-        uses: "actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874"
+        uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808
         with:
           name: "dist"
           path: "dist/"
@@ -71,7 +71,7 @@ jobs:
 
     steps:
     - name: "Download dists"
-      uses: "actions/download-artifact@9c19ed7fe5d278cd354c7dfd5d3b88589c7e2395"
+      uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e
       with:
         name: "dist"
         path: "dist/"

.github/workflows/run-tests.yml

@@ -53,9 +53,9 @@ jobs:
       run: |
         nox -s "test-${{ startsWith(matrix.python-version, 'pypy') && 'pypy' || matrix.python-version }}"
     - name: "Upload artifact"
-      uses: "actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce"
+      uses: "actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808"
       with:
-        name: coverage-data
+        name: coverage-data-${{ matrix.os }}-${{ matrix.nox-session }}-${{ matrix.python-version }}-${{ matrix.traefik-server }}
         path: ".coverage.*"
         if-no-files-found: error
 
@@ -76,9 +76,10 @@ jobs:
         run: "python -m pip install --upgrade coverage"
 
       - name: "Download artifact"
-        uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a
+        uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
         with:
-          name: coverage-data
+          pattern: coverage-data*
+          merge-multiple: true
 
       - name: "Combine & check coverage"
         run: |
@@ -87,7 +88,7 @@ jobs:
           python -m coverage report --ignore-errors --show-missing --fail-under=77
 
       - name: "Upload report"
-        uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce
+        uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808
         with:
           name: coverage-report
           path: htmlcov

README.md

@@ -123,6 +123,7 @@ Niquests allows you to send HTTP requests extremely easily. There’s no need to
 
 [![Downloads](https://img.shields.io/pypi/dm/niquests.svg)](https://pypistats.org/packages/niquests)
 [![Supported Versions](https://img.shields.io/pypi/pyversions/niquests.svg)](https://pypi.org/project/niquests)
+[![OpenSSF Best Practices](https://www.bestpractices.dev/projects/9950/badge)](https://www.bestpractices.dev/projects/9950)
 
 This project does not require any compilation toolchain. The HTTP/3 support is not enforced and installed if your platform can support it natively _(e.g. pre-built wheel available)_.
 

docs/community/extensions.rst

@@ -44,6 +44,8 @@ Quickstart to leverage its potential::
         for i in range(60):
             r = s.get('https://httpbin.org/delay/1')
 
+.. warning:: Be advised that this extension nullify the advantage of using ``multiplexed=True`` within your Session constructor as is eagerly access the content.
+
 responses
 ---------
 

src/niquests/adapters.py

@@ -966,15 +966,14 @@ def early_response_hook(early_response: BaseHTTPResponse) -> None:
             # branch for urllib3.future 2.5+ with advanced conn/multiplexing scheduler/mapper. aka. TrafficPolice.
             # we are bypassing the PoolManager.request to directly invoke the concerned HttpPool, so we missed
             # a required call to TrafficPolice::memorize(...).
-            if hasattr(self.poolmanager.pools, "memorize"):
-                proxy = select_proxy(request.url, proxies)
+            proxy = select_proxy(request.url, proxies)
 
-                if proxy is not None:
-                    self.proxy_manager[proxy].pools.memorize(resp_or_promise, conn)
-                    self.proxy_manager[proxy].pools.release()
-                else:
-                    self.poolmanager.pools.memorize(resp_or_promise, conn)
-                    self.poolmanager.pools.release()
+            if proxy is not None:
+                self.proxy_manager[proxy].pools.memorize(resp_or_promise, conn)
+                self.proxy_manager[proxy].pools.release()
+            else:
+                self.poolmanager.pools.memorize(resp_or_promise, conn)
+                self.poolmanager.pools.release()
 
         except (ProtocolError, OSError) as err:
             if "illegal header" in str(err).lower():
@@ -2062,18 +2061,16 @@ async def early_response_hook(early_response: BaseAsyncHTTPResponse) -> None:
                 multiplexed=multiplexed,
             )
 
-            # branch for urllib3.future 2.5+ with advanced conn/multiplexing scheduler/mapper. aka. TrafficPolice.
             # we are bypassing the PoolManager.request to directly invoke the concerned HttpPool, so we missed
             # a required call to TrafficPolice::memorize(...).
-            if hasattr(self.poolmanager.pools, "memorize"):
-                proxy = select_proxy(request.url, proxies)
+            proxy = select_proxy(request.url, proxies)
 
-                if proxy is not None:
-                    self.proxy_manager[proxy].pools.memorize(resp_or_promise, conn)
-                    self.proxy_manager[proxy].pools.release()
-                else:
-                    self.poolmanager.pools.memorize(resp_or_promise, conn)
-                    self.poolmanager.pools.release()
+            if proxy is not None:
+                self.proxy_manager[proxy].pools.memorize(resp_or_promise, conn)
+                self.proxy_manager[proxy].pools.release()
+            else:
+                self.poolmanager.pools.memorize(resp_or_promise, conn)
+                self.poolmanager.pools.release()
 
         except (ProtocolError, OSError) as err:
             if "illegal header" in str(err).lower():

src/niquests/utils.py

@@ -1201,7 +1201,7 @@ def _deepcopy_ci(o: ConnectionInfo | None) -> ConnectionInfo | None:
     return n
 
 
-def parse_scheme(url: str, default: str | None = None, max_length: int = 9) -> str:
+def parse_scheme(url: str, default: str | None = None, max_length: int = 11) -> str:
     """We tend to extract url scheme often enough, but we were crazy
     enough to use urlparse for it...! We were wasting precious CPU cycles.
     Return used scheme url, lowercased."""

tests/test_requests.py

@@ -86,7 +86,7 @@ def test_entry_points(self):
             (MissingSchema, "hiwpefhipowhefopw"),
             (InvalidSchema, "localhost:3128"),
             (MissingSchema, "localhost.localdomain:3128/"),
-            (MissingSchema, "10.122.1.1:3128/"),
+            (InvalidSchema, "10.122.1.1:3128/"),
             (InvalidURL, "http://"),
             (InvalidURL, "http://*example.com"),
             (InvalidURL, "http://.example.com"),