diff --git a/CMakeLists.txt b/CMakeLists.txt index e77e63fcad1..24d0f3ef619 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -692,7 +692,7 @@ set(SOURCES db/memtable_list.cc db/merge_helper.cc db/merge_operator.cc - db/multi_cf_iterator_impl.cc + db/multi_cf_iterator.cc db/output_validator.cc db/periodic_task_scheduler.cc db/range_del_aggregator.cc diff --git a/TARGETS b/TARGETS index 2b6d7d6e780..73ddeabc310 100644 --- a/TARGETS +++ b/TARGETS @@ -83,7 +83,7 @@ cpp_library_wrapper(name="rocksdb_lib", srcs=[ "db/memtable_list.cc", "db/merge_helper.cc", "db/merge_operator.cc", - "db/multi_cf_iterator_impl.cc", + "db/multi_cf_iterator.cc", "db/output_validator.cc", "db/periodic_task_scheduler.cc", "db/range_del_aggregator.cc", diff --git a/db/db_impl/db_impl.cc b/db/db_impl/db_impl.cc index 5cf9ef3280c..1e1808b4d94 100644 --- a/db/db_impl/db_impl.cc +++ b/db/db_impl/db_impl.cc @@ -46,7 +46,7 @@ #include "db/memtable.h" #include "db/memtable_list.h" #include "db/merge_context.h" -#include "db/multi_cf_iterator_impl.h" +#include "db/multi_cf_iterator.h" #include "db/periodic_task_scheduler.h" #include "db/range_tombstone_fragmenter.h" #include "db/table_cache.h" @@ -3756,8 +3756,8 @@ std::unique_ptr DBImpl::NewMultiCfIterator( std::vector child_iterators; Status s = NewIterators(_read_options, column_families, &child_iterators); if (s.ok()) { - return std::make_unique( - first_comparator, column_families, std::move(child_iterators)); + return std::make_unique(first_comparator, column_families, + std::move(child_iterators)); } return std::unique_ptr(NewErrorIterator(s)); } diff --git a/db/multi_cf_iterator_impl.cc b/db/multi_cf_iterator.cc similarity index 93% rename from db/multi_cf_iterator_impl.cc rename to db/multi_cf_iterator.cc index 545a55d0211..66a0e85d78b 100644 --- a/db/multi_cf_iterator_impl.cc +++ b/db/multi_cf_iterator.cc @@ -3,13 +3,13 @@ // COPYING file in the root directory) and Apache 2.0 License // (found in the LICENSE.Apache file in the root directory). -#include "db/multi_cf_iterator_impl.h" +#include "db/multi_cf_iterator.h" #include namespace ROCKSDB_NAMESPACE { -void MultiCfIteratorImpl::SeekToFirst() { +void MultiCfIterator::SeekToFirst() { Reset(); int i = 0; for (auto& cfh_iter_pair : cfh_iter_pairs_) { @@ -26,7 +26,7 @@ void MultiCfIteratorImpl::SeekToFirst() { } } -void MultiCfIteratorImpl::Next() { +void MultiCfIterator::Next() { assert(Valid()); // 1. Keep the top iterator (by popping it from the heap) // 2. Make sure all others have iterated past the top iterator key slice diff --git a/db/multi_cf_iterator_impl.h b/db/multi_cf_iterator.h similarity index 88% rename from db/multi_cf_iterator_impl.h rename to db/multi_cf_iterator.h index 19ad9971ccf..253ec7ce076 100644 --- a/db/multi_cf_iterator_impl.h +++ b/db/multi_cf_iterator.h @@ -17,11 +17,11 @@ namespace ROCKSDB_NAMESPACE { // When the same key exists in more than one column families, the iterator // selects the value from the first column family containing the key, in the // order provided in the `column_families` parameter. -class MultiCfIteratorImpl : public Iterator { +class MultiCfIterator : public Iterator { public: - MultiCfIteratorImpl(const Comparator* comparator, - const std::vector& column_families, - const std::vector& child_iterators) + MultiCfIterator(const Comparator* comparator, + const std::vector& column_families, + const std::vector& child_iterators) : comparator_(comparator), min_heap_(MultiCfMinHeapItemComparator(comparator_)) { assert(column_families.size() > 0 && @@ -32,11 +32,11 @@ class MultiCfIteratorImpl : public Iterator { column_families[i], std::unique_ptr(child_iterators[i])); } } - ~MultiCfIteratorImpl() override { status_.PermitUncheckedError(); } + ~MultiCfIterator() override { status_.PermitUncheckedError(); } // No copy allowed - MultiCfIteratorImpl(const MultiCfIteratorImpl&) = delete; - MultiCfIteratorImpl& operator=(const MultiCfIteratorImpl&) = delete; + MultiCfIterator(const MultiCfIterator&) = delete; + MultiCfIterator& operator=(const MultiCfIterator&) = delete; private: std::vector>> diff --git a/src.mk b/src.mk index 2a2059bed31..b19443f64c5 100644 --- a/src.mk +++ b/src.mk @@ -76,7 +76,7 @@ LIB_SOURCES = \ db/memtable_list.cc \ db/merge_helper.cc \ db/merge_operator.cc \ - db/multi_cf_iterator_impl.cc \ + db/multi_cf_iterator.cc \ db/output_validator.cc \ db/periodic_task_scheduler.cc \ db/range_del_aggregator.cc \