Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Release Issues #2

Closed
jborean93 opened this issue Feb 20, 2018 · 1 comment
Closed

Dev Release Issues #2

jborean93 opened this issue Feb 20, 2018 · 1 comment

Comments

@jborean93
Copy link
Owner

jborean93 commented Feb 20, 2018

Trying to keep a list of issues that were encountered during the dev release. Issues so far

Fixes in dev1 releases

  • Server 2008 has a lower max write size than the total size of the PAExec binary, need to dynamically split this up into chunks if required - fixed with f5e2c28 (dev1 release)

  • Server 2008 R2 causes a signature verification failure as it doesn't think it needs to sign the message, e.g. b"\x00" * 16 != actual sig - fixed with jborean93/smbprotocol@f8b53a3, STATUS_PENDING messages don't have a signature (dev1 release)

Fixes in dev2 releases

Fixes in dev3 releases

  • Managing a service was a bit problematic, this change makes thing more pythonic where it runs the command and catch known exceptions instead
  • Added the ability to set a timeout for a connection based on smbprotocol changes
  • Added a retry function when trying to connect to the remote named pipe

Fixes in dev4 release

  • Not sure if it is an issue, but the test_client.TestClientFunctional.test_proc_with_stderr has gotten stuck 1 or 2 times during development. Need to keep an eye for this as I'm not sure if it was another issue that caused it. Caused by running multiple commands in short timeframes on the same service, added 1 sec timeout to the end of the functional client tests to fix this

Fixes still to complete

TBD

@jborean93
Copy link
Owner Author

Version 0.1.0 has been released on pypi https://pypi.python.org/pypi/pypsexec. Going to close this issue in favour for individual issues now it is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant