Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly-working redirects being interpreted as redirect loops in SPNEGO HTTP client. #530

Open
tzsebe opened this issue Oct 2, 2023 · 0 comments · May be fixed by #531
Open

Correctly-working redirects being interpreted as redirect loops in SPNEGO HTTP client. #530

tzsebe opened this issue Oct 2, 2023 · 0 comments · May be fixed by #531

Comments

@tzsebe
Copy link

tzsebe commented Oct 2, 2023 •
edited
Loading

I was using gokrb5 to make WebHDFS requests to a Kerberized cluster, and noticed that after ~10 successful requests, the client starts returning stopped after 10 redirects for all subsequent requests.

A quick inspection shows that the client maintains all redirect requests for its lifetime, and starts emitting failures after it's encountered 10 of them total (rather than 10 for the current request).

I have a fix coded up and tested, where I allow the redirect chain to ride along with the request recursion (without modifying any exported functions). I'll put together a PR for this in the coming days, but wanted to put out this issue in case anyone has additional thoughts on this.
@tzsebe tzsebe linked a pull request Oct 4, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix SPNEGO HTTP client redirect loop detection. tzsebe/gokrb5
1 participant
@tzsebe