Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question to TsVariable(s)Factory in 3.0.0 #426

Open
Immurb opened this issue Jul 9, 2019 · 1 comment
Open

Question to TsVariable(s)Factory in 3.0.0 #426

Immurb opened this issue Jul 9, 2019 · 1 comment
Assignees

Comments

@Immurb
Copy link
Member

Immurb commented Jul 9, 2019

In TsVariableFactory and TsVariablesFactory there are the following if-clauses:

// not enough data at the end
if (iend > n) {
jend = jend - iend + n;
iend = n;
}

// not enough data at the end
if (iend > n) {
jend = jend - iend + n;
iend = n;
}

I was wondering if instead it should be:

if (iend > v.length()){
    jend = jend - iend + n; 
    iend = n;
}
@palatej
Copy link
Contributor

palatej commented Jul 11, 2019

Yes, you are right (and there are other bugs). Not tested yet. I will put the correction and unit tests very soon
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants