fix(cache): report HTTP 410 Gone on stale cache urls

jeabakker · jeabakker · commit cfd488361b7e · 2023-10-11T12:04:37.000+02:00
Instead of 200 Ok fixes Elgg#14086
diff --git a/engine/classes/Elgg/Application/CacheHandler.php b/engine/classes/Elgg/Application/CacheHandler.php
@@ -189,6 +189,9 @@ public function handleRequest(Request $request, Application $app) {
 			$this->simplecache->cacheAsset($viewtype, $view, $content);
 		} else {
 			// if wrong timestamp, don't send HTTP cache
+			// also report that the resource has gone away
+			$response->setStatusCode(ELGG_HTTP_GONE);
+			
 			$content = $this->getProcessedView($view, $viewtype);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,9 @@ public function handleRequest(Request $request, Application $app) {`
`189`	`189`	`$this->simplecache->cacheAsset($viewtype, $view, $content);`
`190`	`190`	`} else {`
`191`	`191`	`// if wrong timestamp, don't send HTTP cache`
	`192`	`+ // also report that the resource has gone away`
	`193`	`+ $response->setStatusCode(ELGG_HTTP_GONE);`
	`194`	`+`
`192`	`195`	`$content = $this->getProcessedView($view, $viewtype);`
`193`	`196`	`}`
`194`	`197`