Skip to content
This repository has been archived by the owner on Apr 16, 2023. It is now read-only.

[🚀] add method to add a token to TokenService #36

Open
finnWellers opened this issue Jun 11, 2019 · 3 comments
Open

[🚀] add method to add a token to TokenService #36

finnWellers opened this issue Jun 11, 2019 · 3 comments
Assignees
@finnWellers
Labels
api Related to API changes / additions (internal API) blocked Feature or bug that is dependent on (internal) changes and cannot progress further. enhancement New feature or request feedback wanted Extra discussion is needed integration Related to integration with OS & other projects (external API) service Issues & PRs related to a specific service.

Comments

@finnWellers
Copy link
Contributor

finnWellers commented Jun 11, 2019 •
edited
Loading

Describe the solution you'd like
You want to be able to add new tokens via the TokenService

Describe why you would like to see this implemented
This would enable further interaction with tokens. Not sure about further use cases
@finnWellers finnWellers added the enhancement New feature or request label Jun 11, 2019
@finnWellers finnWellers self-assigned this Jun 11, 2019
@MarkL4YG MarkL4YG added api Related to API changes / additions (internal API) integration Related to integration with OS & other projects (external API) service Issues & PRs related to a specific service. labels Jun 11, 2019
@MarkL4YG
Copy link
Member

Make sure to keep the generation of tokens inside the token service.
The method should be a request method returning the generated token, not taking one.

@finnWellers
Copy link
Contributor Author

We should either consider moving the TokenService Interface to the public API or introducing a new, framework internal API.

@MarkL4YG
Copy link
Member

MarkL4YG commented Aug 8, 2019

Let's just push this back a little further. The service exists but we're currently unsure about the uses and needs of this feature for plugins.

@MarkL4YG MarkL4YG added the feedback wanted Extra discussion is needed label Aug 8, 2019
@finnWellers finnWellers added the blocked Feature or bug that is dependent on (internal) changes and cannot progress further. label Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@finnWellers finnWellers

Labels
api Related to API changes / additions (internal API) blocked Feature or bug that is dependent on (internal) changes and cannot progress further. enhancement New feature or request feedback wanted Extra discussion is needed integration Related to integration with OS & other projects (external API) service Issues & PRs related to a specific service.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarkL4YG @finnWellers