This repository has been archived by the owner on Apr 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Token-based authentication with user context #209
Draft
MarkL4YG
wants to merge
16
commits into
bleeding-1.X.X
Choose a base branch
from
t/request-authentication
base: bleeding-1.X.X
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…risation-service # Conflicts: # src/main/java/de/fearnixx/jeak/service/http/controller/SparkAdapter.java # src/main/java/de/fearnixx/jeak/service/http/testImpls/TestController.java
MarkL4YG
added
service
Issues & PRs related to a specific service.
api
Related to API changes / additions (internal API)
breaking
Indicator for breaking changes that may violate SEMVER minor rules.
integration
Related to integration with OS & other projects (external API)
labels
Jun 27, 2020
I still have to tidy up some stuff (for example, add the ability to generate tokens via. commands) but the basic idea should be visible. |
finnWellers
suggested changes
Jul 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as info: in ControllerService there is an unused import and ControllerRequestVerifier still has to be deleted. Apart from that it looks good.
Are you sure? Both things don't appear to be the case in my dev environment with no staged changes. 🤔 |
// Next up: Test plugins to test this features 😅 |
…uthentication # Conflicts: # build.gradle
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api
Related to API changes / additions (internal API)
breaking
Indicator for breaking changes that may violate SEMVER minor rules.
integration
Related to integration with OS & other projects (external API)
service
Issues & PRs related to a specific service.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a method that allows HTTP requests to be authenticated as a specific user.
The implementation is not complete and has several extension points that can be worked on in future issues.
The previous mechanism has been deleted in favor of this new implementation. Subsequently, tokens no longer have scopes at the moment.
de.fearnixx.jeak.service.controller
has been renamed tode.fearnixx.jeak.service.http
.IRestControllerService
has been renamed toIControllerService
.de.fearnixx.jeak.reflect.http
.isSecure
parameter ofRequestMapping
annotation has been renamed torequireAuth
.IRequestContext
has been created & implemented as a future extension point to contextual information on requests and additional parameter injections viaRequestContext
annotation.Closes: #203