Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: backend thread crashes if dns fails resolving #17

Open
jecluis opened this issue Mar 3, 2023 · 1 comment
Open

bug: backend thread crashes if dns fails resolving #17

jecluis opened this issue Mar 3, 2023 · 1 comment
Labels
area/core Touches the Core of GHD kind/bug Something isn't working

Comments

@jecluis
Copy link
Owner

jecluis commented Mar 3, 2023

Happened during a transient network failure due to updated routes.

unknown error from send: error sending request for url (https://api.github.com/graphql): error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution
thread 'tokio-runtime-worker' panicked at 'error: UnknownError', src/gh/gql.rs:206:17

We should gracefully handle this and display something in the UI.

@jecluis jecluis added kind/bug Something isn't working area/core Touches the Core of GHD labels Mar 3, 2023
@jecluis jecluis added this to ghd Mar 3, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ghd Mar 3, 2023
@jecluis jecluis moved this from 🆕 New to 📋 Backlog in ghd Mar 3, 2023
@jecluis jecluis added this to the v0.5.0 milestone Apr 29, 2023
@jecluis
Copy link
Owner Author

jecluis commented May 5, 2023

needs to be reproduced.

@jecluis jecluis removed this from the v0.5.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Touches the Core of GHD kind/bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant