Skip to content

Commit 0199376

Browse files
0101oak0101oak
authored
console logs/errors/warn & alert & unused try/catch removed (#19)
console logs/errors/warn & alert & unused try/catch removed
1 parent e028624 commit 0199376

File tree

22 files changed

+264
-463
lines changed

22 files changed

+264
-463
lines changed

‎src/components/login/login.tsx

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,26 +20,21 @@ export const LoginBlock: FC = () => {
2020

2121
const handleLoginSubmit = async (e: FormEvent<HTMLFormElement>) => {
2222
e.preventDefault();
23+
if (!username || !password) {
24+
throw new Error('empty fields');
25+
}
26+
const response: LoginResponse = await login({ username: username, password: password });
2327

24-
try {
25-
if (!username || !password) {
26-
throw new Error('empty fields');
27-
}
28-
const response: LoginResponse = await login({ username: username, password: password });
29-
30-
if (!response.authToken) {
31-
setErrorMessage('token not received');
32-
return;
33-
}
28+
if (!response.authToken) {
29+
setErrorMessage('token not received');
30+
return;
31+
}
3432

35-
const authToken = response.authToken;
33+
const authToken = response.authToken;
3634

37-
localStorage.setItem('authToken', authToken);
35+
localStorage.setItem('authToken', authToken);
3836

39-
navigate({ to: ROUTES.main, replace: true });
40-
} catch (error) {
41-
setErrorMessage('error occured during login process');
42-
}
37+
navigate({ to: ROUTES.main, replace: true });
4338
};
4439

4540
const handlePasswordChange = (e: ChangeEvent<HTMLInputElement>) => {

‎src/components/managers/archive/archive.tsx

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -38,31 +38,22 @@ export const Archive: FC = () => {
3838
items: item,
3939
},
4040
};
41-
try {
42-
const response = await addArchive(newArchive);
43-
console.log('archive added: ', response.id);
44-
setItem([]);
45-
} catch (error) {
46-
console.error(error);
47-
}
41+
await addArchive(newArchive);
42+
setItem([]);
4843
};
4944

5045
useEffect(() => {
5146
const fetchUploadedFiles = async () => {
52-
try {
53-
const response = await getAllUploadedFiles({
54-
limit: 5,
55-
offset: 0,
56-
orderFactor: 'ORDER_FACTOR_ASC',
57-
});
47+
const response = await getAllUploadedFiles({
48+
limit: 5,
49+
offset: 0,
50+
orderFactor: 'ORDER_FACTOR_ASC',
51+
});
5852

59-
const filesArray = response.list || [];
60-
const urls = filesArray.map((file: common_Media) => file.media?.fullSize || '');
53+
const filesArray = response.list || [];
54+
const urls = filesArray.map((file: common_Media) => file.media?.fullSize || '');
6155

62-
setFilesUrl(urls);
63-
} catch (error) {
64-
console.error('Error fetching uploaded files:', error);
65-
}
56+
setFilesUrl(urls);
6657
};
6758

6859
fetchUploadedFiles();

‎src/components/managers/archive/archiveComponents/archivePaged.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,8 @@ export const ArchivePaged: FC<ArchiveList> = ({
5252
};
5353

5454
const deleteItem = async (id: number | undefined) => {
55-
try {
56-
const response = await deleteItemFromArchive({ itemId: id });
57-
console.log('iteme deleted: ', response);
58-
fetchArchive();
59-
} catch (error) {
60-
console.error(error);
61-
}
55+
await deleteItemFromArchive({ itemId: id });
56+
fetchArchive();
6257
};
6358
return (
6459
<div className={styles.list_archive}>

‎src/components/managers/archive/getArchive.tsx

Lines changed: 31 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,13 @@ export const GetArchive: FC = () => {
4242

4343
const handleSaveClick = async () => {
4444
if (editingArchive && editItemId) {
45-
try {
46-
await updateArchive({
47-
id: editItemId,
48-
archive: editingArchive,
49-
});
50-
setEditItemId(undefined);
51-
setEditingArchive(null);
52-
fetchArchive();
53-
} catch (error) {
54-
console.error(error);
55-
}
45+
await updateArchive({
46+
id: editItemId,
47+
archive: editingArchive,
48+
});
49+
setEditItemId(undefined);
50+
setEditingArchive(null);
51+
fetchArchive();
5652
}
5753
};
5854

@@ -65,16 +61,12 @@ export const GetArchive: FC = () => {
6561
};
6662

6763
const fetchArchive = async () => {
68-
try {
69-
const response = await getArchive({
70-
limit: 5,
71-
offset: 0,
72-
orderFactor: 'ORDER_FACTOR_ASC',
73-
});
74-
setArchive(response.archives);
75-
} catch (error) {
76-
console.error(error);
77-
}
64+
const response = await getArchive({
65+
limit: 5,
66+
offset: 0,
67+
orderFactor: 'ORDER_FACTOR_ASC',
68+
});
69+
setArchive(response.archives);
7870
};
7971

8072
useEffect(() => {
@@ -83,20 +75,16 @@ export const GetArchive: FC = () => {
8375

8476
useEffect(() => {
8577
const fetchUploadedFiles = async () => {
86-
try {
87-
const response = await getAllUploadedFiles({
88-
limit: 5,
89-
offset: 0,
90-
orderFactor: 'ORDER_FACTOR_ASC',
91-
});
92-
93-
const filesArray = response.list || [];
94-
const urls = filesArray.map((file: common_Media) => file.media?.fullSize || '');
95-
96-
setFilesUrl(urls);
97-
} catch (error) {
98-
console.error('Error fetching uploaded files:', error);
99-
}
78+
const response = await getAllUploadedFiles({
79+
limit: 5,
80+
offset: 0,
81+
orderFactor: 'ORDER_FACTOR_ASC',
82+
});
83+
84+
const filesArray = response.list || [];
85+
const urls = filesArray.map((file: common_Media) => file.media?.fullSize || '');
86+
87+
setFilesUrl(urls);
10088
};
10189

10290
fetchUploadedFiles();
@@ -114,17 +102,12 @@ export const GetArchive: FC = () => {
114102
};
115103

116104
const submitNewItem = async (archiveId: number) => {
117-
try {
118-
const newItem = newItemsByArchiveId[archiveId];
119-
const response = await addArchiveItem({
120-
archiveId: archiveId,
121-
items: [newItem],
122-
});
123-
console.log(response);
124-
fetchArchive();
125-
} catch (error) {
126-
console.error(error);
127-
}
105+
const newItem = newItemsByArchiveId[archiveId];
106+
await addArchiveItem({
107+
archiveId: archiveId,
108+
items: [newItem],
109+
});
110+
fetchArchive();
128111
};
129112

130113
const handleMediaSelection = (archiveId: number, mediaUrl: string) => {
@@ -135,13 +118,8 @@ export const GetArchive: FC = () => {
135118
};
136119

137120
const removeArchive = async (id: number | undefined) => {
138-
try {
139-
const response = await deleteArchive({ id });
140-
console.log('archive deleted: ', response);
141-
fetchArchive();
142-
} catch (error) {
143-
console.error;
144-
}
121+
const response = await deleteArchive({ id });
122+
fetchArchive();
145123
};
146124

147125
return (

‎src/components/managers/hero/getHero.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,12 @@ export const GetHero: FC = () => {
88

99
useEffect(() => {
1010
const fetchHero = async () => {
11-
try {
12-
const response = await getHero({});
13-
setHero(response.hero);
14-
} catch (error) {
15-
console.error(error);
16-
}
11+
const response = await getHero({});
12+
setHero(response.hero);
1713
};
1814
fetchHero();
1915
}, []);
16+
2017
return (
2118
<Layout>
2219
<div>

‎src/components/managers/hero/hero.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ export const Hero: FC = () => {
1212
};
1313

1414
const navigatePagedProduct = () => {
15-
console.log('Navigate to LIST PRODUCTS');
1615
navigate({ to: ROUTES.getHero, replace: true });
1716
};
1817
return (

‎src/components/managers/hero/heroPageProduct.tsx

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,19 +45,15 @@ export const HeroPageProduct: FC<HeroProductsProps> = ({ productIds, setProductI
4545
}, [currentPage]);
4646

4747
const fetchData = async () => {
48-
try {
49-
const newLimit = filter.limit || 6;
50-
const offset = calculateOffset(currentPage, newLimit);
51-
const response: GetProductsPagedResponse = await getProductsPaged({
52-
...filter,
53-
limit: newLimit,
54-
offset,
55-
});
48+
const newLimit = filter.limit || 6;
49+
const offset = calculateOffset(currentPage, newLimit);
50+
const response: GetProductsPagedResponse = await getProductsPaged({
51+
...filter,
52+
limit: newLimit,
53+
offset,
54+
});
5655

57-
setProducts(response.products ? response.products.slice(0, newLimit) : []);
58-
} catch (error) {
59-
console.error(error);
60-
}
56+
setProducts(response.products ? response.products.slice(0, newLimit) : []);
6157
};
6258

6359
const handleProductClick = (index: number | undefined) => {

‎src/components/managers/hero/mediaPicker.tsx

Lines changed: 13 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,9 @@ export const MediaPicker: FC = () => {
9999

100100
const addNewHero = async (e: React.FormEvent) => {
101101
e.preventDefault();
102-
try {
103-
const response = await addHero({ main, ads, productIds });
104-
console.log('hero added:', response);
105-
setAds([]);
106-
setProductIds([]);
107-
} catch (error) {
108-
console.error(error);
109-
}
102+
const response = await addHero({ main, ads, productIds });
103+
setAds([]);
104+
setProductIds([]);
110105
};
111106

112107
const select = (imageUrl: string | number) => {
@@ -131,26 +126,21 @@ export const MediaPicker: FC = () => {
131126

132127
useEffect(() => {
133128
const fetchUploadedFiles = async () => {
134-
try {
135-
const response = await getAllUploadedFiles({
136-
limit: 5,
137-
offset: 0,
138-
orderFactor: 'ORDER_FACTOR_ASC',
139-
});
140-
141-
const filesArray = response.list || [];
142-
const urls = filesArray.map((file: common_Media) => file.media?.fullSize || '');
143-
144-
setFilesUrl(urls);
145-
} catch (error) {
146-
console.error('Error fetching uploaded files:', error);
147-
}
129+
const response = await getAllUploadedFiles({
130+
limit: 5,
131+
offset: 0,
132+
orderFactor: 'ORDER_FACTOR_ASC',
133+
});
134+
135+
const filesArray = response.list || [];
136+
const urls = filesArray.map((file: common_Media) => file.media?.fullSize || '');
137+
138+
setFilesUrl(urls);
148139
};
149140

150141
fetchUploadedFiles();
151142
}, []);
152143

153-
// remove
154144
return (
155145
<Layout>
156146
<form onSubmit={addNewHero} className={styles.hero}>

‎src/components/managers/media/mediaManager.tsx

Lines changed: 20 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ export const MediaManager: FC = () => {
6868

6969
const selectedFile = selectedFiles[0];
7070
const fileExtension = (selectedFile.name.split('.').pop() || '').toLowerCase();
71-
console.log('File extension:', fileExtension);
7271

7372
if (!fileExtension) {
7473
alert('Invalid file format.');
@@ -80,33 +79,27 @@ export const MediaManager: FC = () => {
8079
if (event.target && event.target.result) {
8180
const baseData64 = event.target.result as string;
8281

83-
try {
84-
const contentType = fileExtensionToContentType[fileExtension];
85-
86-
if (!contentType) {
87-
alert('Invalid extension');
88-
return;
89-
}
90-
91-
if (contentType.startsWith('image')) {
92-
const response = await uploadContentImage({
93-
rawB64Image: baseData64,
94-
});
95-
console.log('Uploaded:', response);
96-
} else if (contentType.startsWith('video')) {
97-
const raw = trimBeforeBase64(baseData64);
98-
const response = uploadContentVideo({
99-
raw: raw,
100-
contentType: contentType,
101-
});
102-
console.log('Uploaded:', response);
103-
}
104-
105-
setSelectedFiles([]);
106-
setSelectedFileUrl(null);
107-
} catch (error) {
108-
alert('Error uploading file');
82+
const contentType = fileExtensionToContentType[fileExtension];
83+
84+
if (!contentType) {
85+
alert('Invalid extension');
86+
return;
87+
}
88+
89+
if (contentType.startsWith('image')) {
90+
await uploadContentImage({
91+
rawB64Image: baseData64,
92+
});
93+
} else if (contentType.startsWith('video')) {
94+
const raw = trimBeforeBase64(baseData64);
95+
await uploadContentVideo({
96+
raw: raw,
97+
contentType: contentType,
98+
});
10999
}
100+
101+
setSelectedFiles([]);
102+
setSelectedFileUrl(null);
110103
}
111104
};
112105

0 commit comments

Comments
 (0)