-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lyrics not being downloaded / no manual download option #3
Comments
I only tested with manual searching using Jellyfin's api, and forgot to hook lyrics into the rest of the functionality. As of right now Jellyfin only fully supports lyrics that are already available either embedded or next to the audio file. I may add a scheduled task to automatically download lyrics into the plugin as a temporary fix. |
Do you mean that you tested by finding lyrics that are already present in the tracks? I can see in the code for this plugin that there is functionality to fetch lyrics, however it's not being called anywhere. Is this plugin something that is still WIP, or is there already a way to use it to fetch lyrics? |
The only way to search for remote lyrics right now is to manually hit Jellyfin's API. |
Can you please explain better what do you mean by "manually hit Jellyfin's API"? how should it be done? |
any update on this on how to search for lyrics and generate files? |
You can do this with 2 requests per song, e.g. via curl or browser devtools (I used "edit and resend" in Firefox to quickly borrow
This will return available lyrics from all enabled lyrics providers (which in my case was only LrcLib), for example: [
{
"Id": "a1da397dd09c89a18bacecb3a5d45d37_984710_synced",
"ProviderName": "LrcLib",
"Lyrics": {
"Metadata": {
"Artist": "Two Feet",
"Album": "A 20 Something Fuck",
"Title": "I Feel Like I'm Drowning",
"Length": 1860000000,
"IsSynced": true
},
"Lyrics": [
{
"Text": "You keep dreamin' and dark schemin'",
"Start": 132000000
},
{
"Text": "Yeah, you do",
"Start": 166800000
},
[...]
]
}
},
{
"Id": "a1da397dd09c89a18bacecb3a5d45d37_984710_plain",
"ProviderName": "LrcLib",
"Lyrics": {
"Metadata": {
"Artist": "Two Feet",
"Album": "A 20 Something Fuck",
"Title": "I Feel Like I'm Drowning",
"Length": 1860000000,
"IsSynced": false
},
"Lyrics": [
{
"Text": "You keep dreamin' and dark schemin'"
},
{
"Text": "Yeah, you do"
},
[...]
]
}
}
]
This downloads lyrics, saves them to server and also returns them in HTTP response. |
Yeah, I think I'm waiting for the plugin to get a scheduled task. 😅 |
Adding the scheduled task in #4 Feel free to test, it is pretty basic and not really configurable. |
Thank you reaally much for your work ! Do you think it will be possible, in the future, to add a button to fetch lyrics for a specific song only (for example in the right click menu, and also something for Apps like Finamp to be able to fetch lyrics using this plugin), and not only get all the lyrics of all the tracks in your library ? |
Yes, but that would be built into the server and not this plugin. |
thank you for this plugin . |
|
im sorry I never had to run scheduled task before |
I'm gonna take a wild guess here and respectfully assume you're probably not a developer and hence didn't build the plugin yourself and installed it manually instead of the current release available through the standard procedure. If that's the case it's probably best for you to just wait a little bit for the new version with the added functionality to release, probably not too far away now. |
Hi, is there an ETA for the next release that includes the scheduled job? Setting everything up to build the plugin myself would not be a great hassle as I am a developer but won't be worth the effort if the next release is around the corner 😄 Thanks for your work and best regards, |
Any updates? @crobibero |
I am not planning on releasing the plugin with the scheduled task built in. If you want it you will need to build it yourself. The task will exist for Jellyfin 10.10 |
Hey everyone. I got it working :D You need to do the following:
You can find the source code and ask for help here: https://github.com/Felitendo/jellyfin-lyrics-plugin Hope this helps :) |
@Felitendo thank you so much! I'll give this a try soon. |
For anyone else who may be installing from @Felitendo's repository, make sure you have upgraded to 10.9.10. The plug-in was initially unsupported for me as I was still on 10.9.7. |
@Felitendo Thank you very much, it works very well on my end! As what @thecodygriffin said, Jellyfin should definitely be upgraded to 10.9.10 as I've tried it on 10.9.9 and it didn't work. |
I tried both manually building the plugin and using @Felitendo 's repository and I can't get scheduled task to show up. I am on Jellyfin 10.9.11 if that affects anything. Any advice? |
I second this. Any updates on this, @Felitendo? |
I'm sorry that it doesn't work for you @TannerNelson16 and @pollocluck. |
I can confirm the downloads are now working on the public version of Finamp. Thank you so much @Felitendo ! |
Hello I just installed this *but sadly I can't find 'Download missing lyrics' in tasks...I'm using 10.9.11 too but not so fresh install if being honest, it runs for some weeks now |
|
@Felitendo That worked! Thank you. |
Jellyfin 10.10 is now released so automatic lyric downloading is built-in. |
Is it a setting somewhere in jellyfin and if so what is it called and how can we use it? (If it has the exact same features as my fork then I'm going to deprecate it) |
Yes, it has the same features as the original PR that I had created to add the scheduled task. |
I just installed this plugin on my Jellyfin 10.9 server. First of all I see in the code that the settings should show 3 checkboxes, however in my settings I can only see the checkbox for strict search (the other 2 are briefly visible before disappearing).
I'm also not sure how this plugin is meant to be used. Is it supposed to automatically fetch lyrics for my music library? Because it's not doing that, and I also see no option to fetch lyrics manually for a given artist/album/track. Any help?
The text was updated successfully, but these errors were encountered: