Load only required fallback fonts for ASS subtitles, instead of preloading them all #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thornbill
added
enhancement
It used to be limited to 20 MB total previously. We cannot easily limit total size of fonts anymore, so the least we can do is to keep the size of a single font file in check.
|
Cloudflare Pages deployment
|
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! Requires this PR to be merged: jellyfin/jellyfin#12511
Changes
Currently the way fallback fonts work is that they load all the fonts into browser before starting playback (up to the arbitrary 20 MB limit), which for obvious reasons sucks. Subtitle Octopus library has a feature where you can define a map of font family to URL to have it only load the required fonts used by particular .ASS file on-demand instead of preloading them all and then figuring out what's gonna be used, which is infinitely better.
Depicted below loading only the few required fonts instead of hundreds:
Issues