Next episode has mismatched language between server and ui (rebased)

[Kinsteen]

Simple rebase on new master to remove merge conflicts of #4852. Didn't test yet, would be happy if people could!

Root cause

The autoset options only seem to take effect on non-transcoded media-- the transcode URL is never updated! This means that if the selected audio does not match the default, the audio/subs are in the default but the UI reflects the auto-set variant (showing a language that isn't playing).

Changes

When setting the track in the the auto-set logic, also trivially change the audio index in the transcode URL to match.

This fixes it in most cases, but there may be some edge cases that need to go through the full validation to recreate the URL. I don't know the code well enough for that, though.

Issues

Fixes #3994

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jellyfin-bot]

Cloudflare Pages deployment

Latest commit	13e3b795a8ca9bcf65b27e13c9923bf21665a5ff
Status	✅ Deployed!
Preview URL	https://8c59d236.jellyfin-web.pages.dev
Type	🔀 Preview

[viown]

Was able to reproduce the mentioned issue, and after testing this, it does seem to fix it.

[dmitrylyzo]

In addition to #4852 (comment)

Changing streams after receiving PlaybackInfo may result in unwanted remuxing/transcoding:

• The "best" subtitles may not require transcoding.
• The "best" audio may not require remuxing. <- less possible

It's better to do this on the server side so that every client gets this auto-select feature.

But speaking of web, we should do ranking and update corresponding fields before getting PlaybackInfo:

jellyfin-web/src/components/playback/playbackmanager.js

Lines 2577 to 2578 in f4a872d

	audioStreamIndex,
	subtitleStreamIndex,

[viown]

In addition to #4852 (comment)

Changing streams after receiving PlaybackInfo may result in unwanted remuxing/transcoding:

* The "best" subtitles may not require transcoding.

* The "best" audio may not require remuxing. _<- less possible_

It's better to do this on the server side so that every client gets this auto-select feature.

But speaking of web, we should do ranking and update corresponding fields before getting PlaybackInfo:

jellyfin-web/src/components/playback/playbackmanager.js

Lines 2577 to 2578 in f4a872d

	audioStreamIndex,
	subtitleStreamIndex,

Setting the audioStreamIndex/subtitleStreamIndex in options does not seem to affect the stream URL in some scenarios (only when remuxing/direct playing). Any idea why that is?

[dmitrylyzo]

Setting the audioStreamIndex/subtitleStreamIndex in options does not seem to affect the stream URL in some scenarios (only when remuxing/direct playing). Any idea why that is?

Because they are processed on the client side when DirectPlay. It should use mediaSource.DefaultAudioStreamIndex and mediaSource.DefaultSubtitleStreamIndex.

[jellyfin-bot]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[ebkalderon]

It seems that #6112 has been merged, so I believe this might be safe to close?

[Kinsteen]

Seems so, closing