From 16aad96ae6c0763a50c95494472ef8d4858138d8 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 23 Oct 2024 15:52:27 -0400
Subject: [PATCH 01/59] fix: Update jQuery filter removal syntax for 3.x
 compatibility

---
 src/main/webapp/js/jquery.fancybox-1.3.4.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/webapp/js/jquery.fancybox-1.3.4.js b/src/main/webapp/js/jquery.fancybox-1.3.4.js
index 55c08ddb..b1667fcd 100644
--- a/src/main/webapp/js/jquery.fancybox-1.3.4.js
+++ b/src/main/webapp/js/jquery.fancybox-1.3.4.js
@@ -577,8 +577,8 @@
 
 		_finish = function () {
 			if (!$.support.opacity) {
-				content.get(0).style.removeAttribute('filter');
-				wrap.get(0).style.removeAttribute('filter');
+				content.css('filter', '');
+				wrap.css('filter', '');
 			}
 
 			if (selectedOpts.autoDimensions) {

From d74f1295bcc8df18bdbb57f85e6fba84f8738196 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 23 Oct 2024 16:23:26 -0400
Subject: [PATCH 02/59] address first csp issue:
 https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly\#L64

---
 .../plugin/buildpipeline/BuildPipelineView/bpp.jelly   |  1 +
 .../BuildCardExtension/build-card-template-onclicks.js | 10 ++++++++++
 .../BuildCardExtension/buildCardTemplate.jelly         |  3 ++-
 3 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index f349bfc8..546e01fb 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -12,6 +12,7 @@
     </j:if>
 
     <st:adjunct includes="io.jenkins.plugins.jquery3"/>
+    <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.extension.BuildCardExtension.build-card-template-onclicks"/>
     <script src="${rootURL}/plugin/build-pipeline-plugin/js/jquery-migrate-1.2.1.min.js"></script>
     <script type="text/javascript" src="${rootURL}/plugin/build-pipeline-plugin/js/jquery-ui-1.8.14.custom.min.js"></script>
     <script type="text/javascript" src="${rootURL}/plugin/build-pipeline-plugin/js/handlebars-1.0.0.beta.6.js"></script>
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
new file mode 100644
index 00000000..53c8672b
--- /dev/null
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -0,0 +1,10 @@
+Behaviour.specify(".progress-console-onclick", 'progress-bar-click', 0, function (progressBarElement) {
+
+    const dataContainer = document.querySelector(".fill-dialog-data-container");
+    const href = dataContainer.dataset.fillDialogHref;
+    const title = dataContainer.dataset.fillDialogTitle;
+
+    progressBarElement.addEventListener('click', () => {
+        buildPipeline.fillDialog(href, title);
+    });
+});
\ No newline at end of file
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index 9ccb95a2..1ac7e88b 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -61,7 +61,8 @@
         {{#unless project.disabled}}
         <div class="status-bar" id="status-bar-{{id}}">
             {{#if build.isBuilding}}
-                <div onclick="buildPipeline.fillDialog('${app.rootUrl}{{build.url}}console', 'Console output for {{project.name}} #{{build.number}}')">
+            <span class="fill-dialog-data-container" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
+                <div class="progress-console-onclick">
                     <table class="progress-bar" align="center">
                         <tbody>
                             <tr title="Estimated remaining time: {{build.estimatedRemainingTime}}">

From 317e0fa572887a803a89820e629802fb974b0c5c Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 23 Oct 2024 16:26:05 -0400
Subject: [PATCH 03/59] address first csp issue:
 https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly\#L64

---
 .../BuildCardExtension/build-card-template-onclicks.js          | 2 +-
 .../extension/BuildCardExtension/buildCardTemplate.jelly        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 53c8672b..7bcb8a4b 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -7,4 +7,4 @@ Behaviour.specify(".progress-console-onclick", 'progress-bar-click', 0, function
     progressBarElement.addEventListener('click', () => {
         buildPipeline.fillDialog(href, title);
     });
-});
\ No newline at end of file
+});
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index 1ac7e88b..417e3844 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -61,7 +61,7 @@
         {{#unless project.disabled}}
         <div class="status-bar" id="status-bar-{{id}}">
             {{#if build.isBuilding}}
-            <span class="fill-dialog-data-container" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
+                <span class="fill-dialog-data-container" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
                 <div class="progress-console-onclick">
                     <table class="progress-bar" align="center">
                         <tbody>

From 913d01a13f6d9fa1e817818c336fb7e870ac5298 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 23 Oct 2024 16:54:15 -0400
Subject: [PATCH 04/59] line 97:
 https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly\#L97

---
 .../build-card-template-onclicks.js                 | 13 ++++++++++++-
 .../BuildCardExtension/buildCardTemplate.jelly      |  5 +++--
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 7bcb8a4b..6d72ac68 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -1,6 +1,6 @@
 Behaviour.specify(".progress-console-onclick", 'progress-bar-click', 0, function (progressBarElement) {
 
-    const dataContainer = document.querySelector(".fill-dialog-data-container");
+    const dataContainer = document.querySelector(".fill-dialog-params-statusbar");
     const href = dataContainer.dataset.fillDialogHref;
     const title = dataContainer.dataset.fillDialogTitle;
 
@@ -8,3 +8,14 @@ Behaviour.specify(".progress-console-onclick", 'progress-bar-click', 0, function
         buildPipeline.fillDialog(href, title);
     });
 });
+
+Behaviour.specify(".console-icon-onlick", 'console-icon-click', 0, function (consoleIconElement) {
+
+    const dataContainer = document.querySelector(".fill-dialog-params-console-output-icon");
+    const href = dataContainer.dataset.fillDialogHref;
+    const title = dataContainer.dataset.fillDialogTitle;
+
+    consoleIconElement.addEventListener('click', () => {
+        buildPipeline.fillDialog(href, title);
+    });
+});
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index 417e3844..3b96b954 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -61,7 +61,7 @@
         {{#unless project.disabled}}
         <div class="status-bar" id="status-bar-{{id}}">
             {{#if build.isBuilding}}
-                <span class="fill-dialog-data-container" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
+                <span class="fill-dialog-params-statusbar" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
                 <div class="progress-console-onclick">
                     <table class="progress-bar" align="center">
                         <tbody>
@@ -95,7 +95,8 @@
                             </a>
                         </j:when>
                         <j:otherwise>
-                            <span onclick="buildPipeline.fillDialog('${app.rootUrl}{{build.url}}console', 'Console output for {{project.name}} #{{build.number}}')">
+                            <span class="fill-dialog-params-console-output-icon" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
+                            <span class="console-icon-onlick" >
                                 <l:icon src="${consoleOutputIconUrl} icon-sm" alt="console" />
                             </span>
                         </j:otherwise>

From 31008b15489f09e2429733674786f553b1bc9bb7 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 29 Oct 2024 15:50:57 -0400
Subject: [PATCH 05/59] fix:
 https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly\#L109

---
 .../build-card-template-onclicks.js           | 30 +++++++++++++++----
 .../buildCardTemplate.jelly                   | 11 +++----
 2 files changed, 30 insertions(+), 11 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 6d72ac68..1b1a8823 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -1,21 +1,39 @@
-Behaviour.specify(".progress-console-onclick", 'progress-bar-click', 0, function (progressBarElement) {
+Behaviour.specify(".bct-progress-console-onclick", 'BuildCardExtension_progressBarClick', 0, function (element) {
 
-    const dataContainer = document.querySelector(".fill-dialog-params-statusbar");
+    const dataContainer = document.querySelector(".bct-progress-console-onclick-params");;
     const href = dataContainer.dataset.fillDialogHref;
     const title = dataContainer.dataset.fillDialogTitle;
 
-    progressBarElement.addEventListener('click', () => {
+    element.addEventListener('click', () => {
         buildPipeline.fillDialog(href, title);
     });
 });
 
-Behaviour.specify(".console-icon-onlick", 'console-icon-click', 0, function (consoleIconElement) {
+Behaviour.specify(".bct-console-icon-onclick", 'BuildCardExtension_consoleIconClick', 0, function (element) {
 
-    const dataContainer = document.querySelector(".fill-dialog-params-console-output-icon");
+    const dataContainer = document.querySelector(".bct-console-icon-onclick-params");
     const href = dataContainer.dataset.fillDialogHref;
     const title = dataContainer.dataset.fillDialogTitle;
 
-    consoleIconElement.addEventListener('click', () => {
+    element.addEventListener('click', () => {
         buildPipeline.fillDialog(href, title);
     });
 });
+
+Behaviour.specify(".bct-rerun-success-icon-onclick", 'BuildCardExtension_successRerunClick', 0, function(element) {
+
+    const dataContainer = document.querySelector(".bct-rerun-success-icon-onclick-params");
+    const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
+    const buildExtId = dataContainer.dataset.rerunBuildExtId;
+    const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
+        .split(',')
+        .filter(Boolean)
+        .map(id => parseInt(id, 10));
+
+    element.addEventListener('click', () => {
+        buildPipeline.showSpinner(id);
+        buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
+    });
+});
+
+
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index 3b96b954..c484961f 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -61,8 +61,8 @@
         {{#unless project.disabled}}
         <div class="status-bar" id="status-bar-{{id}}">
             {{#if build.isBuilding}}
-                <span class="fill-dialog-params-statusbar" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
-                <div class="progress-console-onclick">
+                <span class="bct-progress-console-onclick-params" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
+                <div class="bct-progress-console-onclick">
                     <table class="progress-bar" align="center">
                         <tbody>
                             <tr title="Estimated remaining time: {{build.estimatedRemainingTime}}">
@@ -95,8 +95,8 @@
                             </a>
                         </j:when>
                         <j:otherwise>
-                            <span class="fill-dialog-params-console-output-icon" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
-                            <span class="console-icon-onlick" >
+                            <span class="bct-console-icon-onclick-params" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
+                            <span class="bct-console-icon-onclick" >
                                 <l:icon src="${consoleOutputIconUrl} icon-sm" alt="console" />
                             </span>
                         </j:otherwise>
@@ -108,7 +108,8 @@
                 {{#if build.isSuccess}}
                     {{#if ${!it.triggerOnlyLatestJob}}}
                     <j:if test="${it.hasBuildPermission()}">
-                    <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.rerunBuild({{id}}, '{{build.extId}}', [{{build.dependencyIds}}])">
+                    <span class="bct-rerun-success-icon-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
+                    <span class="bct-rerun-success-icon-onclick">
                         <l:icon src="icon-clock icon-sm" alt="re-run" />
                     </span>
                     </j:if>

From 85d08a32b988e08edd979cdc338ffdea6f627384 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 29 Oct 2024 17:04:39 -0400
Subject: [PATCH 06/59] 
 fix:https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly\#L118

---
 .../build-card-template-onclicks.js              | 16 ++++++++++++++++
 .../BuildCardExtension/buildCardTemplate.jelly   |  9 ++++++++-
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 1b1a8823..a17ecb89 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -36,4 +36,20 @@ Behaviour.specify(".bct-rerun-success-icon-onclick", 'BuildCardExtension_success
     });
 });
 
+Behaviour.specify(".bct-rerun-latest-build-onclick", 'BuildCardExtension_latestRerunClick', 0, function(element) {
+
+    const dataContainer = document.querySelector(".bct-rerun-latest-build-onclick-params");
+    const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
+    const buildExtId = dataContainer.dataset.rerunBuildExtId;
+    const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
+        .split(',')
+        .filter(Boolean)
+        .map(id => parseInt(id, 10));
+
+    element.addEventListener('click', () => {
+        buildPipeline.showSpinner(id);
+        buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
+    });
+});
+
 
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index c484961f..17cdf210 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -118,19 +118,26 @@
                     {{#if ${it.triggerOnlyLatestJob}}}
                         {{#if build.isLatestBuild}}
                             {{#if build.isUpstreamBuildLatest}}
-                            <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.rerunBuild({{id}}, '{{build.extId}}', [{{build.dependencyIds}}])">
+                            <span class="bct-rerun-latest-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
+                            <span class="bct-rerun-latest-build-onclick">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
                             </span>
+<!--                            <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.rerunBuild({{id}}, '{{build.extId}}', [{{build.dependencyIds}}])">-->
+<!--                                <l:icon src="icon-clock icon-sm" alt="retry" />-->
+<!--                            </span>-->
+<!--            <h1>Shlomo</h1>-->
                             {{/if}}
                         {{/if}}
                     {{else}}
                         {{#if build.isManual}}
                             <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.triggerBuild({{id}}, '{{upstream.projectName}}', {{upstream.buildNumber}}, '{{project.name}}', [{{build.dependencyIds}}])">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
+                                <h1>Shlomo2</h1>
                             </span>
                         {{else}}
                             <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.rerunBuild({{id}}, '{{build.extId}}', [{{build.dependencyIds}}])">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
+                                <h1>Shlomo3</h1>
                             </span>
                         {{/if}}
                     {{/if}}

From f5f7cc7b8f898e7a9fbb32d1f9de289907d244e8 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 29 Oct 2024 17:05:07 -0400
Subject: [PATCH 07/59] 
 fix:https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly\#L118

---
 .../extension/BuildCardExtension/buildCardTemplate.jelly      | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index 17cdf210..538a74e6 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -122,10 +122,6 @@
                             <span class="bct-rerun-latest-build-onclick">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
                             </span>
-<!--                            <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.rerunBuild({{id}}, '{{build.extId}}', [{{build.dependencyIds}}])">-->
-<!--                                <l:icon src="icon-clock icon-sm" alt="retry" />-->
-<!--                            </span>-->
-<!--            <h1>Shlomo</h1>-->
                             {{/if}}
                         {{/if}}
                     {{else}}

From 2147df295726abf07a7c451e2076e4e14fdae113 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 29 Oct 2024 21:30:52 -0400
Subject: [PATCH 08/59] fix:
 https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly\#L129

---
 .../build-card-template-onclicks.js           | 317 +++++++++++++++---
 .../buildCardTemplate.jelly                   |  11 +-
 2 files changed, 282 insertions(+), 46 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index a17ecb89..7def0a23 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -1,55 +1,288 @@
-Behaviour.specify(".bct-progress-console-onclick", 'BuildCardExtension_progressBarClick', 0, function (element) {
+// Store references to handlers to avoid duplicates
+let pipelineClickHandler = null;
+let consoleClickHandler = null;
+let progressClickHandler = null;
+let successRerunHandler = null;
+let latestRerunHandler = null;
 
-    const dataContainer = document.querySelector(".bct-progress-console-onclick-params");;
-    const href = dataContainer.dataset.fillDialogHref;
-    const title = dataContainer.dataset.fillDialogTitle;
-
-    element.addEventListener('click', () => {
-        buildPipeline.fillDialog(href, title);
-    });
+// Common utilities
+const parseDataAttributes = (container) => ({
+    id: parseInt(container.dataset.showSpinnerId, 10),
+    buildExtId: container.dataset.rerunBuildExtId,
+    dependencyIds: container.dataset.rerunBuildDependencyIds
+        .split(',')
+        .filter(Boolean)
+        .map(id => parseInt(id, 10))
 });
 
-Behaviour.specify(".bct-console-icon-onclick", 'BuildCardExtension_consoleIconClick', 0, function (element) {
+// Dialog handlers
+const handleDialogClick = (dataContainer) => {
+    const { fillDialogHref: href, fillDialogTitle: title } = dataContainer.dataset;
+    buildPipeline.fillDialog(href, title);
+};
 
-    const dataContainer = document.querySelector(".bct-console-icon-onclick-params");
-    const href = dataContainer.dataset.fillDialogHref;
-    const title = dataContainer.dataset.fillDialogTitle;
+// Rerun build handlers
+const handleRerunClick = (dataContainer) => {
+    const { id, buildExtId, dependencyIds } = parseDataAttributes(dataContainer);
+    buildPipeline.showSpinner(id);
+    buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
+};
 
-    element.addEventListener('click', () => {
-        buildPipeline.fillDialog(href, title);
-    });
-});
+// Create delegated event handler
+const createDelegatedHandler = (parentSelector, targetSelector, handlerFn, existingHandler) => {
+    const parentElement = document.querySelector(parentSelector);
+    if (!parentElement) {
+        console.warn(`Parent element not found: ${parentSelector}`);
+        return;
+    }
 
-Behaviour.specify(".bct-rerun-success-icon-onclick", 'BuildCardExtension_successRerunClick', 0, function(element) {
+    // Remove existing handler if it exists
+    if (existingHandler) {
+        parentElement.removeEventListener('click', existingHandler);
+    }
 
-    const dataContainer = document.querySelector(".bct-rerun-success-icon-onclick-params");
-    const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
-    const buildExtId = dataContainer.dataset.rerunBuildExtId;
-    const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
-        .split(',')
-        .filter(Boolean)
-        .map(id => parseInt(id, 10));
+    // Create new handler
+    const newHandler = (event) => {
+        const clickTarget = event.target.closest(targetSelector);
+        if (!clickTarget) return;
 
-    element.addEventListener('click', () => {
-        buildPipeline.showSpinner(id);
-        buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
-    });
-});
+        // All data containers follow the pattern: selector + '-params'
+        const dataContainer = document.querySelector(targetSelector + '-params');
+        if (!dataContainer) {
+            console.warn('Data container not found');
+            return;
+        }
 
-Behaviour.specify(".bct-rerun-latest-build-onclick", 'BuildCardExtension_latestRerunClick', 0, function(element) {
+        handlerFn(dataContainer);
+    };
 
-    const dataContainer = document.querySelector(".bct-rerun-latest-build-onclick-params");
-    const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
-    const buildExtId = dataContainer.dataset.rerunBuildExtId;
-    const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
-        .split(',')
-        .filter(Boolean)
-        .map(id => parseInt(id, 10));
+    // Add the new handler
+    parentElement.addEventListener('click', newHandler);
+    return newHandler;
+};
 
-    element.addEventListener('click', () => {
-        buildPipeline.showSpinner(id);
-        buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
-    });
-});
+// Register behaviours using delegation pattern
+Behaviour.specify(
+    ".bct-progress-console-onclick",
+    'BuildCardExtension_progressBarClick',
+    0,
+    function() {
+        progressClickHandler = createDelegatedHandler(
+            '.pipelines',
+            '.bct-progress-console-onclick',
+            handleDialogClick,
+            progressClickHandler
+        );
+    }
+);
+
+Behaviour.specify(
+    ".bct-console-icon-onclick",
+    'BuildCardExtension_consoleIconClick',
+    0,
+    function() {
+        consoleClickHandler = createDelegatedHandler(
+            '.pipelines',
+            '.bct-console-icon-onclick',
+            handleDialogClick,
+            consoleClickHandler
+        );
+    }
+);
+
+Behaviour.specify(
+    ".bct-rerun-success-icon-onclick",
+    'BuildCardExtension_successRerunClick',
+    0,
+    function() {
+        successRerunHandler = createDelegatedHandler(
+            '.pipelines',
+            '.bct-rerun-success-icon-onclick',
+            handleRerunClick,
+            successRerunHandler
+        );
+    }
+);
+
+Behaviour.specify(
+    ".bct-rerun-latest-build-onclick",
+    'BuildCardExtension_latestRerunClick',
+    0,
+    function() {
+        latestRerunHandler = createDelegatedHandler(
+            '.pipelines',
+            '.bct-rerun-latest-build-onclick',
+            handleRerunClick,
+            latestRerunHandler
+        );
+    }
+);
+
+Behaviour.specify(
+    ".bct-rerun-failed-not-manual-build-onclick",
+    'BuildCardExtension_failedNotManualRerunClick',
+    0,
+    function() {
+        pipelineClickHandler = createDelegatedHandler(
+            '.pipelines',
+            '.bct-rerun-failed-not-manual-build-onclick',
+            handleRerunClick,
+            pipelineClickHandler
+        );
+    }
+);
+
+//
+// Behaviour.specify(".bct-progress-console-onclick", 'BuildCardExtension_progressBarClick', 0, function (element) {
+//
+//     const dataContainer = document.querySelector(".bct-progress-console-onclick-params");;
+//     const href = dataContainer.dataset.fillDialogHref;
+//     const title = dataContainer.dataset.fillDialogTitle;
+//
+//     element.addEventListener('click', () => {
+//         buildPipeline.fillDialog(href, title);
+//     });
+// });
+//
+// Behaviour.specify(".bct-console-icon-onclick", 'BuildCardExtension_consoleIconClick', 0, function (element) {
+//
+//     const dataContainer = document.querySelector(".bct-console-icon-onclick-params");
+//     const href = dataContainer.dataset.fillDialogHref;
+//     const title = dataContainer.dataset.fillDialogTitle;
+//
+//     element.addEventListener('click', () => {
+//         buildPipeline.fillDialog(href, title);
+//     });
+// });
+//
+// Behaviour.specify(".bct-rerun-success-icon-onclick", 'BuildCardExtension_successRerunClick', 0, function(element) {
+//
+//     const dataContainer = document.querySelector(".bct-rerun-success-icon-onclick-params");
+//     const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
+//     const buildExtId = dataContainer.dataset.rerunBuildExtId;
+//     const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
+//         .split(',')
+//         .filter(Boolean)
+//         .map(id => parseInt(id, 10));
+//
+//     element.addEventListener('click', () => {
+//         buildPipeline.showSpinner(id);
+//         buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
+//     });
+// });
+//
+// Behaviour.specify(".bct-rerun-latest-build-onclick", 'BuildCardExtension_latestRerunClick', 0, function(element) {
+//
+//     const dataContainer = document.querySelector(".bct-rerun-failed-latest-build-onclick-params");
+//     const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
+//     const buildExtId = dataContainer.dataset.rerunBuildExtId;
+//     const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
+//         .split(',')
+//         .filter(Boolean)
+//         .map(id => parseInt(id, 10));
+//
+//     element.addEventListener('click', () => {
+//         buildPipeline.showSpinner(id);
+//         buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
+//     });
+// });
+//
+// Behaviour.specify(".bct-rerun-failed-not-manual-build-onclick", 'BuildCardExtension_failedNotManualRerunClick', 0, function(element) {
+//     const pipelineWrapper = document.querySelector('.pipelines');
+//     if (!pipelineWrapper) {
+//         console.warn('Pipeline not found');
+//         return;
+//     }
+//
+//     pipelineWrapper.addEventListener('click', function(event) {
+//         console.log("Clicked on pipeline wrapper");
+//         const clickTarget = event.target.closest('.bct-rerun-failed-not-manual-build-onclick');
+//         if (!clickTarget) return;
+//
+//         const dataContainer = clickTarget.previousElementSibling;
+//
+//         const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
+//         console.log("ID:", id);
+//         const buildExtId = dataContainer.dataset.rerunBuildExtId;
+//         console.log("BuildExtId:", buildExtId);
+//         const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
+//             .split(',')
+//             .filter(Boolean)
+//             .map(id => parseInt(id, 10));
+//         console.log("DependencyIds:", dependencyIds);
+//
+//         buildPipeline.showSpinner(id);
+//         buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
+//     });
+// });
+//
 
 
+// // Generic handler function for dialog-based clicks
+// function createDialogClickHandler(paramsSelector, clickSelector, behaviourName) {
+//     Behaviour.specify(clickSelector, behaviourName, 0, function(element) {
+//         // Find the closest params container to this specific element
+//         const dataContainer = element.closest('.build-card').querySelector(paramsSelector);
+//         if (!dataContainer) return;
+//
+//         const href = dataContainer.dataset.fillDialogHref;
+//         const title = dataContainer.dataset.fillDialogTitle;
+//
+//         element.addEventListener('click', () => {
+//             buildPipeline.fillDialog(href, title);
+//         });
+//     });
+// }
+//
+// // Generic handler function for rerun-based clicks
+// function createRerunClickHandler(paramsSelector, clickSelector, behaviourName) {
+//     Behaviour.specify(clickSelector, behaviourName, 0, function(element) {
+//         // Find the closest params container to this specific element
+//         const dataContainer = element.closest('.build-card').querySelector(paramsSelector);
+//         if (!dataContainer) return;
+//
+//         const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
+//         const buildExtId = dataContainer.dataset.rerunBuildExtId;
+//         const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
+//             .split(',')
+//             .filter(Boolean)
+//             .map(id => parseInt(id, 10));
+//
+//         element.addEventListener('click', () => {
+//             buildPipeline.showSpinner(id);
+//             buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
+//         });
+//     });
+// }
+//
+// // Dialog-based handlers
+// createDialogClickHandler(
+//     '.bct-progress-console-onclick-params',
+//     '.bct-progress-console-onclick',
+//     'BuildCardExtension_progressBarClick'
+// );
+//
+// createDialogClickHandler(
+//     '.bct-console-icon-onclick-params',
+//     '.bct-console-icon-onclick',
+//     'BuildCardExtension_consoleIconClick'
+// );
+//
+// // Rerun-based handlers
+// createRerunClickHandler(
+//     '.bct-rerun-success-icon-onclick-params',
+//     '.bct-rerun-success-icon-onclick',
+//     'BuildCardExtension_successRerunClick'
+// );
+//
+// createRerunClickHandler(
+//     '.bct-rerun-failed-latest-build-onclick-params',
+//     '.bct-rerun-failed-latest-build-onclick',
+//     'BuildCardExtension_latestRerunClick'
+// );
+//
+// createRerunClickHandler(
+//     '.bct-rerun-failed-not-manual-build-onclick-params',
+//     '.bct-rerun-failed-not-manual-build-onclick',
+//     'BuildCardExtension_failedNotManualRerunClick'
+// );
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index 538a74e6..1b69912d 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -118,8 +118,8 @@
                     {{#if ${it.triggerOnlyLatestJob}}}
                         {{#if build.isLatestBuild}}
                             {{#if build.isUpstreamBuildLatest}}
-                            <span class="bct-rerun-latest-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
-                            <span class="bct-rerun-latest-build-onclick">
+                            <span class="bct-rerun-failed-latest-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
+                            <span class="bct-rerun-failed-latest-build-onclick">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
                             </span>
                             {{/if}}
@@ -131,10 +131,11 @@
                                 <h1>Shlomo2</h1>
                             </span>
                         {{else}}
-                            <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.rerunBuild({{id}}, '{{build.extId}}', [{{build.dependencyIds}}])">
+                            <span class="bct-rerun-failed-not-manual-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
+                            <span class="bct-rerun-failed-not-manual-build-onclick">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
-                                <h1>Shlomo3</h1>
                             </span>
+            <h1>Shlomo3</h1>
                         {{/if}}
                     {{/if}}
                 {{/if}}
@@ -146,11 +147,13 @@
                     <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.triggerBuild({{id}}, '{{upstream.projectName}}', {{upstream.buildNumber}}, '{{project.name}}', [{{build.dependencyIds}}])">
                         <l:icon src="icon-clock icon-sm" alt="trigger" />
                     </span>
+            <h1>SHLOMO4</h1>
                     {{/if}}
                 {{else}}
                 <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.triggerBuild({{id}}, '{{upstream.projectName}}', {{upstream.buildNumber}}, '{{project.name}}', [{{build.dependencyIds}}])">
                     <l:icon src="icon-clock icon-sm" alt="trigger" />
                 </span>
+            <h1>SHLOMO5</h1>
                 {{/if}}
             {{/if}}
         </div>

From 047a7471a1271b59ce19d4ea2ad9188aa2a616dc Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 29 Oct 2024 21:44:33 -0400
Subject: [PATCH 09/59] fix:
 https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly\#L140

---
 .../build-card-template-onclicks.js           | 39 +++++++++++++++++--
 .../buildCardTemplate.jelly                   | 13 ++++---
 2 files changed, 44 insertions(+), 8 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 7def0a23..665a89e1 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -4,6 +4,7 @@ let consoleClickHandler = null;
 let progressClickHandler = null;
 let successRerunHandler = null;
 let latestRerunHandler = null;
+let triggerBuildHandler = null;
 
 // Common utilities
 const parseDataAttributes = (container) => ({
@@ -15,6 +16,17 @@ const parseDataAttributes = (container) => ({
         .map(id => parseInt(id, 10))
 });
 
+const parseTriggerAttributes = (container) => ({
+    id: parseInt(container.dataset.showSpinnerId, 10),
+    upstreamProjectName: container.dataset.upstreamProjectName,
+    upstreamBuildNumber: parseInt(container.dataset.upstreamBuildNumber, 10),
+    projectName: container.dataset.projectName,
+    dependencyIds: container.dataset.dependencyIds
+        .split(',')
+        .filter(Boolean)
+        .map(id => parseInt(id, 10))
+});
+
 // Dialog handlers
 const handleDialogClick = (dataContainer) => {
     const { fillDialogHref: href, fillDialogTitle: title } = dataContainer.dataset;
@@ -28,6 +40,13 @@ const handleRerunClick = (dataContainer) => {
     buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
 };
 
+// Trigger build handler
+const handleTriggerBuild = (dataContainer) => {
+    const { id, upstreamProjectName, upstreamBuildNumber, projectName, dependencyIds } = parseTriggerAttributes(dataContainer);
+    buildPipeline.showSpinner(id);
+    buildPipeline.triggerBuild(id, upstreamProjectName, upstreamBuildNumber, projectName, dependencyIds);
+};
+
 // Create delegated event handler
 const createDelegatedHandler = (parentSelector, targetSelector, handlerFn, existingHandler) => {
     const parentElement = document.querySelector(parentSelector);
@@ -61,7 +80,7 @@ const createDelegatedHandler = (parentSelector, targetSelector, handlerFn, exist
     return newHandler;
 };
 
-// Register behaviours using delegation pattern
+// Register behaviours
 Behaviour.specify(
     ".bct-progress-console-onclick",
     'BuildCardExtension_progressBarClick',
@@ -105,13 +124,13 @@ Behaviour.specify(
 );
 
 Behaviour.specify(
-    ".bct-rerun-latest-build-onclick",
+    ".bct-rerun-failed-latest-build-onclick", // Changed to match HTML class
     'BuildCardExtension_latestRerunClick',
     0,
     function() {
         latestRerunHandler = createDelegatedHandler(
             '.pipelines',
-            '.bct-rerun-latest-build-onclick',
+            '.bct-rerun-failed-latest-build-onclick', // Changed to match HTML class
             handleRerunClick,
             latestRerunHandler
         );
@@ -132,6 +151,20 @@ Behaviour.specify(
     }
 );
 
+Behaviour.specify(
+    ".bct-trigger-build-onclick",
+    'BuildCardExtension_triggerBuildClick',
+    0,
+    function() {
+        triggerBuildHandler = createDelegatedHandler(
+            '.pipelines',
+            '.bct-trigger-build-onclick',
+            handleTriggerBuild,
+            triggerBuildHandler
+        );
+    }
+);
+
 //
 // Behaviour.specify(".bct-progress-console-onclick", 'BuildCardExtension_progressBarClick', 0, function (element) {
 //
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index 1b69912d..1a265d94 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -112,6 +112,7 @@
                     <span class="bct-rerun-success-icon-onclick">
                         <l:icon src="icon-clock icon-sm" alt="re-run" />
                     </span>
+                        <h1>test1</h1>
                     </j:if>
                     {{/if}}
                 {{else}}
@@ -122,20 +123,21 @@
                             <span class="bct-rerun-failed-latest-build-onclick">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
                             </span>
+                            <h1>test2</h1>
                             {{/if}}
                         {{/if}}
                     {{else}}
                         {{#if build.isManual}}
                             <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.triggerBuild({{id}}, '{{upstream.projectName}}', {{upstream.buildNumber}}, '{{project.name}}', [{{build.dependencyIds}}])">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
-                                <h1>Shlomo2</h1>
+                                <h1>test3</h1>
                             </span>
                         {{else}}
                             <span class="bct-rerun-failed-not-manual-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
                             <span class="bct-rerun-failed-not-manual-build-onclick">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
                             </span>
-            <h1>Shlomo3</h1>
+                            <h1>test4</h1>
                         {{/if}}
                     {{/if}}
                 {{/if}}
@@ -144,16 +146,17 @@
             {{#if build.isReadyToBeManuallyBuilt}}
                 {{#if ${it.triggerOnlyLatestJob}}}
                     {{#if build.isUpstreamBuildLatestSuccess}}
-                    <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.triggerBuild({{id}}, '{{upstream.projectName}}', {{upstream.buildNumber}}, '{{project.name}}', [{{build.dependencyIds}}])">
+                    <span class="bct-trigger-build-onclick-params" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
+                    <span class="bct-trigger-build-onclick">
                         <l:icon src="icon-clock icon-sm" alt="trigger" />
                     </span>
-            <h1>SHLOMO4</h1>
+                    <h1>test5</h1>
                     {{/if}}
                 {{else}}
                 <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.triggerBuild({{id}}, '{{upstream.projectName}}', {{upstream.buildNumber}}, '{{project.name}}', [{{build.dependencyIds}}])">
                     <l:icon src="icon-clock icon-sm" alt="trigger" />
                 </span>
-            <h1>SHLOMO5</h1>
+                <h1>test6</h1>
                 {{/if}}
             {{/if}}
         </div>

From 6ef42407e9c91b247d8cd7253e54f4d1ee2957ec Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 29 Oct 2024 22:04:32 -0400
Subject: [PATCH 10/59] fix:
 https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly\#L145

---
 .../build-card-template-onclicks.js           | 20 +++++++++++++++++--
 .../buildCardTemplate.jelly                   |  8 +++++---
 2 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 665a89e1..baf79599 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -5,6 +5,8 @@ let progressClickHandler = null;
 let successRerunHandler = null;
 let latestRerunHandler = null;
 let triggerBuildHandler = null;
+let triggerManualBuildLatestHandler = null;
+let triggerManualBuildHandler = null;
 
 // Common utilities
 const parseDataAttributes = (container) => ({
@@ -152,19 +154,33 @@ Behaviour.specify(
 );
 
 Behaviour.specify(
-    ".bct-trigger-build-onclick",
+    ".bct-trigger-manual-build-latest-onclick",
     'BuildCardExtension_triggerBuildClick',
     0,
     function() {
         triggerBuildHandler = createDelegatedHandler(
             '.pipelines',
-            '.bct-trigger-build-onclick',
+            '.bct-trigger-manual-build-latest-onclick',
             handleTriggerBuild,
             triggerBuildHandler
         );
     }
 );
 
+Behaviour.specify(
+    ".bct-trigger-manual-build-onclick",
+    'BuildCardExtension_triggerManualBuildClick',
+    0,
+    function() {
+        triggerManualBuildHandler = createDelegatedHandler(
+            '.pipelines',
+            '.bct-trigger-manual-build-onclick',
+            handleTriggerBuild,
+            triggerManualBuildHandler
+        );
+    }
+);
+
 //
 // Behaviour.specify(".bct-progress-console-onclick", 'BuildCardExtension_progressBarClick', 0, function (element) {
 //
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index 1a265d94..00759455 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -146,14 +146,16 @@
             {{#if build.isReadyToBeManuallyBuilt}}
                 {{#if ${it.triggerOnlyLatestJob}}}
                     {{#if build.isUpstreamBuildLatestSuccess}}
-                    <span class="bct-trigger-build-onclick-params" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
-                    <span class="bct-trigger-build-onclick">
+                    <span class="bct-trigger-manual-build-latest-onclick-params" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
+                    <span class="bct-trigger-manual-build-latest-onclick">
                         <l:icon src="icon-clock icon-sm" alt="trigger" />
                     </span>
                     <h1>test5</h1>
                     {{/if}}
                 {{else}}
-                <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.triggerBuild({{id}}, '{{upstream.projectName}}', {{upstream.buildNumber}}, '{{project.name}}', [{{build.dependencyIds}}])">
+
+                <span class="bct-trigger-manual-build-onclick-params" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
+                <span class="bct-trigger-manual-build-onclick">
                     <l:icon src="icon-clock icon-sm" alt="trigger" />
                 </span>
                 <h1>test6</h1>

From a3b8458724744076a72e388f4610187c7b539c37 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 29 Oct 2024 22:07:50 -0400
Subject: [PATCH 11/59] dynamic behaviour.specify

---
 .../build-card-template-onclicks.js           | 180 +-----------------
 1 file changed, 4 insertions(+), 176 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index baf79599..3a48a242 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -8,7 +8,6 @@ let triggerBuildHandler = null;
 let triggerManualBuildLatestHandler = null;
 let triggerManualBuildHandler = null;
 
-// Common utilities
 const parseDataAttributes = (container) => ({
     id: parseInt(container.dataset.showSpinnerId, 10),
     buildExtId: container.dataset.rerunBuildExtId,
@@ -29,60 +28,43 @@ const parseTriggerAttributes = (container) => ({
         .map(id => parseInt(id, 10))
 });
 
-// Dialog handlers
 const handleDialogClick = (dataContainer) => {
     const { fillDialogHref: href, fillDialogTitle: title } = dataContainer.dataset;
     buildPipeline.fillDialog(href, title);
 };
 
-// Rerun build handlers
 const handleRerunClick = (dataContainer) => {
     const { id, buildExtId, dependencyIds } = parseDataAttributes(dataContainer);
     buildPipeline.showSpinner(id);
     buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
 };
 
-// Trigger build handler
 const handleTriggerBuild = (dataContainer) => {
     const { id, upstreamProjectName, upstreamBuildNumber, projectName, dependencyIds } = parseTriggerAttributes(dataContainer);
     buildPipeline.showSpinner(id);
     buildPipeline.triggerBuild(id, upstreamProjectName, upstreamBuildNumber, projectName, dependencyIds);
 };
 
-// Create delegated event handler
 const createDelegatedHandler = (parentSelector, targetSelector, handlerFn, existingHandler) => {
+
     const parentElement = document.querySelector(parentSelector);
-    if (!parentElement) {
-        console.warn(`Parent element not found: ${parentSelector}`);
-        return;
-    }
 
-    // Remove existing handler if it exists
     if (existingHandler) {
         parentElement.removeEventListener('click', existingHandler);
     }
 
-    // Create new handler
     const newHandler = (event) => {
         const clickTarget = event.target.closest(targetSelector);
         if (!clickTarget) return;
 
-        // All data containers follow the pattern: selector + '-params'
         const dataContainer = document.querySelector(targetSelector + '-params');
-        if (!dataContainer) {
-            console.warn('Data container not found');
-            return;
-        }
-
         handlerFn(dataContainer);
     };
 
-    // Add the new handler
     parentElement.addEventListener('click', newHandler);
     return newHandler;
 };
 
-// Register behaviours
 Behaviour.specify(
     ".bct-progress-console-onclick",
     'BuildCardExtension_progressBarClick',
@@ -126,13 +108,13 @@ Behaviour.specify(
 );
 
 Behaviour.specify(
-    ".bct-rerun-failed-latest-build-onclick", // Changed to match HTML class
+    ".bct-rerun-failed-latest-build-onclick",
     'BuildCardExtension_latestRerunClick',
     0,
     function() {
         latestRerunHandler = createDelegatedHandler(
             '.pipelines',
-            '.bct-rerun-failed-latest-build-onclick', // Changed to match HTML class
+            '.bct-rerun-failed-latest-build-onclick',
             handleRerunClick,
             latestRerunHandler
         );
@@ -158,7 +140,7 @@ Behaviour.specify(
     'BuildCardExtension_triggerBuildClick',
     0,
     function() {
-        triggerBuildHandler = createDelegatedHandler(
+        triggerManualBuildLatestHandler = createDelegatedHandler(
             '.pipelines',
             '.bct-trigger-manual-build-latest-onclick',
             handleTriggerBuild,
@@ -181,157 +163,3 @@ Behaviour.specify(
     }
 );
 
-//
-// Behaviour.specify(".bct-progress-console-onclick", 'BuildCardExtension_progressBarClick', 0, function (element) {
-//
-//     const dataContainer = document.querySelector(".bct-progress-console-onclick-params");;
-//     const href = dataContainer.dataset.fillDialogHref;
-//     const title = dataContainer.dataset.fillDialogTitle;
-//
-//     element.addEventListener('click', () => {
-//         buildPipeline.fillDialog(href, title);
-//     });
-// });
-//
-// Behaviour.specify(".bct-console-icon-onclick", 'BuildCardExtension_consoleIconClick', 0, function (element) {
-//
-//     const dataContainer = document.querySelector(".bct-console-icon-onclick-params");
-//     const href = dataContainer.dataset.fillDialogHref;
-//     const title = dataContainer.dataset.fillDialogTitle;
-//
-//     element.addEventListener('click', () => {
-//         buildPipeline.fillDialog(href, title);
-//     });
-// });
-//
-// Behaviour.specify(".bct-rerun-success-icon-onclick", 'BuildCardExtension_successRerunClick', 0, function(element) {
-//
-//     const dataContainer = document.querySelector(".bct-rerun-success-icon-onclick-params");
-//     const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
-//     const buildExtId = dataContainer.dataset.rerunBuildExtId;
-//     const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
-//         .split(',')
-//         .filter(Boolean)
-//         .map(id => parseInt(id, 10));
-//
-//     element.addEventListener('click', () => {
-//         buildPipeline.showSpinner(id);
-//         buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
-//     });
-// });
-//
-// Behaviour.specify(".bct-rerun-latest-build-onclick", 'BuildCardExtension_latestRerunClick', 0, function(element) {
-//
-//     const dataContainer = document.querySelector(".bct-rerun-failed-latest-build-onclick-params");
-//     const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
-//     const buildExtId = dataContainer.dataset.rerunBuildExtId;
-//     const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
-//         .split(',')
-//         .filter(Boolean)
-//         .map(id => parseInt(id, 10));
-//
-//     element.addEventListener('click', () => {
-//         buildPipeline.showSpinner(id);
-//         buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
-//     });
-// });
-//
-// Behaviour.specify(".bct-rerun-failed-not-manual-build-onclick", 'BuildCardExtension_failedNotManualRerunClick', 0, function(element) {
-//     const pipelineWrapper = document.querySelector('.pipelines');
-//     if (!pipelineWrapper) {
-//         console.warn('Pipeline not found');
-//         return;
-//     }
-//
-//     pipelineWrapper.addEventListener('click', function(event) {
-//         console.log("Clicked on pipeline wrapper");
-//         const clickTarget = event.target.closest('.bct-rerun-failed-not-manual-build-onclick');
-//         if (!clickTarget) return;
-//
-//         const dataContainer = clickTarget.previousElementSibling;
-//
-//         const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
-//         console.log("ID:", id);
-//         const buildExtId = dataContainer.dataset.rerunBuildExtId;
-//         console.log("BuildExtId:", buildExtId);
-//         const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
-//             .split(',')
-//             .filter(Boolean)
-//             .map(id => parseInt(id, 10));
-//         console.log("DependencyIds:", dependencyIds);
-//
-//         buildPipeline.showSpinner(id);
-//         buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
-//     });
-// });
-//
-
-
-// // Generic handler function for dialog-based clicks
-// function createDialogClickHandler(paramsSelector, clickSelector, behaviourName) {
-//     Behaviour.specify(clickSelector, behaviourName, 0, function(element) {
-//         // Find the closest params container to this specific element
-//         const dataContainer = element.closest('.build-card').querySelector(paramsSelector);
-//         if (!dataContainer) return;
-//
-//         const href = dataContainer.dataset.fillDialogHref;
-//         const title = dataContainer.dataset.fillDialogTitle;
-//
-//         element.addEventListener('click', () => {
-//             buildPipeline.fillDialog(href, title);
-//         });
-//     });
-// }
-//
-// // Generic handler function for rerun-based clicks
-// function createRerunClickHandler(paramsSelector, clickSelector, behaviourName) {
-//     Behaviour.specify(clickSelector, behaviourName, 0, function(element) {
-//         // Find the closest params container to this specific element
-//         const dataContainer = element.closest('.build-card').querySelector(paramsSelector);
-//         if (!dataContainer) return;
-//
-//         const id = parseInt(dataContainer.dataset.showSpinnerId, 10);
-//         const buildExtId = dataContainer.dataset.rerunBuildExtId;
-//         const dependencyIds = dataContainer.dataset.rerunBuildDependencyIds
-//             .split(',')
-//             .filter(Boolean)
-//             .map(id => parseInt(id, 10));
-//
-//         element.addEventListener('click', () => {
-//             buildPipeline.showSpinner(id);
-//             buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
-//         });
-//     });
-// }
-//
-// // Dialog-based handlers
-// createDialogClickHandler(
-//     '.bct-progress-console-onclick-params',
-//     '.bct-progress-console-onclick',
-//     'BuildCardExtension_progressBarClick'
-// );
-//
-// createDialogClickHandler(
-//     '.bct-console-icon-onclick-params',
-//     '.bct-console-icon-onclick',
-//     'BuildCardExtension_consoleIconClick'
-// );
-//
-// // Rerun-based handlers
-// createRerunClickHandler(
-//     '.bct-rerun-success-icon-onclick-params',
-//     '.bct-rerun-success-icon-onclick',
-//     'BuildCardExtension_successRerunClick'
-// );
-//
-// createRerunClickHandler(
-//     '.bct-rerun-failed-latest-build-onclick-params',
-//     '.bct-rerun-failed-latest-build-onclick',
-//     'BuildCardExtension_latestRerunClick'
-// );
-//
-// createRerunClickHandler(
-//     '.bct-rerun-failed-not-manual-build-onclick-params',
-//     '.bct-rerun-failed-not-manual-build-onclick',
-//     'BuildCardExtension_failedNotManualRerunClick'
-// );

From ed0c9e57e87fae277d354a837cf8529ff2de47f5 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 29 Oct 2024 22:08:33 -0400
Subject: [PATCH 12/59] dynamic behaviour.specify

---
 .../extension/BuildCardExtension/build-card-template-onclicks.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 3a48a242..e95bf447 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -1,4 +1,3 @@
-// Store references to handlers to avoid duplicates
 let pipelineClickHandler = null;
 let consoleClickHandler = null;
 let progressClickHandler = null;

From 30476d5fab7fded5d376c0de2ea062018687f35c Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 13:54:20 -0400
Subject: [PATCH 13/59] update names, update java method, all working

---
 .../hudson/plugin/util/ProjectUtil.java       |  2 +-
 .../build-card-template-onclicks.js           | 62 ++++++++++++-------
 .../buildCardTemplate.jelly                   | 24 +++----
 3 files changed, 49 insertions(+), 39 deletions(-)

diff --git a/src/main/java/au/com/centrumsystems/hudson/plugin/util/ProjectUtil.java b/src/main/java/au/com/centrumsystems/hudson/plugin/util/ProjectUtil.java
index f2787846..942211cb 100644
--- a/src/main/java/au/com/centrumsystems/hudson/plugin/util/ProjectUtil.java
+++ b/src/main/java/au/com/centrumsystems/hudson/plugin/util/ProjectUtil.java
@@ -105,7 +105,7 @@ public static boolean isManualTrigger(final AbstractProject<?, ?> upstreamProjec
                     final String manualDownstreamProjects = ((BuildPipelineTrigger) upstreamPub).getDownstreamProjectNames();
                     final String[] downstreamProjs = manualDownstreamProjects.split(",");
                     for (final String nextProj : downstreamProjs) {
-                        if (Jenkins.getInstance().getItem(nextProj.trim(), upstreamProject) == downstreamProject) {
+                        if (Jenkins.getInstance().getItem(nextProj.trim(), upstreamProject).getName().equals(downstreamProject.getName())) {
                             manualTrigger = true;
                             break;
                         }
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index e95bf447..94dca262 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -1,9 +1,9 @@
-let pipelineClickHandler = null;
-let consoleClickHandler = null;
-let progressClickHandler = null;
+let progressBarClickHandler = null;
+let consoleIconClickHandler = null;
 let successRerunHandler = null;
-let latestRerunHandler = null;
-let triggerBuildHandler = null;
+let latestFailedRerunHandler = null;
+let manualFailedRerunHandler = null;
+let failedRerunHandler = null;
 let triggerManualBuildLatestHandler = null;
 let triggerManualBuildHandler = null;
 
@@ -29,6 +29,7 @@ const parseTriggerAttributes = (container) => ({
 
 const handleDialogClick = (dataContainer) => {
     const { fillDialogHref: href, fillDialogTitle: title } = dataContainer.dataset;
+    console.log('handleDialogClick', href, title);
     buildPipeline.fillDialog(href, title);
 };
 
@@ -45,7 +46,6 @@ const handleTriggerBuild = (dataContainer) => {
 };
 
 const createDelegatedHandler = (parentSelector, targetSelector, handlerFn, existingHandler) => {
-
     const parentElement = document.querySelector(parentSelector);
 
     if (existingHandler) {
@@ -56,7 +56,9 @@ const createDelegatedHandler = (parentSelector, targetSelector, handlerFn, exist
         const clickTarget = event.target.closest(targetSelector);
         if (!clickTarget) return;
 
-        const dataContainer = document.querySelector(targetSelector + '-params');
+        const buildCard = clickTarget.closest('.build-card');
+        const dataContainer = buildCard.querySelector(targetSelector + '-params');
+
         handlerFn(dataContainer);
     };
 
@@ -65,15 +67,15 @@ const createDelegatedHandler = (parentSelector, targetSelector, handlerFn, exist
 };
 
 Behaviour.specify(
-    ".bct-progress-console-onclick",
+    ".bct-progress-bar-onclick",
     'BuildCardExtension_progressBarClick',
     0,
     function() {
-        progressClickHandler = createDelegatedHandler(
+        progressBarClickHandler = createDelegatedHandler(
             '.pipelines',
-            '.bct-progress-console-onclick',
+            '.bct-progress-bar-onclick',
             handleDialogClick,
-            progressClickHandler
+            progressBarClickHandler
         );
     }
 );
@@ -83,23 +85,23 @@ Behaviour.specify(
     'BuildCardExtension_consoleIconClick',
     0,
     function() {
-        consoleClickHandler = createDelegatedHandler(
+        consoleIconClickHandler = createDelegatedHandler(
             '.pipelines',
             '.bct-console-icon-onclick',
             handleDialogClick,
-            consoleClickHandler
+            consoleIconClickHandler
         );
     }
 );
 
 Behaviour.specify(
-    ".bct-rerun-success-icon-onclick",
+    ".bct-rerun-successful-build-onclick",
     'BuildCardExtension_successRerunClick',
     0,
     function() {
         successRerunHandler = createDelegatedHandler(
             '.pipelines',
-            '.bct-rerun-success-icon-onclick',
+            '.bct-rerun-successful-build-onclick',
             handleRerunClick,
             successRerunHandler
         );
@@ -108,28 +110,42 @@ Behaviour.specify(
 
 Behaviour.specify(
     ".bct-rerun-failed-latest-build-onclick",
-    'BuildCardExtension_latestRerunClick',
+    'BuildCardExtension_latestFailedRerunClick',
     0,
     function() {
-        latestRerunHandler = createDelegatedHandler(
+        latestFailedRerunHandler = createDelegatedHandler(
             '.pipelines',
             '.bct-rerun-failed-latest-build-onclick',
             handleRerunClick,
-            latestRerunHandler
+            latestFailedRerunHandler
+        );
+    }
+);
+
+Behaviour.specify(
+    ".bct-rerun-failed-manual-build-onclick",
+    'BuildCardExtension_failedManualRerunClick',
+    0,
+    function() {
+        manualFailedRerunHandler = createDelegatedHandler(
+            '.pipelines',
+            '.bct-rerun-failed-manual-build-onclick',
+            handleTriggerBuild,
+            manualFailedRerunHandler
         );
     }
 );
 
 Behaviour.specify(
-    ".bct-rerun-failed-not-manual-build-onclick",
+    ".bct-rerun-failed-build-onclick",
     'BuildCardExtension_failedNotManualRerunClick',
     0,
     function() {
-        pipelineClickHandler = createDelegatedHandler(
+        failedRerunHandler = createDelegatedHandler(
             '.pipelines',
-            '.bct-rerun-failed-not-manual-build-onclick',
+            '.bct-rerun-failed-build-onclick',
             handleRerunClick,
-            pipelineClickHandler
+            failedRerunHandler
         );
     }
 );
@@ -143,7 +159,7 @@ Behaviour.specify(
             '.pipelines',
             '.bct-trigger-manual-build-latest-onclick',
             handleTriggerBuild,
-            triggerBuildHandler
+            triggerManualBuildLatestHandler
         );
     }
 );
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index 00759455..dbe53222 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -61,8 +61,8 @@
         {{#unless project.disabled}}
         <div class="status-bar" id="status-bar-{{id}}">
             {{#if build.isBuilding}}
-                <span class="bct-progress-console-onclick-params" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
-                <div class="bct-progress-console-onclick">
+                <span class="bct-progress-bar-onclick-params" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
+                <div class="bct-progress-bar-onclick">
                     <table class="progress-bar" align="center">
                         <tbody>
                             <tr title="Estimated remaining time: {{build.estimatedRemainingTime}}">
@@ -108,11 +108,10 @@
                 {{#if build.isSuccess}}
                     {{#if ${!it.triggerOnlyLatestJob}}}
                     <j:if test="${it.hasBuildPermission()}">
-                    <span class="bct-rerun-success-icon-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
-                    <span class="bct-rerun-success-icon-onclick">
+                    <span class="bct-rerun-successful-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
+                    <span class="bct-rerun-successful-build-onclick">
                         <l:icon src="icon-clock icon-sm" alt="re-run" />
                     </span>
-                        <h1>test1</h1>
                     </j:if>
                     {{/if}}
                 {{else}}
@@ -123,21 +122,19 @@
                             <span class="bct-rerun-failed-latest-build-onclick">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
                             </span>
-                            <h1>test2</h1>
                             {{/if}}
                         {{/if}}
                     {{else}}
-                        {{#if build.isManual}}
-                            <span onclick="buildPipeline.showSpinner({{id}}); buildPipeline.triggerBuild({{id}}, '{{upstream.projectName}}', {{upstream.buildNumber}}, '{{project.name}}', [{{build.dependencyIds}}])">
+                        {{#if build.isManualTrigger}}
+                            <span class="bct-rerun-failed-manual-build-onclick-params" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
+                            <span class="bct-rerun-failed-manual-build-onclick">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
-                                <h1>test3</h1>
                             </span>
                         {{else}}
-                            <span class="bct-rerun-failed-not-manual-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
-                            <span class="bct-rerun-failed-not-manual-build-onclick">
+                            <span class="bct-rerun-failed-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
+                            <span class="bct-rerun-failed-build-onclick">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
                             </span>
-                            <h1>test4</h1>
                         {{/if}}
                     {{/if}}
                 {{/if}}
@@ -150,15 +147,12 @@
                     <span class="bct-trigger-manual-build-latest-onclick">
                         <l:icon src="icon-clock icon-sm" alt="trigger" />
                     </span>
-                    <h1>test5</h1>
                     {{/if}}
                 {{else}}
-
                 <span class="bct-trigger-manual-build-onclick-params" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
                 <span class="bct-trigger-manual-build-onclick">
                     <l:icon src="icon-clock icon-sm" alt="trigger" />
                 </span>
-                <h1>test6</h1>
                 {{/if}}
             {{/if}}
         </div>

From 557205125841b97ec4c17fd1afd0ab6ac95d5cf1 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 17:23:57 -0400
Subject: [PATCH 14/59] remove Behaviour.specify \ Use dynamic approach

---
 .../build-card-template-onclicks.js           | 225 ++++++------------
 1 file changed, 71 insertions(+), 154 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 94dca262..f4d4ce60 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -1,180 +1,97 @@
-let progressBarClickHandler = null;
-let consoleIconClickHandler = null;
-let successRerunHandler = null;
-let latestFailedRerunHandler = null;
-let manualFailedRerunHandler = null;
-let failedRerunHandler = null;
-let triggerManualBuildLatestHandler = null;
-let triggerManualBuildHandler = null;
-
-const parseDataAttributes = (container) => ({
-    id: parseInt(container.dataset.showSpinnerId, 10),
-    buildExtId: container.dataset.rerunBuildExtId,
-    dependencyIds: container.dataset.rerunBuildDependencyIds
-        .split(',')
-        .filter(Boolean)
-        .map(id => parseInt(id, 10))
-});
+const parseDataAttributes = function(container) {
+    return {
+        id: parseInt(container.dataset.showSpinnerId, 10),
+        buildExtId: container.dataset.rerunBuildExtId,
+        dependencyIds: container.dataset.rerunBuildDependencyIds
+            .split(",")
+            .filter(Boolean)
+            .map(function(id) {
+                return parseInt(id, 10);
+            })
+    };
+};
 
-const parseTriggerAttributes = (container) => ({
-    id: parseInt(container.dataset.showSpinnerId, 10),
-    upstreamProjectName: container.dataset.upstreamProjectName,
-    upstreamBuildNumber: parseInt(container.dataset.upstreamBuildNumber, 10),
-    projectName: container.dataset.projectName,
-    dependencyIds: container.dataset.dependencyIds
-        .split(',')
-        .filter(Boolean)
-        .map(id => parseInt(id, 10))
-});
+const parseTriggerAttributes = function(container) {
+    return {
+        id: parseInt(container.dataset.showSpinnerId, 10),
+        upstreamProjectName: container.dataset.upstreamProjectName,
+        upstreamBuildNumber: parseInt(container.dataset.upstreamBuildNumber, 10),
+        projectName: container.dataset.projectName,
+        dependencyIds: container.dataset.dependencyIds
+            .split(",")
+            .filter(Boolean)
+            .map(function(id) {
+                return parseInt(id, 10);
+            })
+    };
+};
 
-const handleDialogClick = (dataContainer) => {
-    const { fillDialogHref: href, fillDialogTitle: title } = dataContainer.dataset;
-    console.log('handleDialogClick', href, title);
+const handleDialogClick = function(dataContainer) {
+    const href = dataContainer.dataset.fillDialogHref;
+    const title = dataContainer.dataset.fillDialogTitle;
     buildPipeline.fillDialog(href, title);
 };
 
-const handleRerunClick = (dataContainer) => {
+const handleRerunClick = function(dataContainer) {
     const { id, buildExtId, dependencyIds } = parseDataAttributes(dataContainer);
     buildPipeline.showSpinner(id);
     buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
 };
 
-const handleTriggerBuild = (dataContainer) => {
+const handleTriggerBuild = function(dataContainer) {
     const { id, upstreamProjectName, upstreamBuildNumber, projectName, dependencyIds } = parseTriggerAttributes(dataContainer);
     buildPipeline.showSpinner(id);
     buildPipeline.triggerBuild(id, upstreamProjectName, upstreamBuildNumber, projectName, dependencyIds);
 };
 
-const createDelegatedHandler = (parentSelector, targetSelector, handlerFn, existingHandler) => {
-    const parentElement = document.querySelector(parentSelector);
-
-    if (existingHandler) {
-        parentElement.removeEventListener('click', existingHandler);
-    }
-
-    const newHandler = (event) => {
+const createClickHandler = function(parentElement, targetSelector, handlerFn) {
+    const newHandler = function(event) {
         const clickTarget = event.target.closest(targetSelector);
-        if (!clickTarget) return;
+        if (!clickTarget || !parentElement.contains(clickTarget)) return;
 
-        const buildCard = clickTarget.closest('.build-card');
-        const dataContainer = buildCard.querySelector(targetSelector + '-params');
+        const buildCard = clickTarget.closest(".build-card");
+        if (!buildCard) return;
 
+        const dataContainer = buildCard.querySelector(targetSelector + "-params");
         handlerFn(dataContainer);
     };
 
-    parentElement.addEventListener('click', newHandler);
-    return newHandler;
+    parentElement.addEventListener("click", newHandler);
 };
 
-Behaviour.specify(
-    ".bct-progress-bar-onclick",
-    'BuildCardExtension_progressBarClick',
-    0,
-    function() {
-        progressBarClickHandler = createDelegatedHandler(
-            '.pipelines',
-            '.bct-progress-bar-onclick',
-            handleDialogClick,
-            progressBarClickHandler
-        );
+const onclickElements = {
+    ".bct-progress-bar-onclick": {
+        handler: handleDialogClick
+    },
+    ".bct-console-icon-onclick": {
+        handler: handleDialogClick
+    },
+    ".bct-rerun-successful-build-onclick": {
+        handler: handleRerunClick
+    },
+    ".bct-rerun-failed-latest-build-onclick": {
+        handler: handleRerunClick
+    },
+    ".bct-rerun-failed-manual-build-onclick": {
+        handler: handleTriggerBuild
+    },
+    ".bct-rerun-failed-build-onclick": {
+        handler: handleRerunClick
+    },
+    ".bct-trigger-manual-build-latest-onclick": {
+        handler: handleTriggerBuild
+    },
+    ".bct-trigger-manual-build-onclick": {
+        handler: handleTriggerBuild
     }
-);
-
-Behaviour.specify(
-    ".bct-console-icon-onclick",
-    'BuildCardExtension_consoleIconClick',
-    0,
-    function() {
-        consoleIconClickHandler = createDelegatedHandler(
-            '.pipelines',
-            '.bct-console-icon-onclick',
-            handleDialogClick,
-            consoleIconClickHandler
-        );
-    }
-);
-
-Behaviour.specify(
-    ".bct-rerun-successful-build-onclick",
-    'BuildCardExtension_successRerunClick',
-    0,
-    function() {
-        successRerunHandler = createDelegatedHandler(
-            '.pipelines',
-            '.bct-rerun-successful-build-onclick',
-            handleRerunClick,
-            successRerunHandler
-        );
-    }
-);
-
-Behaviour.specify(
-    ".bct-rerun-failed-latest-build-onclick",
-    'BuildCardExtension_latestFailedRerunClick',
-    0,
-    function() {
-        latestFailedRerunHandler = createDelegatedHandler(
-            '.pipelines',
-            '.bct-rerun-failed-latest-build-onclick',
-            handleRerunClick,
-            latestFailedRerunHandler
-        );
-    }
-);
-
-Behaviour.specify(
-    ".bct-rerun-failed-manual-build-onclick",
-    'BuildCardExtension_failedManualRerunClick',
-    0,
-    function() {
-        manualFailedRerunHandler = createDelegatedHandler(
-            '.pipelines',
-            '.bct-rerun-failed-manual-build-onclick',
-            handleTriggerBuild,
-            manualFailedRerunHandler
-        );
-    }
-);
-
-Behaviour.specify(
-    ".bct-rerun-failed-build-onclick",
-    'BuildCardExtension_failedNotManualRerunClick',
-    0,
-    function() {
-        failedRerunHandler = createDelegatedHandler(
-            '.pipelines',
-            '.bct-rerun-failed-build-onclick',
-            handleRerunClick,
-            failedRerunHandler
-        );
-    }
-);
-
-Behaviour.specify(
-    ".bct-trigger-manual-build-latest-onclick",
-    'BuildCardExtension_triggerBuildClick',
-    0,
-    function() {
-        triggerManualBuildLatestHandler = createDelegatedHandler(
-            '.pipelines',
-            '.bct-trigger-manual-build-latest-onclick',
-            handleTriggerBuild,
-            triggerManualBuildLatestHandler
-        );
-    }
-);
+};
 
-Behaviour.specify(
-    ".bct-trigger-manual-build-onclick",
-    'BuildCardExtension_triggerManualBuildClick',
-    0,
-    function() {
-        triggerManualBuildHandler = createDelegatedHandler(
-            '.pipelines',
-            '.bct-trigger-manual-build-onclick',
-            handleTriggerBuild,
-            triggerManualBuildHandler
-        );
-    }
-);
+document.addEventListener("DOMContentLoaded", function () {
+    const parentElement = document.querySelector(".pipelines");
 
+    Object.entries(onclickElements).forEach(function(entry) {
+        const selector = entry[0];
+        const handlerConfig = entry[1];
+        createClickHandler(parentElement, selector, handlerConfig.handler);
+    });
+});

From ba67a4b32f5af3d5489c5b3fcd211c1ad3f2a56a Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 17:27:24 -0400
Subject: [PATCH 15/59] remove Behaviour.specify \ Use dynamic approach

---
 .../BuildCardExtension/build-card-template-onclicks.js   | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index f4d4ce60..d4e091df 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -5,9 +5,8 @@ const parseDataAttributes = function(container) {
         dependencyIds: container.dataset.rerunBuildDependencyIds
             .split(",")
             .filter(Boolean)
-            .map(function(id) {
-                return parseInt(id, 10);
-            })
+            .map(id => parseInt(id, 10))
+
     };
 };
 
@@ -20,9 +19,7 @@ const parseTriggerAttributes = function(container) {
         dependencyIds: container.dataset.dependencyIds
             .split(",")
             .filter(Boolean)
-            .map(function(id) {
-                return parseInt(id, 10);
-            })
+            .map(id => parseInt(id, 10))
     };
 };
 

From 9bf83a9cec7530283cc134a9dbadd7d1984c36f7 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 17:33:12 -0400
Subject: [PATCH 16/59] remove Behaviour.specify \ Use dynamic approach

---
 .../build-card-template-onclicks.js           | 25 +++++++++----------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index d4e091df..9184ad30 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -1,4 +1,4 @@
-const parseDataAttributes = function(container) {
+function parseDataAttributes(container) {
     return {
         id: parseInt(container.dataset.showSpinnerId, 10),
         buildExtId: container.dataset.rerunBuildExtId,
@@ -6,11 +6,10 @@ const parseDataAttributes = function(container) {
             .split(",")
             .filter(Boolean)
             .map(id => parseInt(id, 10))
-
     };
-};
+}
 
-const parseTriggerAttributes = function(container) {
+function parseTriggerAttributes(container) {
     return {
         id: parseInt(container.dataset.showSpinnerId, 10),
         upstreamProjectName: container.dataset.upstreamProjectName,
@@ -21,27 +20,27 @@ const parseTriggerAttributes = function(container) {
             .filter(Boolean)
             .map(id => parseInt(id, 10))
     };
-};
+}
 
-const handleDialogClick = function(dataContainer) {
+function handleDialogClick(dataContainer) {
     const href = dataContainer.dataset.fillDialogHref;
     const title = dataContainer.dataset.fillDialogTitle;
     buildPipeline.fillDialog(href, title);
-};
+}
 
-const handleRerunClick = function(dataContainer) {
+function handleRerunClick(dataContainer) {
     const { id, buildExtId, dependencyIds } = parseDataAttributes(dataContainer);
     buildPipeline.showSpinner(id);
     buildPipeline.rerunBuild(id, buildExtId, dependencyIds);
-};
+}
 
-const handleTriggerBuild = function(dataContainer) {
+function handleTriggerBuild(dataContainer) {
     const { id, upstreamProjectName, upstreamBuildNumber, projectName, dependencyIds } = parseTriggerAttributes(dataContainer);
     buildPipeline.showSpinner(id);
     buildPipeline.triggerBuild(id, upstreamProjectName, upstreamBuildNumber, projectName, dependencyIds);
-};
+}
 
-const createClickHandler = function(parentElement, targetSelector, handlerFn) {
+function createClickHandler(parentElement, targetSelector, handlerFn) {
     const newHandler = function(event) {
         const clickTarget = event.target.closest(targetSelector);
         if (!clickTarget || !parentElement.contains(clickTarget)) return;
@@ -54,7 +53,7 @@ const createClickHandler = function(parentElement, targetSelector, handlerFn) {
     };
 
     parentElement.addEventListener("click", newHandler);
-};
+}
 
 const onclickElements = {
     ".bct-progress-bar-onclick": {

From b5ccdd49910cb8a6490dbcac681be09c1affe0a0 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 18:38:47 -0400
Subject: [PATCH 17/59] Extract event handlers in

---
 .../BuildPipelineView/bpp-trigger-pipeline.js   | 17 +++++++++++++++++
 .../buildpipeline/BuildPipelineView/bpp.jelly   |  6 ++++--
 2 files changed, 21 insertions(+), 2 deletions(-)
 create mode 100644 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
new file mode 100644
index 00000000..033c3eb3
--- /dev/null
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -0,0 +1,17 @@
+Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.TriggerPipelineParameterized', 0, function(element) {
+    element.addEventListener('click', function() {
+
+        const paramsElement = element.previousElementSibling;
+        const href = paramsElement.dataset.fillDialogHref;
+        const title = paramsElement.dataset.fillDialogTitle;
+
+        buildPipeline.fillDialog(href, title);
+
+    });
+});
+
+Behaviour.specify(".bpp-trigger-pipeline-button", 'BuildPipelineView.TriggerPipeline', 0, function(element) {
+    element.addEventListener('click', function(e) {
+        document.getElementById('triggerPipelineForm').submit();
+    });
+});
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index f349bfc8..6198d6ad 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -12,6 +12,7 @@
     </j:if>
 
     <st:adjunct includes="io.jenkins.plugins.jquery3"/>
+    <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.BuildPipelineView.bpp-trigger-pipeline"/>
     <script src="${rootURL}/plugin/build-pipeline-plugin/js/jquery-migrate-1.2.1.min.js"></script>
     <script type="text/javascript" src="${rootURL}/plugin/build-pipeline-plugin/js/jquery-ui-1.8.14.custom.min.js"></script>
     <script type="text/javascript" src="${rootURL}/plugin/build-pipeline-plugin/js/handlebars-1.0.0.beta.6.js"></script>
@@ -62,13 +63,14 @@
         <j:if test="${hasBuildPermission}">
             <div class="icon-container">
             <j:if test="${from.isProjectParameterized()}">
-                <span class="pointer" onclick="buildPipeline.fillDialog('${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec', 'Starts the pipeline with parameters')">
+                <span class="bpp-trigger-pipeline-parameterized-params" data-fill-dialog-href="${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec" data-fill-dialog-title="Starts the pipeline with parameters" style="display: none" />
+                <span class="bpp-trigger-pipeline-parameterized pointer">
                     <l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
                                 <span>Run</span>
                 </span>
             </j:if>
             <j:if test="${!from.isProjectParameterized()}">
-              <a id="trigger-pipeline-button" href='#' onclick="document.getElementById('triggerPipelineForm').submit()">
+              <a class="bpp-trigger-pipeline-button" id="trigger-pipeline-button" href='#'>
                 <l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
                                 <span>Run</span>
               </a>

From 85dcb4bf1260334b2fdcc6903f1add5be3630bb6 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 18:47:13 -0400
Subject: [PATCH 18/59] Extract event handlers in

---
 .../buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js    | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
index 033c3eb3..4bee5d4f 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -1,12 +1,9 @@
 Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.TriggerPipelineParameterized', 0, function(element) {
     element.addEventListener('click', function() {
-
         const paramsElement = element.previousElementSibling;
         const href = paramsElement.dataset.fillDialogHref;
         const title = paramsElement.dataset.fillDialogTitle;
-
         buildPipeline.fillDialog(href, title);
-
     });
 });
 

From e40e43bedb64dc393edae4373151a12eddad4cc9 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 18:54:59 -0400
Subject: [PATCH 19/59] Extract event handlers in

---
 .../buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
index 4bee5d4f..5fc5c577 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -1,6 +1,6 @@
 Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.TriggerPipelineParameterized', 0, function(element) {
     element.addEventListener('click', function() {
-        const paramsElement = element.previousElementSibling;
+        const paramsElement = document.querySelector('.bpp-trigger-pipeline-parameterized-params');
         const href = paramsElement.dataset.fillDialogHref;
         const title = paramsElement.dataset.fillDialogTitle;
         buildPipeline.fillDialog(href, title);

From ab387f742c9218e35526b5fc93cf585582640990 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 19:39:36 -0400
Subject: [PATCH 20/59] Extract inline script block in
 au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/configure-entries.jelly

---
 .../BuildPipelineView/configure-entries.jelly            | 9 +--------
 .../BuildPipelineView/layoutUpdateCallback-call.js       | 4 ++++
 2 files changed, 5 insertions(+), 8 deletions(-)
 create mode 100644 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/configure-entries.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/configure-entries.jelly
index 7e2e208c..de65eb41 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/configure-entries.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/configure-entries.jelly
@@ -55,12 +55,5 @@
             <f:select />
         </f:entry>
     </f:section>
-
-    <script type="text/javascript">
-        // dropdownDescriptorSelectors will fill items up but don't update the layout, so need
-        // to do that explicitly
-        setTimeout(function(){
-            layoutUpdateCallback.call();
-        }, 500);
-    </script>
+    <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.BuildPipelineView.layoutUpdateCallback-call"/>
 </j:jelly>
\ No newline at end of file
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js
new file mode 100644
index 00000000..4fc0a024
--- /dev/null
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js
@@ -0,0 +1,4 @@
+setTimeout(function(){
+    console.log("SHLOMOMOM");
+    layoutUpdateCallback.call();
+}, 500);
\ No newline at end of file

From 943b8d902c3c5d06a69b5f11deb443f1773fa979 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 19:41:07 -0400
Subject: [PATCH 21/59] Extract inline script block in
 au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/configure-entries.jelly

---
 .../BuildPipelineView/layoutUpdateCallback-call.js              | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js
index 4fc0a024..61e2549a 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js
@@ -1,4 +1,4 @@
 setTimeout(function(){
     console.log("SHLOMOMOM");
     layoutUpdateCallback.call();
-}, 500);
\ No newline at end of file
+}, 500);

From 8ae55a083b361f46cd3747168bfd7edb0f334da5 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 19:41:26 -0400
Subject: [PATCH 22/59] Extract inline script block in
 au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/configure-entries.jelly

---
 .../buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js
index 61e2549a..52f79a7c 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/layoutUpdateCallback-call.js
@@ -1,4 +1,3 @@
 setTimeout(function(){
-    console.log("SHLOMOMOM");
     layoutUpdateCallback.call();
 }, 500);

From 187fb83ebc2d251e358b366d4341953199477aa8 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 19:57:40 -0400
Subject: [PATCH 23/59] extract inline script in

---
 .../BuildCardExtension/build-card-script-helpers.js      | 7 +++++++
 .../extension/BuildCardExtension/buildCardHelpers.jelly  | 9 +--------
 2 files changed, 8 insertions(+), 8 deletions(-)
 create mode 100644 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-script-helpers.js

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-script-helpers.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-script-helpers.js
new file mode 100644
index 00000000..2d48ffaa
--- /dev/null
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-script-helpers.js
@@ -0,0 +1,7 @@
+Handlebars.registerHelper('startScript', function() {
+    return new Handlebars.SafeString("<scr" + "ipt>");
+});
+
+Handlebars.registerHelper('endScript', function() {
+    return new Handlebars.SafeString("</scr" + "ipt>");
+});
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
index 2bf013e3..e71a4ee4 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
@@ -7,17 +7,10 @@
 
         By default we just include helpers to append script tags to your build card
     -->
+    <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.extension.BuildCardExtension.build-card-script-helpers"/>
     <![CDATA[
 
-    <script type="text/javascript">
-        Handlebars.registerHelper('startScript', function() {
-            return new Handlebars.SafeString("<scr" + "ipt>");
-        });
 
-        Handlebars.registerHelper('endScript', function() {
-            return new Handlebars.SafeString("</scr" + "ipt>");
-        });
-    </script>
 
     ]]>
 </j:jelly>
\ No newline at end of file

From b65fcf05ad084b05442f9bdc03bdc7706e63fc65 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 20:57:24 -0400
Subject: [PATCH 24/59] extract inline script in

---
 .../build-parameters-tooltip.js                     |  8 ++++++++
 .../AbstractNameValueHeader/rowHeader.jelly         | 13 +++++--------
 2 files changed, 13 insertions(+), 8 deletions(-)
 create mode 100644 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js
new file mode 100644
index 00000000..22702f07
--- /dev/null
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js
@@ -0,0 +1,8 @@
+document.addEventListener('DOMContentLoaded', function() {
+    const buildId = document.querySelector('.build-parameters-trigger-id').dataset.buildId;
+    jQuery('#build-parameters-trigger-' + buildId).tooltip({
+        bodyHandler: function() {
+            return jQuery('#build-parameters-' + buildId).html();
+        },
+    });
+});
\ No newline at end of file
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
index a2d6c444..1ef0a487 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
@@ -8,7 +8,7 @@
 
     <div class="pipeline-info">
         <div class="revision rounded">
-            <div class="title">Pipeline ${buildGrid.get(0,0).getRevision()}</div>
+            <div class="title build-parameters-trigger-id" data-build-id="${buildGrid.get(0,0).getId()}" id="build-parameters-trigger-${buildGrid.get(0,0).getId()}">Pipeline ${buildGrid.get(0,0).getRevision()}</div>
             <j:choose>
                 <j:when test="${buildGrid.get(0,0).getParameters().isEmpty()}">
                     <div class="description">No parameters</div>
@@ -18,16 +18,13 @@
                         <ul>
                             <j:forEach items="${it.getRowHeaders().getParameters(buildGrid.get(0,0).getCurrentBuild()).entrySet()}" var="buildParam" indexVar="buildParamCtr">
                                 <li>${buildParam.getKey()}: ${buildParam.getValue()}</li>
+                                <h1>TEST1</h1>
+                                <h1>TEST2</h1>
+                                <h1>TEST3</h1>
                             </j:forEach>
                         </ul>
                     </div>
-                    <script>
-                        jQuery('#build-parameters-trigger-${buildGrid.get(0,0).getId()}').tooltip({
-                            bodyHandler: function() {
-                                return jQuery('#build-parameters-${buildGrid.get(0,0).getId()}').html();
-                            }
-                        });
-                    </script>
+                    <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.extension.AbstractNameValueHeader.build-parameters-tooltip"/>
                 </j:otherwise>
             </j:choose>
         </div>

From 5b073d953b9c2f110d7c1a8ee7096e85e6516e46 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 21:03:34 -0400
Subject: [PATCH 25/59] extract inline script in

---
 .../extension/AbstractNameValueHeader/rowHeader.jelly          | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
index 1ef0a487..27201b0b 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
@@ -18,9 +18,6 @@
                         <ul>
                             <j:forEach items="${it.getRowHeaders().getParameters(buildGrid.get(0,0).getCurrentBuild()).entrySet()}" var="buildParam" indexVar="buildParamCtr">
                                 <li>${buildParam.getKey()}: ${buildParam.getValue()}</li>
-                                <h1>TEST1</h1>
-                                <h1>TEST2</h1>
-                                <h1>TEST3</h1>
                             </j:forEach>
                         </ul>
                     </div>

From c649a4c92ba6d99bb9df91bb57ce5e39f537a5f2 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 21:03:51 -0400
Subject: [PATCH 26/59] extract inline script in

---
 .../AbstractNameValueHeader/build-parameters-tooltip.js         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js
index 22702f07..5d478607 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js
@@ -5,4 +5,4 @@ document.addEventListener('DOMContentLoaded', function() {
             return jQuery('#build-parameters-' + buildId).html();
         },
     });
-});
\ No newline at end of file
+});

From 59e2952986537f08c4918cdefb44d2a37cf263f9 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 21:07:33 -0400
Subject: [PATCH 27/59] rerun tests

---
 .../extension/BuildCardExtension/build-card-template-onclicks.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 9184ad30..8233a9b8 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -84,6 +84,7 @@ const onclickElements = {
 
 document.addEventListener("DOMContentLoaded", function () {
     const parentElement = document.querySelector(".pipelines");
+    if (!parentElement) return;
 
     Object.entries(onclickElements).forEach(function(entry) {
         const selector = entry[0];

From cbe19f0809f859674d40e1d52b3052c90933d353 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Thu, 31 Oct 2024 14:41:21 -0400
Subject: [PATCH 28/59] Extract JS in columnHeaders.jelly

---
 .../PipelineHeaderExtension/columnHeader.jelly      | 13 ++++++++-----
 .../pipeline-column-headers.js                      | 13 +++++++++++++
 2 files changed, 21 insertions(+), 5 deletions(-)
 create mode 100644 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/pipeline-column-headers.js

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly
index 54399419..472c545c 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly
@@ -27,11 +27,14 @@
                                             <td id="project-${project.getId()}"></td>
                                         </j:otherwise>
                                     </j:choose>
-                                    <script>
-                                        //save project proxies for future reference (being able to refresh project cards)
-                                        buildPipeline.projectProxies[${project.getId()}] = <st:bind value="${project}" />;
-                                        jQuery("#project-${project.getId()}").append(buildPipeline.projectCardTemplate(${project.asJSON()}));
-                                    </script>
+                                    <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.extension.PipelineHeaderExtension.pipeline-column-headers"/>
+                                    <st:bind value="${project}" var="projectProxy${project.getId()}"/>
+                                    <span class="ch-project-data-holder" data-project-id="${project.getId()}" data-proxy-name="projectProxy${project.getId()}" data-project-json="${project.asJSON()}" style="display:none"/>
+<!--                                    <script>-->
+<!--                                        //save project proxies for future reference (being able to refresh project cards)-->
+<!--                                        buildPipeline.projectProxies[${project.getId()}] = <st:bind value="${project}" />;-->
+<!--                                        jQuery("#project-${project.getId()}").append(buildPipeline.projectCardTemplate(${project.asJSON()}));-->
+<!--                                    </script>-->
                                     <j:if test="${(y + 1 != buildPipelineForm.getGridWidth())}">
                                         <td class="next">
                                             <!-- Changing length to size() to get rid of arrows when there are no more child jobs.-->
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/pipeline-column-headers.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/pipeline-column-headers.js
new file mode 100644
index 00000000..7c8bfa65
--- /dev/null
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/pipeline-column-headers.js
@@ -0,0 +1,13 @@
+window.addEventListener("DOMContentLoaded", () => {
+    const projectDataHolders = document.querySelectorAll(".ch-project-data-holder");
+
+    projectDataHolders.forEach(dataHolder => {
+        const { projectId, proxyName, projectJson } = dataHolder.dataset;
+
+        buildPipeline.projectProxies[projectId] = window[proxyName];
+
+        const projectElement = document.getElementById("project-" + projectId);
+        const projectData = JSON.parse(projectJson);
+        projectElement.innerHTML = buildPipeline.projectCardTemplate(projectData);
+    });
+});

From ccdfa1dc1a77f5b838d987666be4d23ddd4a5293 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Thu, 31 Oct 2024 14:46:14 -0400
Subject: [PATCH 29/59] Extract JS in columnHeaders.jelly

---
 .../extension/PipelineHeaderExtension/columnHeader.jelly     | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly
index 472c545c..a9b7209b 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly
@@ -30,11 +30,6 @@
                                     <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.extension.PipelineHeaderExtension.pipeline-column-headers"/>
                                     <st:bind value="${project}" var="projectProxy${project.getId()}"/>
                                     <span class="ch-project-data-holder" data-project-id="${project.getId()}" data-proxy-name="projectProxy${project.getId()}" data-project-json="${project.asJSON()}" style="display:none"/>
-<!--                                    <script>-->
-<!--                                        //save project proxies for future reference (being able to refresh project cards)-->
-<!--                                        buildPipeline.projectProxies[${project.getId()}] = <st:bind value="${project}" />;-->
-<!--                                        jQuery("#project-${project.getId()}").append(buildPipeline.projectCardTemplate(${project.asJSON()}));-->
-<!--                                    </script>-->
                                     <j:if test="${(y + 1 != buildPipelineForm.getGridWidth())}">
                                         <td class="next">
                                             <!-- Changing length to size() to get rid of arrows when there are no more child jobs.-->

From c35d193e0637dbb2c0e4aa8ff1aba5aacd84c3cc Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Thu, 31 Oct 2024 18:08:43 -0400
Subject: [PATCH 30/59] test

---
 .../buildpipeline/BuildPipelineView/main_dashboard.jelly   | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly
index 79262ca2..f038580f 100755
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly
@@ -3,10 +3,11 @@
     <st:include page="bpp.jelly" from="${it.getBuildPipelineView()}" />
     <link href="${rootURL}/plugin/build-pipeline-plugin/css/main_dashboard.css" type="text/css" rel="stylesheet" />
     <script type="text/javascript">
+        console.log("main_dashboard.jelly");
         // show/hide build details
-        $(function() {
-            $(".header").click(function() {
-                var parent = $(this).parent();
+        jQuery(function() {
+            jQuery(".header").click(function() {
+                var parent = jQuery(this).parent();
                 var ba = parent.find(".build-actions");
                 var bb = parent.find(".build-body");
 

From 41a2f9cac7ae9ce0b9b51514225a597a78bae828 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Thu, 31 Oct 2024 18:09:10 -0400
Subject: [PATCH 31/59] test

---
 .../plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly  | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly
index f038580f..2f45ae57 100755
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly
@@ -3,7 +3,6 @@
     <st:include page="bpp.jelly" from="${it.getBuildPipelineView()}" />
     <link href="${rootURL}/plugin/build-pipeline-plugin/css/main_dashboard.css" type="text/css" rel="stylesheet" />
     <script type="text/javascript">
-        console.log("main_dashboard.jelly");
         // show/hide build details
         jQuery(function() {
             jQuery(".header").click(function() {

From 85e53a361834d11bc2d16505f5ce6333051b22a7 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Thu, 31 Oct 2024 18:16:20 -0400
Subject: [PATCH 32/59] extract inmline JS in main_dashboard.jelly

---
 .../BuildPipelineView/main_dashboard.jelly          | 13 +------------
 .../BuildPipelineView/toggle-build-details.js       | 10 ++++++++++
 2 files changed, 11 insertions(+), 12 deletions(-)
 create mode 100644 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/toggle-build-details.js

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly
index 2f45ae57..f0c0b8e7 100755
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/main_dashboard.jelly
@@ -2,16 +2,5 @@
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt">
     <st:include page="bpp.jelly" from="${it.getBuildPipelineView()}" />
     <link href="${rootURL}/plugin/build-pipeline-plugin/css/main_dashboard.css" type="text/css" rel="stylesheet" />
-    <script type="text/javascript">
-        // show/hide build details
-        jQuery(function() {
-            jQuery(".header").click(function() {
-                var parent = jQuery(this).parent();
-                var ba = parent.find(".build-actions");
-                var bb = parent.find(".build-body");
-
-                ba.add(bb).toggle('slow');
-            });
-        });
-    </script>
+    <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.BuildPipelineView.toggle-build-details" />
 </j:jelly>
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/toggle-build-details.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/toggle-build-details.js
new file mode 100644
index 00000000..b8c6e241
--- /dev/null
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/toggle-build-details.js
@@ -0,0 +1,10 @@
+// show/hide build details
+jQuery(function() {
+    jQuery(".header").click(function() {
+        var parent = jQuery(this).parent();
+        var ba = parent.find(".build-actions");
+        var bb = parent.find(".build-body");
+
+        ba.add(bb).toggle('slow');
+    });
+});

From 7316cdd19e42ba0128f25e8761d402dfcd142a6c Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Sun, 3 Nov 2024 17:01:40 -0500
Subject: [PATCH 33/59] extract inline script bpp.jelly

---
 .../buildpipeline/BuildPipelineView/bpp.jelly | 55 ++++++++----------
 .../BuildPipelineView/build-pipeline-init.js  | 56 +++++++++++++++++++
 src/main/webapp/js/build-pipeline.js          |  2 +-
 3 files changed, 80 insertions(+), 33 deletions(-)
 create mode 100644 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index f349bfc8..e7b1ea91 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -19,24 +19,26 @@
     <script src="${rootURL}/plugin/build-pipeline-plugin/js/jquery.tooltip.min.js"></script>
     <script src="${rootURL}/plugin/build-pipeline-plugin/js/build-pipeline.js"></script>
 
-<script id="build-card-template" type="text/x-handlebars-template">
+<span id="build-card-template" type="text/x-handlebars-template" style="display: none">
     <st:include page="buildCardTemplate.jelly"
                 from="${from.getBuildCard()}"
                 it="${from}"/>
-</script>
+</span>
 
-<script id="project-card-template" type="text/x-handlebars-template">
+<span id="project-card-template" type="text/x-handlebars-template" style="display: none">
     <st:include page="projectCardTemplate.jelly"
                 from="${from.getColumnHeaders()}"
                 it="${from}" />
-</script>
+</span>
 
     <st:bind var="buildPipelineViewProxy" value="${from}" />
-    <script type="text/javascript">
-        var buildCardTemplateSource = jQuery("#build-card-template").html();
-        var projectCardTemplateSource = jQuery("#project-card-template").html();
-        var buildPipeline = new BuildPipeline(buildPipelineViewProxy, Handlebars.compile(buildCardTemplateSource), Handlebars.compile(projectCardTemplateSource), ${from.getRefreshFrequencyInMillis()});
-    </script>
+    <span class="pipeline-refresh-frequency" data-refresh-frequency="${from.getRefreshFrequencyInMillis()}" style="display: none"/>
+    <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.BuildPipelineView.build-pipeline-init"/>
+<!--    <script type="text/javascript">-->
+<!--        var buildCardTemplateSource = jQuery("#build-card-template").html();-->
+<!--        var projectCardTemplateSource = jQuery("#project-card-template").html();-->
+<!--        var buildPipeline = new BuildPipeline(buildPipelineViewProxy, Handlebars.compile(buildCardTemplateSource), Handlebars.compile(projectCardTemplateSource), ${from.getRefreshFrequencyInMillis()});-->
+<!--    </script>-->
 
     <st:include page="buildCardHelpers.jelly"
                 from="${from.getBuildCard()}"
@@ -131,29 +133,18 @@
                                 <j:forEach begin="${0}" end="${buildPipelineForm.getGridWidth() - 1}" indexVar="y">
                                     <j:set var="build" type="au.com.centrumsystems.hudson.plugin.buildpipeline.BuildForm" value="${buildGrid.get(x,y)}" />
                                     <j:if test="${build != null}">
-                                        <td id="build-${build.getId()}"></td>
-                                        <script>
-                                            // generate build-card
-                                            var buildData = ${build.asJSON()};
-                                            jQuery("#build-${build.getId()}").append(buildPipeline.buildCardTemplate(buildData));
-                                            // add build proxy to proxies for future use
-                                            buildPipeline.buildProxies[${build.getId()}] = <st:bind value="${build}" />;
-                                            <j:if test="${build.getStatus() == 'BUILDING'}">
-                                                buildPipeline.showProgress(${build.getId()}, ${build.getDependencyIds()});
-                                            </j:if>
-                                            <j:if test="${build.getStatus() == 'PENDING'}">
-                                                jQuery("#pipelines").bind("show-status-${build.getId()}", function() {
-                                                <j:choose>
-                                                    <j:when test="${build.isManualTrigger()}">
-                                                        buildPipeline.updateBuildCard(${build.getId()});
-                                                    </j:when>
-                                                    <j:otherwise>
-                                                        buildPipeline.updateNextBuildAndShowProgress(${build.getId()}, ${build.getNextBuildNumber()}, ${build.getDependencyIds()});
-                                                    </j:otherwise>
-                                                </j:choose>
-                                                });
-                                            </j:if>
-                                        </script>
+                                        <td id="build-${build.getId()}">
+                                            <j:set var="buildDataJson" value="${build.asJSON()}" />
+                                            <div class="build-data"
+                                                 data-build-id="${build.getId()}"
+                                                 data-build-info="${buildDataJson}"
+                                                 data-build-status="${build.getStatus()}"
+                                                 data-is-manual-trigger="${build.isManualTrigger()}"
+                                                 data-next-build-number="${build.getNextBuildNumber()}"
+                                                 data-dependency-ids="${build.getDependencyIds()}">
+                                            </div>
+                                            <st:bind var="buildProxy_${build.getId()}" value="${build}" />
+                                        </td>
                                         <j:if test="${(y + 1 != buildPipelineForm.getGridWidth())}">
                                             <!-- Changing length to size() to get rid of arrows when there are no more child jobs.-->
                                         <td class="next">
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
new file mode 100644
index 00000000..aa785481
--- /dev/null
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
@@ -0,0 +1,56 @@
+const buildCardTemplateSource = jQuery("#build-card-template").html();
+const projectCardTemplateSource = jQuery("#project-card-template").html();
+const refreshFrequency = parseInt(document.querySelector(".pipeline-refresh-frequency").dataset.refreshFrequency, 10);
+
+var buildPipeline = new BuildPipeline(
+buildPipelineViewProxy,
+Handlebars.compile(buildCardTemplateSource),
+Handlebars.compile(projectCardTemplateSource),
+refreshFrequency
+);
+
+
+function initializeBuildCards() {
+    // Find all build data elements
+    document.querySelectorAll('.build-data').forEach(buildElement => {
+
+        const buildId = buildElement.dataset.buildId;
+        const buildData = JSON.parse(buildElement.dataset.buildInfo);
+        const buildStatus = buildElement.dataset.buildStatus;
+        const isManualTrigger = buildElement.dataset.isManualTrigger === 'true';
+        const nextBuildNumber = parseInt(buildElement.dataset.nextBuildNumber, 10);
+        console.log(nextBuildNumber);
+        const dependencyIds = buildElement.dataset.dependencyIds
+            .split(',')
+            .filter(Boolean)
+            .map(id => parseInt(id, 10));
+
+
+        // Generate build card
+        jQuery(buildElement).append(buildPipeline.buildCardTemplate(buildData));
+
+        // add build proxy to proxies for future use-->
+        buildPipeline.buildProxies[buildId] = window[`buildProxy_${buildId}`];
+
+        if (buildStatus === 'BUILDING') {
+            buildPipeline.showProgress(buildId, dependencyIds, nextBuildNumber);
+        }
+
+        if (buildStatus === 'PENDING') {
+            jQuery("table.pipelines").on(`show-status-${buildId}`, function() {
+                if (isManualTrigger) {
+                    buildPipeline.updateBuildCard(buildId);
+                } else {
+                    buildPipeline.updateNextBuildAndShowProgress(
+                        buildId,
+                        nextBuildNumber,
+                        dependencyIds
+                    );
+                }
+            });
+        }
+
+    });
+}
+
+document.addEventListener('DOMContentLoaded', initializeBuildCards);
\ No newline at end of file
diff --git a/src/main/webapp/js/build-pipeline.js b/src/main/webapp/js/build-pipeline.js
index 6ce69423..3d650c9d 100644
--- a/src/main/webapp/js/build-pipeline.js
+++ b/src/main/webapp/js/build-pipeline.js
@@ -26,7 +26,7 @@ BuildPipeline.prototype = {
                         buildPipeline.updateAllBuildCards(dependencies);
                         // trigger all dependency tracking
                         jQuery.each(dependencies, function(){
-                            jQuery("#pipelines").trigger("show-status-" + this);
+                            jQuery("table.pipelines").trigger("show-status-" + this);
                         });
                     }
                 });

From 86b17503e71710c2a0aa8f7127909f7c291ec839 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Sun, 3 Nov 2024 17:04:09 -0500
Subject: [PATCH 34/59] extract inline script bpp.jelly

---
 .../hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly  | 5 -----
 .../buildpipeline/BuildPipelineView/build-pipeline-init.js   | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index e7b1ea91..267e61ee 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -34,11 +34,6 @@
     <st:bind var="buildPipelineViewProxy" value="${from}" />
     <span class="pipeline-refresh-frequency" data-refresh-frequency="${from.getRefreshFrequencyInMillis()}" style="display: none"/>
     <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.BuildPipelineView.build-pipeline-init"/>
-<!--    <script type="text/javascript">-->
-<!--        var buildCardTemplateSource = jQuery("#build-card-template").html();-->
-<!--        var projectCardTemplateSource = jQuery("#project-card-template").html();-->
-<!--        var buildPipeline = new BuildPipeline(buildPipelineViewProxy, Handlebars.compile(buildCardTemplateSource), Handlebars.compile(projectCardTemplateSource), ${from.getRefreshFrequencyInMillis()});-->
-<!--    </script>-->
 
     <st:include page="buildCardHelpers.jelly"
                 from="${from.getBuildCard()}"
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
index aa785481..734d2cf1 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
@@ -53,4 +53,4 @@ function initializeBuildCards() {
     });
 }
 
-document.addEventListener('DOMContentLoaded', initializeBuildCards);
\ No newline at end of file
+document.addEventListener('DOMContentLoaded', initializeBuildCards);

From 5dab85111a114e1d8314aee728a088beeda5b4ee Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Mon, 4 Nov 2024 16:48:30 -0500
Subject: [PATCH 35/59] fix existing functionality - extract JS

---
 .../buildpipeline/BuildPipelineView/bpp.jelly   |  5 ++---
 .../BuildPipelineView/build-pipeline-init.js    | 17 ++++++-----------
 2 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index 267e61ee..f3e42b9e 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -130,14 +130,13 @@
                                     <j:if test="${build != null}">
                                         <td id="build-${build.getId()}">
                                             <j:set var="buildDataJson" value="${build.asJSON()}" />
-                                            <div class="build-data"
+                                            <span class="build-data"
                                                  data-build-id="${build.getId()}"
                                                  data-build-info="${buildDataJson}"
                                                  data-build-status="${build.getStatus()}"
                                                  data-is-manual-trigger="${build.isManualTrigger()}"
                                                  data-next-build-number="${build.getNextBuildNumber()}"
-                                                 data-dependency-ids="${build.getDependencyIds()}">
-                                            </div>
+                                                 data-dependency-ids="${build.getDependencyIds()}"/>
                                             <st:bind var="buildProxy_${build.getId()}" value="${build}" />
                                         </td>
                                         <j:if test="${(y + 1 != buildPipelineForm.getGridWidth())}">
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
index 734d2cf1..268da39b 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
@@ -3,10 +3,10 @@ const projectCardTemplateSource = jQuery("#project-card-template").html();
 const refreshFrequency = parseInt(document.querySelector(".pipeline-refresh-frequency").dataset.refreshFrequency, 10);
 
 var buildPipeline = new BuildPipeline(
-buildPipelineViewProxy,
-Handlebars.compile(buildCardTemplateSource),
-Handlebars.compile(projectCardTemplateSource),
-refreshFrequency
+    buildPipelineViewProxy,
+    Handlebars.compile(buildCardTemplateSource),
+    Handlebars.compile(projectCardTemplateSource),
+    refreshFrequency
 );
 
 
@@ -19,12 +19,7 @@ function initializeBuildCards() {
         const buildStatus = buildElement.dataset.buildStatus;
         const isManualTrigger = buildElement.dataset.isManualTrigger === 'true';
         const nextBuildNumber = parseInt(buildElement.dataset.nextBuildNumber, 10);
-        console.log(nextBuildNumber);
-        const dependencyIds = buildElement.dataset.dependencyIds
-            .split(',')
-            .filter(Boolean)
-            .map(id => parseInt(id, 10));
-
+        const dependencyIds = JSON.parse(buildElement.dataset.dependencyIds);
 
         // Generate build card
         jQuery(buildElement).append(buildPipeline.buildCardTemplate(buildData));
@@ -33,7 +28,7 @@ function initializeBuildCards() {
         buildPipeline.buildProxies[buildId] = window[`buildProxy_${buildId}`];
 
         if (buildStatus === 'BUILDING') {
-            buildPipeline.showProgress(buildId, dependencyIds, nextBuildNumber);
+            buildPipeline.showProgress(buildId, dependencyIds);
         }
 
         if (buildStatus === 'PENDING') {

From 08c66cab0458dc5693da6db178c99140823e64f8 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Mon, 4 Nov 2024 16:49:30 -0500
Subject: [PATCH 36/59] fix existing functionality - extract JS

---
 .../buildpipeline/BuildPipelineView/build-pipeline-init.js       | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
index 268da39b..2987cde3 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
@@ -11,7 +11,6 @@ var buildPipeline = new BuildPipeline(
 
 
 function initializeBuildCards() {
-    // Find all build data elements
     document.querySelectorAll('.build-data').forEach(buildElement => {
 
         const buildId = buildElement.dataset.buildId;

From 3239f8112ff480235ace25bc791c6890e2b58612 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Mon, 4 Nov 2024 17:45:33 -0500
Subject: [PATCH 37/59] test all tickets

---
 pom.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index a32c92ea..7adf3e8a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -28,7 +28,7 @@
     <properties>
         <revision>2.0.3</revision>
         <changelist>-SNAPSHOT</changelist>
-        <jenkins.version>2.414.3</jenkins.version>
+        <jenkins.version>2.426.3</jenkins.version>
         <gitHubRepo>jenkinsci/${project.artifactId}</gitHubRepo>
         <code.coverage.percentage>50</code.coverage.percentage>
         <selenium.version>4.25.0</selenium.version>
@@ -85,6 +85,7 @@
         <dependency>
             <groupId>io.jenkins.plugins</groupId>
             <artifactId>jquery3-api</artifactId>
+            <version>3.7.1-2</version>
         </dependency>
         <!-- Optional dependencies for using Spock -->
         <dependency>

From 0ef7e3ccf6d9bfbe86899d75769572c1dfbd69a2 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Mon, 4 Nov 2024 17:56:20 -0500
Subject: [PATCH 38/59] bump jenkins to 2.426.3 (to update jQuery3 plugin)

---
 pom.xml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index a32c92ea..786dba94 100644
--- a/pom.xml
+++ b/pom.xml
@@ -28,7 +28,7 @@
     <properties>
         <revision>2.0.3</revision>
         <changelist>-SNAPSHOT</changelist>
-        <jenkins.version>2.414.3</jenkins.version>
+        <jenkins.version>2.426.3</jenkins.version>
         <gitHubRepo>jenkinsci/${project.artifactId}</gitHubRepo>
         <code.coverage.percentage>50</code.coverage.percentage>
         <selenium.version>4.25.0</selenium.version>
@@ -85,6 +85,7 @@
         <dependency>
             <groupId>io.jenkins.plugins</groupId>
             <artifactId>jquery3-api</artifactId>
+            <version>3.7.1-2</version>
         </dependency>
         <!-- Optional dependencies for using Spock -->
         <dependency>
@@ -291,8 +292,8 @@
             <url>https://repo.jenkins-ci.org/releases</url>
         </repository>
         <snapshotRepository>
-             <id>maven.jenkins-ci.org</id>
-	     <url>https://repo.jenkins-ci.org/snapshots</url>
+            <id>maven.jenkins-ci.org</id>
+            <url>https://repo.jenkins-ci.org/snapshots</url>
         </snapshotRepository>
     </distributionManagement>
 

From edabfbf8637c51118bb153be83a9d6d68009cbf6 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 5 Nov 2024 18:02:33 -0500
Subject: [PATCH 39/59] Bump jenkins version to 2.452.3

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 786dba94..3b369426 100644
--- a/pom.xml
+++ b/pom.xml
@@ -28,7 +28,7 @@
     <properties>
         <revision>2.0.3</revision>
         <changelist>-SNAPSHOT</changelist>
-        <jenkins.version>2.426.3</jenkins.version>
+        <jenkins.version>2.452.3</jenkins.version>
         <gitHubRepo>jenkinsci/${project.artifactId}</gitHubRepo>
         <code.coverage.percentage>50</code.coverage.percentage>
         <selenium.version>4.25.0</selenium.version>

From c9ad9c0e6c745bf79f80327354c8de60c61d4094 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 5 Nov 2024 18:04:00 -0500
Subject: [PATCH 40/59] Bump jenkins version to 2.452.3

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 3b369426..37b12772 100644
--- a/pom.xml
+++ b/pom.xml
@@ -292,7 +292,7 @@
             <url>https://repo.jenkins-ci.org/releases</url>
         </repository>
         <snapshotRepository>
-            <id>maven.jenkins-ci.org</id>
+             <id>maven.jenkins-ci.org</id>
             <url>https://repo.jenkins-ci.org/snapshots</url>
         </snapshotRepository>
     </distributionManagement>

From f4900668f542290d3882bb637ab30131573b7fce Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 5 Nov 2024 18:04:26 -0500
Subject: [PATCH 41/59] Bump jenkins version to 2.452.3

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 37b12772..76c868c7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -293,7 +293,7 @@
         </repository>
         <snapshotRepository>
              <id>maven.jenkins-ci.org</id>
-            <url>https://repo.jenkins-ci.org/snapshots</url>
+             <url>https://repo.jenkins-ci.org/snapshots</url>
         </snapshotRepository>
     </distributionManagement>
 

From f49351245247287b63685ad217bdb9f51cdbae41 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 5 Nov 2024 18:27:36 -0500
Subject: [PATCH 42/59] simplify proxy

---
 .../extension/PipelineHeaderExtension/columnHeader.jelly      | 2 +-
 .../PipelineHeaderExtension/pipeline-column-headers.js        | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly
index a9b7209b..6140ccbc 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/columnHeader.jelly
@@ -29,7 +29,7 @@
                                     </j:choose>
                                     <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.extension.PipelineHeaderExtension.pipeline-column-headers"/>
                                     <st:bind value="${project}" var="projectProxy${project.getId()}"/>
-                                    <span class="ch-project-data-holder" data-project-id="${project.getId()}" data-proxy-name="projectProxy${project.getId()}" data-project-json="${project.asJSON()}" style="display:none"/>
+                                    <span class="ch-project-data-holder" data-project-id="${project.getId()}" data-project-json="${project.asJSON()}" style="display:none"/>
                                     <j:if test="${(y + 1 != buildPipelineForm.getGridWidth())}">
                                         <td class="next">
                                             <!-- Changing length to size() to get rid of arrows when there are no more child jobs.-->
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/pipeline-column-headers.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/pipeline-column-headers.js
index 7c8bfa65..2d024927 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/pipeline-column-headers.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension/pipeline-column-headers.js
@@ -2,9 +2,9 @@ window.addEventListener("DOMContentLoaded", () => {
     const projectDataHolders = document.querySelectorAll(".ch-project-data-holder");
 
     projectDataHolders.forEach(dataHolder => {
-        const { projectId, proxyName, projectJson } = dataHolder.dataset;
+        const { projectId, projectJson } = dataHolder.dataset;
 
-        buildPipeline.projectProxies[projectId] = window[proxyName];
+        buildPipeline.projectProxies[projectId] = window["projectProxy" + projectId];
 
         const projectElement = document.getElementById("project-" + projectId);
         const projectData = JSON.parse(projectJson);

From 0a4c4fe01a7872b193fa3bb872240079f777b669 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 5 Nov 2024 20:22:15 -0500
Subject: [PATCH 43/59] return positive ids

---
 .../hudson/plugin/buildpipeline/BuildForm.java             | 7 ++++---
 .../hudson/plugin/buildpipeline/ProjectForm.java           | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
index 25a65a87..8faa0d72 100644
--- a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
+++ b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
@@ -129,11 +129,11 @@ public List<Integer> getDependencyIds() {
      */
     @JavaScriptMethod
     public String asJSON() {
-        return BuildJSONBuilder.asJSON(context, pipelineBuild, id, projectId, getDependencyIds(), getParameterList());
+        return BuildJSONBuilder.asJSON(context, pipelineBuild, getId(), getProjectId(), getDependencyIds(), getParameterList());
     }
 
     public int getId() {
-        return id;
+        return Math.abs(id);
     }
 
     /**
@@ -171,7 +171,8 @@ public ArrayList<String> getParameterList() {
     }
 
     public Integer getProjectId() {
-        return projectId;
+
+        return Math.abs(projectId);
     }
 
     public AbstractBuild<?, ?> getCurrentBuild() {
diff --git a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
index e8c8bb30..3cc7c30f 100644
--- a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
+++ b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
@@ -240,7 +240,7 @@ public boolean equals(final Object obj) {
     }
 
     public int getId() {
-        return name.hashCode();
+        return Math.abs(name.hashCode());
     }
 
     /**

From dbbcc7dfee1de158910b77fa8fdce36f571e01c9 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 5 Nov 2024 20:22:51 -0500
Subject: [PATCH 44/59] return positive ids

---
 .../centrumsystems/hudson/plugin/buildpipeline/BuildForm.java    | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
index 8faa0d72..e5b04a4c 100644
--- a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
+++ b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
@@ -171,7 +171,6 @@ public ArrayList<String> getParameterList() {
     }
 
     public Integer getProjectId() {
-
         return Math.abs(projectId);
     }
 

From 8fedd289dbf478dddce5851d457033a8eb0a86e0 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 6 Nov 2024 08:07:19 -0500
Subject: [PATCH 45/59] Bad attempt to compute absolute value of signed 32-bit
 hashcode in
 au.com.centrumsystems.hudson.plugin.buildpipeline.ProjectForm.getId()

---
 .../hudson/plugin/buildpipeline/BuildForm.java              | 6 +++---
 .../hudson/plugin/buildpipeline/ProjectForm.java            | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
index e5b04a4c..25a65a87 100644
--- a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
+++ b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
@@ -129,11 +129,11 @@ public List<Integer> getDependencyIds() {
      */
     @JavaScriptMethod
     public String asJSON() {
-        return BuildJSONBuilder.asJSON(context, pipelineBuild, getId(), getProjectId(), getDependencyIds(), getParameterList());
+        return BuildJSONBuilder.asJSON(context, pipelineBuild, id, projectId, getDependencyIds(), getParameterList());
     }
 
     public int getId() {
-        return Math.abs(id);
+        return id;
     }
 
     /**
@@ -171,7 +171,7 @@ public ArrayList<String> getParameterList() {
     }
 
     public Integer getProjectId() {
-        return Math.abs(projectId);
+        return projectId;
     }
 
     public AbstractBuild<?, ?> getCurrentBuild() {
diff --git a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
index 3cc7c30f..e8c8bb30 100644
--- a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
+++ b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
@@ -240,7 +240,7 @@ public boolean equals(final Object obj) {
     }
 
     public int getId() {
-        return Math.abs(name.hashCode());
+        return name.hashCode();
     }
 
     /**

From 874f74e9817b41c7aa56105c00ac07fe72f20444 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 6 Nov 2024 08:45:55 -0500
Subject: [PATCH 46/59] mask negative bit in project id

---
 .../centrumsystems/hudson/plugin/buildpipeline/BuildForm.java   | 2 +-
 .../centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
index 25a65a87..32ee6882 100644
--- a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
+++ b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildForm.java
@@ -94,7 +94,7 @@ private BuildForm(ItemGroup context, final PipelineBuild pipelineBuild, final Co
         }
         id = hashCode();
         final AbstractProject<?, ?> project = pipelineBuild.getProject();
-        projectId = project.getFullName().hashCode();
+        projectId = project.getFullName().hashCode() & 0x7FFFFFFF;
         final ParametersDefinitionProperty params = project.getProperty(ParametersDefinitionProperty.class);
         final ArrayList<String> paramList = new ArrayList<String>();
         if (params != null && params.getParameterDefinitionNames() != null) {
diff --git a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
index e8c8bb30..8fbda5f2 100644
--- a/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
+++ b/src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/ProjectForm.java
@@ -240,7 +240,7 @@ public boolean equals(final Object obj) {
     }
 
     public int getId() {
-        return name.hashCode();
+        return name.hashCode() & 0x7FFFFFFF;
     }
 
     /**

From 7beca3498797419ec4a44d997929f08fdc1d2b0a Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Thu, 7 Nov 2024 14:35:19 -0500
Subject: [PATCH 47/59] specify pipeline wrapper - fixes onclick issues

---
 .../hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly     | 2 +-
 .../BuildCardExtension/build-card-template-onclicks.js          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index 546e01fb..d50bd9e3 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -124,7 +124,7 @@
                 <st:include from="${from.getRowHeaders()}" it="${from}"
                             page="rowHeader.jelly"/>
 
-                <div class="pipeline">
+                <div class="pipeline main-pipeline-selector">
                     <table class="pipelines">
                         <tbody>
                             <j:forEach begin="${0}" end="${buildGrid.rows - 1}" indexVar="x">
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 8233a9b8..78d6e594 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -83,7 +83,7 @@ const onclickElements = {
 };
 
 document.addEventListener("DOMContentLoaded", function () {
-    const parentElement = document.querySelector(".pipelines");
+    const parentElement = document.querySelector(".main-pipeline-selector");
     if (!parentElement) return;
 
     Object.entries(onclickElements).forEach(function(entry) {

From 188bc434af1b93072432686871834aba63173cdd Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Thu, 7 Nov 2024 14:48:15 -0500
Subject: [PATCH 48/59] select all pipeline wrappers - incase multiple builds
 selected

---
 .../buildpipeline/BuildPipelineView/bpp.jelly     |  2 +-
 .../build-card-template-onclicks.js               | 15 +++++++++------
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index d50bd9e3..546e01fb 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -124,7 +124,7 @@
                 <st:include from="${from.getRowHeaders()}" it="${from}"
                             page="rowHeader.jelly"/>
 
-                <div class="pipeline main-pipeline-selector">
+                <div class="pipeline">
                     <table class="pipelines">
                         <tbody>
                             <j:forEach begin="${0}" end="${buildGrid.rows - 1}" indexVar="x">
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index 78d6e594..ccad37db 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -83,12 +83,15 @@ const onclickElements = {
 };
 
 document.addEventListener("DOMContentLoaded", function () {
-    const parentElement = document.querySelector(".main-pipeline-selector");
-    if (!parentElement) return;
+    const pipelineWrappers = document.querySelectorAll(".pipeline-wrapper");
 
-    Object.entries(onclickElements).forEach(function(entry) {
-        const selector = entry[0];
-        const handlerConfig = entry[1];
-        createClickHandler(parentElement, selector, handlerConfig.handler);
+    if (!pipelineWrappers.length) return;
+
+    pipelineWrappers.forEach(wrapper => {
+        Object.entries(onclickElements).forEach(function(entry) {
+            const selector = entry[0];
+            const handlerConfig = entry[1];
+            createClickHandler(wrapper, selector, handlerConfig.handler);
+        });
     });
 });

From da580f07ae03fbf3127a52f12fb8783fb7083428 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Thu, 7 Nov 2024 18:57:29 -0500
Subject: [PATCH 49/59] fix card update logic

---
 .../BuildPipelineView/build-pipeline-init.js  | 25 ++++++++-----------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
index 2987cde3..6b925b0b 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
@@ -30,20 +30,17 @@ function initializeBuildCards() {
             buildPipeline.showProgress(buildId, dependencyIds);
         }
 
-        if (buildStatus === 'PENDING') {
-            jQuery("table.pipelines").on(`show-status-${buildId}`, function() {
-                if (isManualTrigger) {
-                    buildPipeline.updateBuildCard(buildId);
-                } else {
-                    buildPipeline.updateNextBuildAndShowProgress(
-                        buildId,
-                        nextBuildNumber,
-                        dependencyIds
-                    );
-                }
-            });
-        }
-
+        jQuery("table.pipelines").on(`show-status-${buildId}`, function() {
+            if (isManualTrigger) {
+                buildPipeline.updateBuildCard(buildId);
+            } else {
+                buildPipeline.updateNextBuildAndShowProgress(
+                    buildId,
+                    nextBuildNumber,
+                    dependencyIds
+                );
+            }
+        });
     });
 }
 

From 2805d64d973264a273564b9e4092779338558e4d Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 10:47:51 -0500
Subject: [PATCH 50/59] restore pom

---
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 76c868c7..3b369426 100644
--- a/pom.xml
+++ b/pom.xml
@@ -292,8 +292,8 @@
             <url>https://repo.jenkins-ci.org/releases</url>
         </repository>
         <snapshotRepository>
-             <id>maven.jenkins-ci.org</id>
-             <url>https://repo.jenkins-ci.org/snapshots</url>
+            <id>maven.jenkins-ci.org</id>
+            <url>https://repo.jenkins-ci.org/snapshots</url>
         </snapshotRepository>
     </distributionManagement>
 

From 95aba1e07acb3aaeef9a626502256b786dbb4046 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 10:56:15 -0500
Subject: [PATCH 51/59] restore pom

---
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 3b369426..bc23a330 100644
--- a/pom.xml
+++ b/pom.xml
@@ -292,8 +292,8 @@
             <url>https://repo.jenkins-ci.org/releases</url>
         </repository>
         <snapshotRepository>
-            <id>maven.jenkins-ci.org</id>
-            <url>https://repo.jenkins-ci.org/snapshots</url>
+             <id>maven.jenkins-ci.org</id>
+	     <url>https://repo.jenkins-ci.org/snapshots</url>
         </snapshotRepository>
     </distributionManagement>
 

From 8a4cab4a1581ad09e5afef49652a50703a9aca59 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 11:33:16 -0500
Subject: [PATCH 52/59] update BOM to support 2.452.3 and jQuery 3.7.1-2

---
 pom.xml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index bc23a330..2bfb85ed 100644
--- a/pom.xml
+++ b/pom.xml
@@ -52,8 +52,8 @@
         <dependencies>
             <dependency>
                 <groupId>io.jenkins.tools.bom</groupId>
-                <artifactId>bom-2.414.x</artifactId>
-                <version>2982.vdce2153031a_0</version>
+                <artifactId>bom-2.452.x</artifactId>
+                <version>3010.vec758b_8e7da_3</version>
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
@@ -85,7 +85,6 @@
         <dependency>
             <groupId>io.jenkins.plugins</groupId>
             <artifactId>jquery3-api</artifactId>
-            <version>3.7.1-2</version>
         </dependency>
         <!-- Optional dependencies for using Spock -->
         <dependency>

From fdfa404e3109a8561719155db9aa5e31dcca77de Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 12:14:25 -0500
Subject: [PATCH 53/59] delete unused handlebar helpers

---
 .../BuildCardExtension/build-card-script-helpers.js        | 7 -------
 .../extension/BuildCardExtension/buildCardHelpers.jelly    | 4 ----
 2 files changed, 11 deletions(-)
 delete mode 100644 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-script-helpers.js

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-script-helpers.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-script-helpers.js
deleted file mode 100644
index 2d48ffaa..00000000
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-script-helpers.js
+++ /dev/null
@@ -1,7 +0,0 @@
-Handlebars.registerHelper('startScript', function() {
-    return new Handlebars.SafeString("<scr" + "ipt>");
-});
-
-Handlebars.registerHelper('endScript', function() {
-    return new Handlebars.SafeString("</scr" + "ipt>");
-});
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
index e71a4ee4..cd5f1d99 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
@@ -8,9 +8,5 @@
         By default we just include helpers to append script tags to your build card
     -->
     <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.extension.BuildCardExtension.build-card-script-helpers"/>
-    <![CDATA[
 
-
-
-    ]]>
 </j:jelly>
\ No newline at end of file

From b58990c3988570f992a5705bca01cc8d33438f23 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 12:16:14 -0500
Subject: [PATCH 54/59] delete unused handlebar helpers

---
 .../extension/BuildCardExtension/buildCardHelpers.jelly          | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
index cd5f1d99..5cd58cab 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardHelpers.jelly
@@ -7,6 +7,5 @@
 
         By default we just include helpers to append script tags to your build card
     -->
-    <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.extension.BuildCardExtension.build-card-script-helpers"/>
 
 </j:jelly>
\ No newline at end of file

From bacdf4979b99084e6e8c73bbd94437e6830587e9 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 12:40:12 -0500
Subject: [PATCH 55/59] remove redundant class

---
 .../buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js     | 2 +-
 .../hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
index 5fc5c577..97580dab 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -7,7 +7,7 @@ Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.Trig
     });
 });
 
-Behaviour.specify(".bpp-trigger-pipeline-button", 'BuildPipelineView.TriggerPipeline', 0, function(element) {
+Behaviour.specify("#trigger-pipeline-button", 'BuildPipelineView.TriggerPipeline', 0, function(element) {
     element.addEventListener('click', function(e) {
         document.getElementById('triggerPipelineForm').submit();
     });
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index 6198d6ad..3e5a7479 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -70,7 +70,7 @@
                 </span>
             </j:if>
             <j:if test="${!from.isProjectParameterized()}">
-              <a class="bpp-trigger-pipeline-button" id="trigger-pipeline-button" href='#'>
+              <a id="trigger-pipeline-button" href='#'>
                 <l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
                                 <span>Run</span>
               </a>

From e369dafc246e9038b27512122ed96a3a70967af1 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 12:56:25 -0500
Subject: [PATCH 56/59] remove redundant class

---
 .../build-parameters-tooltip.js                    | 14 ++++++--------
 .../AbstractNameValueHeader/rowHeader.jelly        |  3 +--
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js
index 5d478607..fc866b44 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js
@@ -1,8 +1,6 @@
-document.addEventListener('DOMContentLoaded', function() {
-    const buildId = document.querySelector('.build-parameters-trigger-id').dataset.buildId;
-    jQuery('#build-parameters-trigger-' + buildId).tooltip({
-        bodyHandler: function() {
-            return jQuery('#build-parameters-' + buildId).html();
-        },
-    });
-});
+const buildId = document.querySelector('.pipeline-info .revision .title').dataset.buildId;
+jQuery('#build-parameters-trigger-' + buildId).tooltip({
+    bodyHandler: function() {
+        return jQuery('#build-parameters-' + buildId).html();
+    },
+});
\ No newline at end of file
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
index 27201b0b..a4cfd541 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
@@ -8,7 +8,7 @@
 
     <div class="pipeline-info">
         <div class="revision rounded">
-            <div class="title build-parameters-trigger-id" data-build-id="${buildGrid.get(0,0).getId()}" id="build-parameters-trigger-${buildGrid.get(0,0).getId()}">Pipeline ${buildGrid.get(0,0).getRevision()}</div>
+            <div class="title" data-build-id="${buildGrid.get(0,0).getId()}" id="build-parameters-trigger-${buildGrid.get(0,0).getId()}">Pipeline ${buildGrid.get(0,0).getRevision()}</div>
             <j:choose>
                 <j:when test="${buildGrid.get(0,0).getParameters().isEmpty()}">
                     <div class="description">No parameters</div>
@@ -29,4 +29,3 @@
 
 
 </j:jelly>
-

From f3408d897cadbcbc736667ac419eb9a49b4d54c6 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 12:57:16 -0500
Subject: [PATCH 57/59] remove redundant class

---
 .../extension/AbstractNameValueHeader/rowHeader.jelly            | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
index a4cfd541..4c339988 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
@@ -29,3 +29,4 @@
 
 
 </j:jelly>
+

From cfae875a09d00e0eca79747ca3853f865bd066c0 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 15:45:26 -0500
Subject: [PATCH 58/59] remove redundant span, add attributes to trigger span

---
 .../buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js  | 5 ++---
 .../hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly  | 3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
index 97580dab..16dbaa11 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -1,8 +1,7 @@
 Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.TriggerPipelineParameterized', 0, function(element) {
     element.addEventListener('click', function() {
-        const paramsElement = document.querySelector('.bpp-trigger-pipeline-parameterized-params');
-        const href = paramsElement.dataset.fillDialogHref;
-        const title = paramsElement.dataset.fillDialogTitle;
+        const href = element.dataset.fillDialogHref;
+        const title = element.dataset.fillDialogTitle;
         buildPipeline.fillDialog(href, title);
     });
 });
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index 3e5a7479..6ab50783 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -63,8 +63,7 @@
         <j:if test="${hasBuildPermission}">
             <div class="icon-container">
             <j:if test="${from.isProjectParameterized()}">
-                <span class="bpp-trigger-pipeline-parameterized-params" data-fill-dialog-href="${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec" data-fill-dialog-title="Starts the pipeline with parameters" style="display: none" />
-                <span class="bpp-trigger-pipeline-parameterized pointer">
+                <span class="bpp-trigger-pipeline-parameterized pointer" data-fill-dialog-href="${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec" data-fill-dialog-title="Starts the pipeline with parameters">
                     <l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
                                 <span>Run</span>
                 </span>

From b3e23dada97dcf15e0b6c3a94721e041a49af71a Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Sun, 10 Nov 2024 09:29:14 -0500
Subject: [PATCH 59/59] remove redundant parameters span

---
 .../build-card-template-onclicks.js           | 12 +++-------
 .../buildCardTemplate.jelly                   | 24 +++++++------------
 2 files changed, 11 insertions(+), 25 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
index ccad37db..d100030c 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
@@ -45,11 +45,7 @@ function createClickHandler(parentElement, targetSelector, handlerFn) {
         const clickTarget = event.target.closest(targetSelector);
         if (!clickTarget || !parentElement.contains(clickTarget)) return;
 
-        const buildCard = clickTarget.closest(".build-card");
-        if (!buildCard) return;
-
-        const dataContainer = buildCard.querySelector(targetSelector + "-params");
-        handlerFn(dataContainer);
+        handlerFn(clickTarget);
     };
 
     parentElement.addEventListener("click", newHandler);
@@ -88,10 +84,8 @@ document.addEventListener("DOMContentLoaded", function () {
     if (!pipelineWrappers.length) return;
 
     pipelineWrappers.forEach(wrapper => {
-        Object.entries(onclickElements).forEach(function(entry) {
-            const selector = entry[0];
-            const handlerConfig = entry[1];
-            createClickHandler(wrapper, selector, handlerConfig.handler);
+        Object.entries(onclickElements).forEach(function([selector, { handler }]) {
+            createClickHandler(wrapper, selector, handler);
         });
     });
 });
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
index dbe53222..e41192b8 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
@@ -61,8 +61,7 @@
         {{#unless project.disabled}}
         <div class="status-bar" id="status-bar-{{id}}">
             {{#if build.isBuilding}}
-                <span class="bct-progress-bar-onclick-params" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
-                <div class="bct-progress-bar-onclick">
+                <div class="bct-progress-bar-onclick" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}">
                     <table class="progress-bar" align="center">
                         <tbody>
                             <tr title="Estimated remaining time: {{build.estimatedRemainingTime}}">
@@ -95,8 +94,7 @@
                             </a>
                         </j:when>
                         <j:otherwise>
-                            <span class="bct-console-icon-onclick-params" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}" style="display:none"/>
-                            <span class="bct-console-icon-onclick" >
+                            <span class="bct-console-icon-onclick" data-fill-dialog-href="${app.rootUrl}{{build.url}}console" data-fill-dialog-title="Console output for {{project.name}} #{{build.number}}">
                                 <l:icon src="${consoleOutputIconUrl} icon-sm" alt="console" />
                             </span>
                         </j:otherwise>
@@ -108,8 +106,7 @@
                 {{#if build.isSuccess}}
                     {{#if ${!it.triggerOnlyLatestJob}}}
                     <j:if test="${it.hasBuildPermission()}">
-                    <span class="bct-rerun-successful-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
-                    <span class="bct-rerun-successful-build-onclick">
+                    <span class="bct-rerun-successful-build-onclick" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}">
                         <l:icon src="icon-clock icon-sm" alt="re-run" />
                     </span>
                     </j:if>
@@ -118,21 +115,18 @@
                     {{#if ${it.triggerOnlyLatestJob}}}
                         {{#if build.isLatestBuild}}
                             {{#if build.isUpstreamBuildLatest}}
-                            <span class="bct-rerun-failed-latest-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
-                            <span class="bct-rerun-failed-latest-build-onclick">
+                            <span class="bct-rerun-failed-latest-build-onclick" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
                             </span>
                             {{/if}}
                         {{/if}}
                     {{else}}
                         {{#if build.isManualTrigger}}
-                            <span class="bct-rerun-failed-manual-build-onclick-params" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
-                            <span class="bct-rerun-failed-manual-build-onclick">
+                            <span class="bct-rerun-failed-manual-build-onclick" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
                             </span>
                         {{else}}
-                            <span class="bct-rerun-failed-build-onclick-params" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
-                            <span class="bct-rerun-failed-build-onclick">
+                            <span class="bct-rerun-failed-build-onclick" data-show-spinner-id="{{id}}" data-rerun-build-ext-id="{{build.extId}}" data-rerun-build-dependency-ids="{{build.dependencyIds}}">
                                 <l:icon src="icon-clock icon-sm" alt="retry" />
                             </span>
                         {{/if}}
@@ -143,14 +137,12 @@
             {{#if build.isReadyToBeManuallyBuilt}}
                 {{#if ${it.triggerOnlyLatestJob}}}
                     {{#if build.isUpstreamBuildLatestSuccess}}
-                    <span class="bct-trigger-manual-build-latest-onclick-params" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
-                    <span class="bct-trigger-manual-build-latest-onclick">
+                    <span class="bct-trigger-manual-build-latest-onclick" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}">
                         <l:icon src="icon-clock icon-sm" alt="trigger" />
                     </span>
                     {{/if}}
                 {{else}}
-                <span class="bct-trigger-manual-build-onclick-params" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}" style="display: none;" />
-                <span class="bct-trigger-manual-build-onclick">
+                <span class="bct-trigger-manual-build-onclick" data-show-spinner-id="{{id}}" data-upstream-project-name="{{upstream.projectName}}" data-upstream-build-number="{{upstream.buildNumber}}" data-project-name="{{project.name}}" data-dependency-ids="{{build.dependencyIds}}">
                     <l:icon src="icon-clock icon-sm" alt="trigger" />
                 </span>
                 {{/if}}