Skip to content

[JENKINS-76254] Register NTLM authentication support explicitly #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[JENKINS-76254] Register NTLM authentication support explicitly #223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
353e448
Register NTLM authentication support explicitly
strangelookingnerd Nov 5, 2025
6bde3c0
Merge branch 'master' into JENKINS-76254
strangelookingnerd Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/main/java/jenkins/plugins/http_request/auth/CredentialNtlmAuthentication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,21 @@

import java.io.PrintStream;
import java.net.URISyntaxException;
import java.util.List;

import org.apache.hc.client5.http.auth.AuthSchemeFactory;
import org.apache.hc.client5.http.auth.StandardAuthScheme;
import org.apache.hc.client5.http.classic.methods.HttpUriRequestBase;
import org.apache.hc.client5.http.config.RequestConfig;
import org.apache.hc.client5.http.impl.auth.BasicCredentialsProvider;
import org.apache.hc.client5.http.auth.AuthScope;
import org.apache.hc.client5.http.auth.NTCredentials;
import org.apache.hc.client5.http.impl.auth.NTLMSchemeFactory;
import org.apache.hc.client5.http.impl.classic.CloseableHttpClient;
import org.apache.hc.client5.http.impl.classic.HttpClientBuilder;
import org.apache.hc.client5.http.protocol.HttpClientContext;
import org.apache.hc.core5.http.config.Lookup;
import org.apache.hc.core5.http.config.RegistryBuilder;

import com.cloudbees.plugins.credentials.common.StandardUsernamePasswordCredentials;

Expand Down Expand Up @@ -59,8 +66,21 @@
new AuthScope(requestBase.getUri().getHost(), requestBase.getUri().getPort()),
new NTCredentials(username, password.toCharArray(), requestBase.getUri().getHost(), domain));

clientBuilder.setDefaultCredentialsProvider(provider);
// register NTLM authentication support explicitly
Lookup<AuthSchemeFactory> authRegistry = RegistryBuilder.<AuthSchemeFactory>create()
.register(StandardAuthScheme.NTLM, NTLMSchemeFactory.INSTANCE)
.build();
RequestConfig config = RequestConfig.custom().setTargetPreferredAuthSchemes(List.of(StandardAuthScheme.NTLM))
.build();

clientBuilder
.setDefaultRequestConfig(config)
.setDefaultCredentialsProvider(provider)
.setDefaultAuthSchemeRegistry(authRegistry);

context.setRequestConfig(config);
context.setCredentialsProvider(provider);
context.setAuthSchemeRegistry(authRegistry);

Check warning on line 83 in src/main/java/jenkins/plugins/http_request/auth/CredentialNtlmAuthentication.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines 

Lines 70-83 are not covered by tests

return clientBuilder.build();
} catch (URISyntaxException ex) {
Expand Down